[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-19 Thread Emmet Hikory
Update of patch #4679 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Emmet Hikory
Update of patch #4679 (project freeciv): Status: Need Info = Ready For Test Summary: Remove nreqs support entirely = Convert nreqs to reqs on ruleset load, and only use reqs internally.

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Marko Lindqvist
Follow-up Comment #4, patch #4679 (project freeciv): I assume that freeciv-ruledit now does not save anything as nreqs, but ruleset get converted to present=FALSE model simply by loading it to freeciv-ruledit and saving. ___ Reply to this

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Emmet Hikory
Follow-up Comment #5, patch #4679 (project freeciv): I haven't tested that, but loading should convert, and I removed the save function for nreqs, so it should always save to reqs. At the current state of development, my interaction with freeciv-ruledit is mostly limited to making sure it

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Marko Lindqvist
Follow-up Comment #6, patch #4679 (project freeciv): The only test-case I ever use for freeciv-ruledit part when changing ruleset format is 1) Load ruleset to it 2) Save 3) Try to load that ruleset saved by freeciv-ruledit to server (4) In some simple cases also manually inspect saved rulesets

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Emmet Hikory
Follow-up Comment #7, patch #4679 (project freeciv): Tested with something similar to a reversion of patch #4411 (some interaction with bug #22080 means I may not have gotten this perfectly correct), and from manual inspection of the ruledit-generated effects.ruleset, it appears that this does

[Freeciv-Dev] [patch #4679] Convert nreqs to reqs on ruleset load, and only use reqs internally.

2014-06-17 Thread Emmet Hikory
Follow-up Comment #8, patch #4679 (project freeciv): Found a few more instances when trying to work on the logical next patch: expanded patch attached. (file #21074) ___ Additional Item Attachment: File name: