Update of patch #4893 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/patch/?4893
Summary: Make requirement types that check unit state
possible
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 02 Jul 2014 08:47:39 PM UTC
Category: general
Follow-up Comment #1, patch #4893 (project freeciv):
This looks like it is only an API change. Would it make sense to add a
preface in is_req_active that sets target_unittype in the event that
target_unit != NULL target_unittype == NULL? If not, perhaps at least a
sanity assertion that
Follow-up Comment #2, patch #4893 (project freeciv):
_This looks like it is only an API change._
Correct.
_Would it make sense to add a preface in is_req_active that sets
target_unittype in the event that target_unit != NULL target_unittype ==
NULL?_
Great idea. Added.
(file #21257)