[Freeciv-Dev] (PR#40090) city.ai should be pointer

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40090 city.ai should be pointer, and value should be NULL in client side. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Fix to actual bug. Needs some more testing to check if this is the only problem. - ML diff -Nurd -X.diff_ignore freeciv/ai/aitools.c freeciv/ai/aitools.c --- freeciv/ai/aitools.c 2008-01-20 04:02:14.0 +0200 +++

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Thank you for finding my mistake in PR#39553! This worthless function is only called 4 places, and the first place I've looked is: ai/advmilitary.c:1223: if (best_choice.want choice-want) { /* We want attacker more than what

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Here's my proposed patch to rid us of this troublesome beast Index: ai/advdomestic.c === --- ai/advdomestic.c(revision 14391) +++ ai/advdomestic.c(working copy)

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 On 10/02/2008, William Allen Simpson wrote: Here's my proposed patch to rid us of this troublesome beast I'd rather keep the function. Even though 'better' choice is currently determined simply by comparing want value, that's

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 OK, seems reasonable. I'd say commit. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40091) Aboriginal American nations

2008-02-10 Thread Daniel Markstedt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40091 Batch of aboriginal American nations, written by guestmania. Source: http://forum.freeciv.org/viewtopic.php?t=2273 Abá Chumash Hasinay Mi'kmaq Miskito Mwiska Shawnee Unagan Flags not included.

[Freeciv-Dev] (PR#40092) 2.2-test: fix update_dumb_city() missing update_vision_site_from_city()

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40092 In PR#40072, the second reported error has Teotitlan shown with the wrong owner. This patch does not fix the underlying issue, but is a step toward making the savegame playable. The savegame.c:2800 code tries to fix inconsistent games.

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything (fix)

2008-02-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Not having seen anything in 12 hours, and the proposed patch being so trivial, Committed trunk revision 14396. Committed S2_2 revision 14397. Thanks, Marko! ___ Freeciv-dev mailing list