[Freeciv-Dev] [patch #1446] [Metaticket] Ruleset object
Follow-up Comment #4, patch #1446 (project freeciv): 1 2) I have already thought about a such solution for numerous structures of Freeciv. However, this is quite problematic. Most ruleset types for example need a translation support that need a gettext() pointer, which cannot be used in a packet structure. What do you mean with gettext point? The for translation marked texts in the ruleset files? Internally the untranslated texts are used and they are translated before they are displayed, or? ___ Reply to this item at: http://gna.org/patch/?1446 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Update of bug #15832 (project freeciv): Status:None = Ready For Test Assigned to:None = syntron Release: = svn 17296 Planned Release: = 2.3.0 ___ Follow-up Comment #1: it is due to gna patch #1592. I did not test the xaw client after the many rebases of the patch ... patch attached (file #8890) ___ Additional Item Attachment: File name: fix-xaw.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Update of bug #15832 (project freeciv): Status:None = Works For Me Assigned to:None = syntron Planned Release: = 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Update of bug #15832 (project freeciv): Release: = svn 17296 ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Update of bug #15832 (project freeciv): Release: = svn 17296 ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Update of bug #15832 (project freeciv): Status:Works For Me = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15808] Cosmetic English grammar/spelling/typographical fixes in strings
Update of bug #15808 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?15808 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15802] bad english sure to sell in cityrep
Update of bug #15802 (project freeciv): Assigned to: jdorje = jtn Planned Release: = 2.2.1 ___ Reply to this item at: http://gna.org/bugs/?15802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15802] bad english sure to sell in cityrep
Follow-up Comment #1, bug #15802 (project freeciv): Applying this patch at the same time as bug #15808 so as to deal with po-files in one go. ___ Reply to this item at: http://gna.org/bugs/?15802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #2, bug #13709 (project freeciv): I do not know lua. But if there are no compatibility problems I think this can go into 2.2.1. Do we need toluaxx after this change? ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15808] Cosmetic English grammar/spelling/typographical fixes in strings
Update of bug #15808 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15808 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15802] bad english sure to sell in cityrep
Update of bug #15802 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15345] Help: document new features illness and migration
Update of bug #15345 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?15345 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15345] Help: document new features illness and migration
Update of bug #15345 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15345 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #3, bug #13709 (project freeciv): Replying in ticket so discussion can be found from tracker later. Is it okay to patch tolua-5.1 to use tolua_outside. The implementation is already attached and is relatively trivial. This is a feature that makes a lot of sense for Freeciv's object oriented C. Is it then okay, to add a further feature to tolua-5.1? Obvious disadvantage is that if we start patching tolua, we (and 'we' here might be group of people in which neither of us remain at the time) have to maintain those patches when we update to new versions of tolua. I guess you are the expert here. If you think that pros are bigger than cons, I'm not objecting such tolua patching. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15825] ggz page halted client
Follow-up Comment #1, bug #15825 (project freeciv): Without a backtrace on this it'll be really hard to do anything with it. If it ever happens again, give the client a SEGV (killall -SEGV freeciv-gtk) and get a backtrace from the resulting core file. ___ Reply to this item at: http://gna.org/bugs/?15825 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15832] trunk will not compile
Follow-up Comment #2, bug #15832 (project freeciv): updated patch; include missing calls to cm_result_new() (file #8892) ___ Additional Item Attachment: File name: 20100410-03-trunk-comilation-fix-for-xaw-client.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?15832 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15839] remove pcity-server.vision checks in the client
URL: http://gna.org/bugs/?15839 Summary: remove pcity-server.vision checks in the client Project: Freeciv Submitted by: syntron Submitted on: Samstag 10.04.2010 um 20:55 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: syntron Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: pcity-server is an union with pcity-client thus access is not allowed on the client side ___ File Attachments: --- Date: Samstag 10.04.2010 um 20:55 Name: 20100408-04-trunk-remove-pcity-server.vision-checks-in-the-client.patch Size: 1kB By: syntron http://gna.org/bugs/download.php?file_id=8897 ___ Reply to this item at: http://gna.org/bugs/?15839 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15839] remove pcity-server.vision checks in the client
Update of bug #15839 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?15839 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1574] add a player to a running game
Follow-up Comment #6, patch #1574 (project freeciv): new version of the patch (code cleanup) Another option is to not make a /create command (while game is running), but just make it a Lua script action, we make create_player(..) that calls the player creation code you have written. That way, there is no way to create empty players by default.. I think this is the best way to go. Changing the patch, I had to create two functions - one for pregame and one for newcomers. Furthermore, this will prevent empty player and also this is only usefull in connection to the lua code. What do you need to call C code from lua? A function name? (file #8898) ___ Additional Item Attachment: File name: 20100408-02-trunk-add-a-player-to-a-running-game.patch Size:13 KB ___ Reply to this item at: http://gna.org/patch/?1574 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1574] add a player to a running game
Follow-up Comment #7, patch #1574 (project freeciv): Here is how to add a function to the API. It's called 'create_player' in the API (rhymes well with create_unit, create_base, etc). All is needs is that the wrapper function api_actions_create_player in server/scripting/api_actions.h can find call a function. In this diff, it needs a function called 'create_newcomer_player' from plrhand.h (?) that will return the player just created if successful, else return NULL. (The API's Player is the same as struct player) (file #8899) ___ Additional Item Attachment: File name: newcomer_api.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?1574 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #4, bug #13709 (project freeciv): Thanks for your thoughts. I've been missing more discussion about script/api changes. Given how little that happened with scripting before, and how much that is possible now given the momentum we have (right now), I think we should just go forward with tolua-5.1.. Depending on a small modification for tolua_outside is not so bad; it's not about mechanics but simply the syntax of our api.pkg file. .. Quoting the email I sent about the tolua_notnil suggestion: Followup question to Marko: Is it then okay, to add a further feature to tolua-5.1? I want a variable modifier 'tolua_notnil' to mark those API function arguments that may not be nil (converted to NULL). The intended change reduces overhead (less code in tolua, since explicit isnil || isusertype check is changed to isusertype) and we can remove almost all our SCRIPT_ASSERT / argument checking boilerplate (which is much less code), and user error messages will be easier to understand (for example: argument #2 is 'nil', expected 'Building_Type') I have a working prototype of tolua_notnil Compatibility notes: If we use tolua_outside, our api.pkg will depend on that modification of tolua (however toluaxx and tolua++ are compatible alternatives). If we use tolua_notnil, it is still possible to use an unpatched tolua (losing the safety) by just undefining tolua_notnil: $#ifndef tolua_notnil $#define tolua_notnil $#endif tolua_notnil is part of my project to make sure there can't be any wild pointers accessible from our Lua API (If you wonder how right now, start with just saving a unit pointer in lua until after the unit is killed. You can also use 'Unit[.get][owner](find.player(1))' for example to the equivalent of ((struct unit *)pplayer)-owner.). This is a much deeper question that will take lots of time. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
Update of bug #15738 (project freeciv): Status: Ready For Test = Need Info Assigned to: englabenny = None ___ Follow-up Comment #17: I don't think I can solve this, if we need to change the common mapview code. ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'
URL: http://gna.org/patch/?1611 Summary: Scripting: Hide Lua module 'debug' Project: Freeciv Submitted by: englabenny Submitted on: lördag 2010-04-10 den 22:47 Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: englabenny Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: We load the debug library, but do not make it available in the Lua API. The debug module allows access to (among other things) the registry, and upvalues (local variables of closures). This is step one of very many, where we try to disallow wild pointer access in Lua. ___ File Attachments: --- Date: lördag 2010-04-10 den 22:47 Name: 2010041101-Scripting-Hide-Lua-module-debug.patch Size: 3 kB By: englabenny http://gna.org/patch/download.php?file_id=8900 ___ Reply to this item at: http://gna.org/patch/?1611 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security
Update of bug #15725 (project freeciv): Depends on: = patch #1611 ___ Reply to this item at: http://gna.org/bugs/?15725 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1599] Scripting: Limit execution time
Update of patch #1599 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1599 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1562] API: Define convenience functionality for Types
Update of patch #1562 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1562 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1602] API: Introduce players_iterate() and whole_map_iterate()
Update of patch #1602 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1602 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15841] API: Do not use tolua_outside
URL: http://gna.org/bugs/?15841 Summary: API: Do not use tolua_outside Project: Freeciv Submitted by: englabenny Submitted on: söndag 2010-04-11 den 01:08 Category: None Severity: 3 - Normal Priority: 1 - Later Status: Ready For Test Assigned to: englabenny Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Not compatible with standard tolua (5.1) To reduce boilerplate, we simply use nested modules to declare class methods. ___ File Attachments: --- Date: söndag 2010-04-11 den 01:08 Name: 2010041101-API-Do-not-use-tolua_outside.patch Size: 8 kB By: englabenny http://gna.org/bugs/download.php?file_id=8902 ___ Reply to this item at: http://gna.org/bugs/?15841 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Assigned to: cazfi = englabenny Depends on: = bugs #15841 ___ Follow-up Comment #5: I hope you don't mind, I'm assigning this bug to me. Added dependency on remove tolua_outside patch. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1603] API: Add Player:civilization_score() and Player:gold() accessors
Additional Item Attachment, patch #1603 (project freeciv): File name: 2010041102-API-Add-Player-civilization_score-and-Player-g.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?1603 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1604] API: Add Tile:square_iterate(..), Tile:circle_iterate(..)
Additional Item Attachment, patch #1604 (project freeciv): File name: 2010041103-API-Add-Tile-square_iterate-.-Tile-circle_iter.patch Size:6 KB ___ Reply to this item at: http://gna.org/patch/?1604 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1605] API: Add Tile:city() and Tile:num_units() accessors
Additional Item Attachment, patch #1605 (project freeciv): File name: 2010041104-API-Add-Tile-city-and-Tile-num_units-accessors.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?1605 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1606] API: Add Tile, Player:units_iterate(), and Player:cities_iterate()
Additional Item Attachment, patch #1606 (project freeciv): File name: 2010041105-API-Add-Tile-Player-units_iterate-and-Player-c.patch Size:9 KB ___ Reply to this item at: http://gna.org/patch/?1606 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
