[Freeciv-Dev] [bug #20361] Pathfinding may prefer move+attack to simply attacking adjacent target

2012-12-10 Thread Silas Brill
URL:
  http://gna.org/bugs/?20361

 Summary: Pathfinding may prefer move+attack to simply
attacking adjacent target
 Project: Freeciv
Submitted by: brilliand
Submitted on: Mon 10 Dec 2012 09:49:56 AM GMT
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.1
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

I have a dragoon in a city on a hill, and I want to use that dragoon to attack
a cannon on a diagonally adjacent hill.  However, the target hill has a river,
which seems to be throwing off the pathfinding.

+-+-+
| Hill+River (Cannon) | Plains  |
| Grassland+River | Hill+City (Dragoon) |
+-+-+

When I try to attack the cannon, the dragoon opts to move through the
Grassland+River tile, which would surely by the right move if the other hill
were not occupied.  However, in this case such a move results in my dragoon
stepping outside the safety of the city into a relatively hard-to-defend
grassland tile, and throwing one of my cities into disorder for a turn because
I'm running a democracy in the civ2 ruleset.

(I also have a musketeer in that city, which is able to attack without
triggering this bug, but when I do that the cannon wins the fight.  I'm not
sure whether that's another bug or there's some rule I'm missing that would
make that make sense.)

I've attached a savegame - the city in question is Mixcoac.



___

File Attachments:


---
Date: Mon 10 Dec 2012 09:49:56 AM GMT  Name: bugged_save.sav.bz2  Size: 27kB  
By: brilliand

http://gna.org/bugs/download.php?file_id=16836

___

Reply to this item at:

  http://gna.org/bugs/?20361

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20224] Double click on unit on gtk3 unit selection dialog crashes client

2012-12-10 Thread Marko Lindqvist
Update of bug #20224 (project freeciv):

  Status:None = Duplicate  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 

___

Follow-up Comment #1:

I now assume that this is same as bug #19846, just with newer gtk+ version.

___

Reply to this item at:

  http://gna.org/bugs/?20224

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19846] Closing unit select dialog asserts

2012-12-10 Thread Marko Lindqvist
Update of bug #19846 (project freeciv):

Severity:  3 - Normal = 5 - Blocker
 Planned Release:   2.4.0 = 2.4.0, 2.5.0   

___

Follow-up Comment #5:

See also bug #20224 - presumably because of newer gtk+ this is no longer mere
gtk+ assert, but crashes the client.

___

Reply to this item at:

  http://gna.org/bugs/?19846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20361] Pathfinding may prefer move+attack to simply attacking adjacent target

2012-12-10 Thread David Lowe
Follow-up Comment #1, bug #20361 (project freeciv):

I assume the relevant difference between the Musketeer and the Dragoon is that
the Musketeer only has one movement point, so the Dragoon could afford to move
before attacking.  The problem is, that the pathfinder is optimized to use
less movement points on the route and, as you surmised, will prefer the river.
 The question is why doesn't the pathfinder see not moving before the attack
as the optimum use of movement points? 

___

Reply to this item at:

  http://gna.org/bugs/?20361

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20109] Compilation fails with stdinhand on OSX (‘rl_completion_suppress_append’ undeclared)

2012-12-10 Thread Marko Lindqvist
Update of bug #20109 (project freeciv):

 Planned Release:   2.3.3,2.4.0,2.5.0 = 2.3.4,2.4.0,2.5.0  


___

Reply to this item at:

  http://gna.org/bugs/?20109

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong

2012-12-10 Thread Marko Lindqvist
Update of bug #2 (project freeciv):

  Status:None = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?2

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20362] Frecost not applied to Philosophy bonus tech

2012-12-10 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20362

 Summary: Frecost not applied to Philosophy bonus tech
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 10 Dec 2012 07:07:10 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.4, 2.4.0

___

Details:

As mentioned in bug #19973, freecost is not applied to techs gained as bonus
tech after discovering another tech (Philosophy). This is already fixed in
TRUNK as part of patch #3552. Attached is  fix for S2_4  S2_3.

Due to other bugs, this is fix alone is unlikely to have any actual effect:
1) Though they should be free techs, full cost is deducted from bulbs (with
this patch full cost *+* freecost)
2) After that any negative bulb count is set to 0
In practice full cost drives bulb count to negative, so end result is always 0
bulbs.



___

File Attachments:


---
Date: Mon 10 Dec 2012 07:07:10 PM EET  Name: PhilosophyFreeCost.patch  Size:
399B   By: cazfi

http://gna.org/bugs/download.php?file_id=16837

___

Reply to this item at:

  http://gna.org/bugs/?20362

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19973] Negative bulbs ignored

2012-12-10 Thread Marko Lindqvist
Follow-up Comment #3, bug #19973 (project freeciv):

 already makes free tech cost applied for bonus tech case in TRUNK

Stable branches: bug #20362

___

Reply to this item at:

  http://gna.org/bugs/?19973

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20362] Frecost not applied to Philosophy bonus tech

2012-12-10 Thread Marko Lindqvist
Follow-up Comment #1, bug #20362 (project freeciv):

- Workaround the other bugs too (1 won't have better fix in stable branches
(in TRUNK it does not exist), and same workaround happens to fix 2 too in this
case - it will be fixed in general case separately)

(file #16838)
___

Additional Item Attachment:

File name: PhilosophyFreeCost-2.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?20362

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19973] Negative bulbs ignored

2012-12-10 Thread Marko Lindqvist
Update of bug #19973 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.4.0, 2.5.0   

___

Follow-up Comment #4:

tech_found() refuses to make bulbs count negative. Fix attached.

Given the buggy way negative bulbs count causes tech loss, stable branches are
a bit problematic. I think it's best to apply this to TRUNK (tech loss
sensible) and S2_4 (tech loss prevented in rulesets without tech upkeep, so
classic rules work correctly), but not to S2_3.

(file #16839)
___

Additional Item Attachment:

File name: FullTechCost.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?19973

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Freeciv 2.3.3 released

2012-12-10 Thread Jacob Nevins
Freeciv 2.3.3 is now available for download.

This release fixes a variety of bugs in 2.3.2. See more details at
http://www.freeciv.org/wiki/NEWS-2.3.3, or NEWS-2.3 in the source
distribution.

Source code and Windows packages are available from
http://www.freeciv.org/wiki/Download#Stable_2.3.

On behalf of the Freeciv Dev Team,
  Jacob Nevins

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev