[Freeciv-Dev] [bug #22405] Base help & lack of happyborders

2014-07-30 Thread Marko Lindqvist 
Update of bug #22405 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #1:

Fix

(file #21592, file #21593)
___

Additional Item Attachment:

File name: HappyBaseHelp.patchSize:0 KB
File name: HappyBaseHelp-2.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4996] Metaknowledge for Terrain, TerrainFlag, TerrainClass, Resource, Extra, BaseFlag and RoadFlag

2014-07-30 Thread Sveinung Kvilhaugsvik 
Update of patch #4996 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22401] Freeciv ruledit stores appended requirements to action enablers

2014-07-30 Thread Sveinung Kvilhaugsvik 
Update of bug #22401 (project freeciv):

Category:None => freeciv-ruledit
  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Assertion failure while loading classic in Freeciv
ruledit
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 30 Jul 2014 11:50:40 AM UTC
Category: freeciv-ruledit
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

1: in is_native_to_class() [movement.c::305]: assertion '((void *)0) !=
punitclass->cache.native_tile_extras' failed.
1: Please report this message at http://gna.org/projects/freeciv/





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread pepeto 
Follow-up Comment #1, bug #22407 (project freeciv):

This looks like bug #22346.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread Sveinung Kvilhaugsvik 
Update of bug #22407 (project freeciv):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

_This looks like bug #22346._
I think you are correct.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22400] Stealing random and future tech don't work

2014-07-30 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #2, bug #22400 (project freeciv):

New version attached. It ignores numbering. It merges the two if statements
that validated tech target.

_Your test looks a bit weak._
Correct. A new renumbering could have broken it.

_What would happen if the tech is A_LAST? Or if the tech is out of ruleset
limits?_
The if statement below would have caught it. (They are merged in the new
patch. Easier to read)

(file #21594)
___

Additional Item Attachment:

File name: 0001-Fix-spy-stealing-of-future-techs-and-of-techs-chosen.patch
Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread pepeto 
Follow-up Comment #1, bug #22404 (project freeciv):

IIRC, my original plan was to initialize this variable in the switch
statement. case 0 should have "=" instead of "+=", and case 1,2,3,4 should
have it initialized. Else, there is no sense to set it explicitly for the
default case.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5002] Minimum libtool version 1.5.2

2014-07-30 Thread Marko Lindqvist 
URL:
  

 Summary: Minimum libtool version 1.5.2
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 30 Jul 2014 07:54:04 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Make minimum libtool version 1.5.2

That version fixes usage with pthreads in some exotic cases. Let's require at
least that version to avoid surprises. The version is over a decade old
already, so this is quite a low requirement.
OTOH older versions work almost always, so we shouldn't bump the requirement
in stable branches, breaking builds that have previously worked in the said
branch.




___

File Attachments:


---
Date: Wed 30 Jul 2014 07:54:04 PM EEST  Name: Libtool152.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-07-30 Thread Marko Lindqvist 
Follow-up Comment #3, patch #4759 (project freeciv):

As the version this development branch leads to is not freeciv-2.7 but
freeciv-3.0, version number could be 2.99.0 or 2.99.99 (I prefer former, but
need to check if our code assumes development version micro to be "99")
instead of 2.6.99.

- Minor "99" could be used as flag value to know that major version is about
to increase. We can't deduct the same from minor "6", micro "99". This would
make patch #4747 easy.
- That would leave space in case we (or some fork) decides to continue
freeciv-2 development a bit longer and to release 2.7. 3.0 development version
version number should not be lower than that.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22398] can_build_extra_base() has EC_BASE check reversed

2014-07-30 Thread Marko Lindqvist 
Update of bug #22398 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22399] Negative tech want for building effect

2014-07-30 Thread Marko Lindqvist 
Update of bug #22399 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22378] Specialist name with space breaks savegames

2014-07-30 Thread Marko Lindqvist 
Update of bug #22378 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread Marko Lindqvist 
Follow-up Comment #2, bug #22404 (project freeciv):

I see at least three ways one could argue to be the right way to do this. I
don't have strong opinion about this. Do you want to implement the patch some
certain way? If my original patch is to be used, it should be changed at least
to initialize with "0.0" instead of "0" and drop assignment of "0.0" from
default case.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4830] Multipliers to effects

2014-07-30 Thread Marko Lindqvist 
Follow-up Comment #30, patch #4830 (project freeciv):

> In multipliers.c: do multipliers, multiplier_count, and
> multiplier_used need the "static" keyword? I had thought this
> was necessary for persistent variables defined at file scope.

Good catch. They should not be globals but limited to module scope. I'll fix
that.

> In handle_ruleset_multiplier(), is there a reason to use
> get_multiplier_count()+1 rather than get_multiplier_count()++

1) It would be very ugly to modify the return value of an function (what ISO
says about that?)
2) The increase would take place only after the value is used, i.e., the
parameter passed to set_multiplier_count() would be get_multiplier_count(). So
it would need to be ++get_multiplier_count()


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22273] Add action to the Unit UserData as a property and method

2014-07-30 Thread Jeffrey C. Jacobs 
Follow-up Comment #5, bug #22273 (project freeciv):

My fellow developers, I'm afraid I need your help again.  I am trying to add a
field for setting the unit's activity at the client level.  I have code that
checks a given activity value and then attempts to update the object.  As far
as I can tell when I invoke the write-only property my glue-code isn't called.
 Please see the attached diff for api_methods_unit_passive_activity, the glue
code which is to set the client-level activity.  Any help would be greatly
appreciated as I can't for the life of me see why this code isn't being called
with the following Lua script:

for v in find.player(0):units_iterate() do
v.set_state = 15
end:

This should make every one of the players units who isn't already fortified to
start fortifying if possible, otherwise it should raise an error because the
unit can't be made to fortify.

(file #21601)
___

Additional Item Attachment:

File name: rev3.diff  Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22330] civ2civ3 barbarian waste

2014-07-30 Thread Marko Lindqvist 
Update of bug #22330 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => cazfi  
 Planned Release: => 2.5.0, 2.6.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()

2014-07-30 Thread Marko Lindqvist 
Update of bug #22216 (project freeciv):

 Assigned to:   cazfi => pepeto 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-07-30 Thread Emmet Hikory 
Follow-up Comment #4, patch #4759 (project freeciv):

I like 2.99.99 : it makes the next step obvious to readers.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5003] Requirers dialog

2014-07-30 Thread Marko Lindqvist 
URL:
  

 Summary: Requirers dialog
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 31 Jul 2014 04:24:50 AM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

When one tries to remove a tech and that fails because other objects use that
tech, open dialog listing all the requirers.



___

File Attachments:


---
Date: Thu 31 Jul 2014 04:24:50 AM EEST  Name: RequirersList.patch  Size: 8kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev