[Freeciv-Dev] [bug #23218] Loopholes when disaster wrecks current production
Follow-up Comment #4, bug #23218 (project freeciv): Is this related to funny behavior I encountered in recent game: within one turn I bought production, enemy diplomat sabotaged it, I bought again, second enemy diplomat sabotaged it again. I don't think it's directly related. I suspect the fact that you could buy twice might have been caused by the definition city_can_change_build(), which as well as checking did_buy has an allowance for pcity-shield_stock = 0 (which I think it will be after sabotage). I don't know if that's what you were surprised by. Could also argue that bought production should be immune to sabotage, but that's quite a big gameplay change. Discussion of correct buy/sabotage interaction should probably go in a new ticket. I plan to commit this patch soon. ___ Reply to this item at: http://gna.org/bugs/?23218 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5763] civ2civ3: Tribal government gets martial law 2 per unit
Update of patch #5763 (project freeciv): Summary: Tribal government gets martial law 2 per unit = civ2civ3: Tribal government gets martial law 2 per unit ___ Reply to this item at: http://gna.org/patch/?5763 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #23, bug #21851 (project freeciv): I have tested the patch #5776 and I'm afraid it does not fix the memory leak. (S2_5 rev27747 with gtk-2 client) I found that the main trigger of the memory leak is actually to scroll down and up the list of items, even if the items are not really selected nor highlighted. I attach 2 screenshots where you can see the increase of memory usage by the Xorg process from 100 MB to 470 MB in a few seconds: -1st screen as reference, with the city dialog already opened. -2nd screen after I click the dropdown menu, and then I scroll up and down during some seconds. Those 400 MB are not freed until I close freeciv. (file #23699, file #23700) ___ Additional Item Attachment: File name: leak0.jpg Size:136 KB File name: leak1.jpg Size:133 KB ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23240] Governments help hardcodes fanatics
URL: http://gna.org/bugs/?23240 Summary: Governments help hardcodes fanatics Project: Freeciv Submitted by: jtn Submitted on: Mon 02 Feb 2015 23:19:59 UTC Category: docs Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Replace the hardcoded string Pays no upkeep for fanatics with a list of unit types with the Fanatic flag. ___ Reply to this item at: http://gna.org/bugs/?23240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23241] Help for Galleons claims they can attack
Update of bug #23241 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-attackless-non-native.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?23241 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5782] When capturing a unit, tell the victor its former nationality
Update of patch #5782 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-capture-nationality-msg.patch Size:0 KB File name: S2_5-S2_4-capture-nationality-msg.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?5782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5782] When capturing a unit, tell the victor its former nationality
URL: http://gna.org/patch/?5782 Summary: When capturing a unit, tell the victor its former nationality Project: Freeciv Submitted by: jtn Submitted on: Mon 02 Feb 2015 23:21:39 UTC Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Your Knights succeeded in capturing the Migrants. - Your Knights succeeded in capturing the English Migrants. ___ Reply to this item at: http://gna.org/patch/?5782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23241] Help for Galleons claims they can attack
URL: http://gna.org/bugs/?23241 Summary: Help for Galleons claims they can attack Project: Freeciv Submitted by: jtn Submitted on: Mon 02 Feb 2015 23:27:31 UTC Category: docs Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.5.0-beta2 Discussion Lock: Any Operating System: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Help for Galleons says things like * Belongs to Sea unit class. ... * Can attack units on non-native tiles. * Can launch attack from non-native tiles. despite Galleons being unable to attack anything. Fix Can attack units on non-native tiles by changing the definition of can_attack_non_native() to take into account attack strength. This is called in lots of places, but by inspection all the call sites test attack strength one way or another already, so I suspect it makes no difference to gameplay. If it does then the new behaviour is probably more correct. However, I haven't autogame-tested this patch. (Also fix UCF_ATT_FROM_NON_NATIVE straightforwardly in helpdata.c.) ___ Reply to this item at: http://gna.org/bugs/?23241 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23239] Improve paratrooper docs
URL: http://gna.org/bugs/?23239 Summary: Improve paratrooper docs Project: Freeciv Submitted by: jtn Submitted on: Mon 02 Feb 2015 23:17:48 UTC Category: rulesets Severity: 2 - Minor Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: There are various rules applying to Paratroopers which aren't explicitly stated anywhere that I've noticed. Update ruleset docs for rulesets with Paratroopers to add this information. (This also documents patch #3805 for branches which have that.) ___ Reply to this item at: http://gna.org/bugs/?23239 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23226] Threaded AI city worker task requests leak
Update of bug #23226 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23226 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23240] Governments help hardcodes fanatics
Update of bug #23240 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-help-gov-fanatics.patch Size:1 KB File name: S2_4-help-gov-fanatics.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?23240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23239] Improve paratrooper docs
Update of bug #23239 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-help-paratroopers.patch Size:3 KB File name: S2_4-help-paratroopers.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?23239 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5691] civ2civ3: help texts for governments
Follow-up Comment #3, patch #5691 (project freeciv): That's fine, I'll document it like that by hand in patch #4936. Just wanted to double-check that was your intention. ___ Reply to this item at: http://gna.org/patch/?5691 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Follow-up Comment #11, bug #23154 (project freeciv): Backported patch for bug #20705 attached. (file #23697) applied, tested, seems OK ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5760] [Qt client] Use widgets instead of hand-drawing the game info panel
Update of patch #5760 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23242] Bitwise settings do not get their value saved
URL: http://gna.org/bugs/?23242 Summary: Bitwise settings do not get their value saved Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Feb 2015 08:52:28 AM EET Category: freeciv-ruledit Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0, 3.0.0 ___ Details: Fix attached ___ File Attachments: --- Date: Tue 03 Feb 2015 08:52:28 AM EET Name: RuleditBitwiseSetting.patch Size: 668B By: cazfi http://gna.org/bugs/download.php?file_id=23709 ___ Reply to this item at: http://gna.org/bugs/?23242 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5762] [Qt client] Allow choosing a government by clicking the indicator
Update of patch #5762 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5762 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4486] Unit upkeep icons for upkeep 2 in amplio2
Update of patch #4486 (project freeciv): Status:None = Ready For Test Summary: Unit upkeep icons for upkeep 2 in supplied tilesets (amplio2) = Unit upkeep icons for upkeep 2 in amplio2 ___ Follow-up Comment #5: S2_5 setup (by GriffonSpade) from: http://forum.freeciv.org/f/viewtopic.php?f=12t=7start=74 (file #23708) ___ Additional Item Attachment: File name: Amplio2Upkeep-S2_5.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4486 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Update of bug #23154 (project freeciv): Status:None = Confirmed Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 = 2.4.5 ___ Follow-up Comment #8: Reproduced but only in S2_4 branches. The error occurs when the Legion takes over Shreshthapura, which is becoming outside of player vision. ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Follow-up Comment #9, bug #23154 (project freeciv): The circumstances looks like similar bug #20705. ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Update of bug #23154 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #10: Backported patch for bug #20705 attached. (file #23697) ___ Additional Item Attachment: File name: S2_4_transfer_city_reveal_hide_units.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
