Re: [Freeciv-Dev] (PR#39324) Bugs in SDL client for 2.1.0-beta4
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39324 On Thursday 12 April 2007 06:03:34 Christian Prochaska wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39324 [EMAIL PROTECTED] - Mi 04. Apr 2007, 21:34:31]: -The dialogue for selling all of a certain improvement isn't destroyed when an option is selected - The dialogue for buying a unit isn't destroyed when buying isn't allowed (due to a city being in disorder) until the city dialogue itself is closed Here's a patch for these two problems. Yeah, that seems to work okay. I played for about an hour and a half, and then my machine mysteriously ran out of memory and swap, and I didn't notice in time to be able to do anything more than reboot. I don't recall running any greedy apps, but I can't prove it's freeciv. Widget ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39340) 2.1.0-beta3 - connected islands
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39340 I found a solution for this last report http://rt.freeciv.org/Ticket/Display.html?id=17435 Rivers still need fixing in the island generator too http://rt.freeciv.org/Ticket/Display.html?id=15947 ~~Yautja On 4/14/07, Jason Short [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39340 Send us one or more rc files (particularly mapseed but also number of players) to reproduce it. Delving into the mapgen code is a very tricky business however. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39328) Reproducible Crash When Changing Tech Goal (2.1.0-b4 and SVN Head)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39328 The current code is clearly wrong. The va_arg may be implemented as a pointer rather than an inline array and so passing it multiple times to vsnprintf will generate garbage results on some platforms while working on others. Nothing I've read indicates that va_start can be called multiple times within the same function, though. If this is not guaranteed it is possible there is some platform that does not support it. The alternative is to use va_copy (a C99 add-on); however, since I notice we already use duplicate va_start calls elsewhere we might as well keep it like that for now. So I'm applying the patch as-is. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39330) Crash When Sharing Vision By Treaty (SVN Head)
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39330 This is a tough bug. Looks to me like this is at the heart of a deeper problem where shared vision does not correctly handle vision layers or seen_count. Perhaps someday it would be appropriate to go through and rewrite shared vision so that it physically shares all vision sources between targets rather than sharing tiles directly. For the immediate bug, the problem is that a player tile is being marked as known (in map_set_known most likely) but the terrain for that tile is not being set (remaining NULL). Offhand I cannot see how this can happen. really_give_tile_info_from_player_to_player is very suspicious however. Is there really no way to reproduce this? Best bet might be to add some more assertions in for now. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
