[Freeciv-Dev] You can't alter const objects?

2007-06-08 Thread James Supancic
In resource_name_translation, in terrain.c you are altering the value of a const parameter. This is not allowed, and gcc 4.1 tells us this with: terrain.c: In function 'resource_name_translation': terrain.c:244: error: assignment of read-only location I'm not sure how this should be fixed? Maybe

Re: [Freeciv-Dev] (PR#39385) suggestion: Buy column on Cities report preliminary patch

2007-06-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 I don't understand your changes to the first functions, but I have some comments on the other changes. I did this with the field width wrong as well, but I think we should reserve a width up to 5 for build costs. I can imagine wonders

Re: [Freeciv-Dev] (PR#39385) Preliminary patch

2007-06-08 Thread Lars Huttar
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 On 6/7/2007 8:11 AM, Ulrik Sverdrup wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Here is a preliminary patch. I don't know the code around this, but it seems to be well designed, so this should be all there is to

Re: [Freeciv-Dev] (PR#39383) BUG: terrain and resource name translation

2007-06-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39383 William Allen Simpson wrote: There's a warning, because the current resource list is const, and this modifies the pointer. Updating the const can happen later. trunk revision 12977 S2_1 revision 12978 Remaining const struct

Re: [Freeciv-Dev] (PR#39385) RFE: Buy column on Cities report

2007-06-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Ulrik Sverdrup wrote: I did this with the field width wrong as well, but I think we should reserve a width up to 5 for build costs. I can imagine wonders costing more than 1 if you buy them from scratch in the derfault ruleset.