[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 [wsimpson - Jeu. Oct. 11 23:03:37 2007]: Committed S2_1 revision 13744. Committed S2_2 revision 13745. You forgot to change the main mandatory capability. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39770) [Bug] Timeout doesn't change correctly
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39770
When you use the command /set timeout 60 while the game is running, the
timeout change only the next turn. The problem is that
game.info.seconds_to_phasedone doesn't change when game.info.timeout is
changed.
A callback like:
/*
Change timeout...
*/
static bool timeout_callback(int new_timeout, const char **error_string)
{
error_string = NULL;
game.info.seconds_to_phasedone += new_timeout - game.info.timeout;
send_game_info(NULL);
return TRUE;
}
is missing. But there is an other problem, votes for '/set' are still
buggy (I made a ticket some months ago, rejected). This callback would
be call when the vote will be checked. So, the timeout will change
virtually.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 You forgot to change the main mandatory capability. In 2.1, I'm expecting that to change with a new (+2.1g) release tomorrow. Since there's no possibility of backward compatibility, both ReportFreezeFix and CF can go away, too. In 2.2, I thought +test was added after discussion, but I see that nobody actually did it There's no expectation that different source development versions will interoperate. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
On 10/12/07, William Allen Simpson [EMAIL PROTECTED] wrote: Daniel Markstedt wrote: Let's wait 24h before tagging, to let some final fixes go in. Between now and final, docs need some attention too. Especially translated docs. Ok, cool. How long after the tag is the final release? 7 days? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev Looking at the news archive: between 2.0.0-RC1 and 2.0.0-RC2: 13 days. Then to 2.0.0-final another 3. Anyway, a week sounds reasonable if nothing unexpected happens. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
Daniel Markstedt wrote: Let's wait 24h before tagging, to let some final fixes go in. Between now and final, docs need some attention too. Especially translated docs. Ok, cool. How long after the tag is the final release? 7 days? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39614) client connection list in start page
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 S2_1, S2_2 and trunk would need the 3 patch. S2_0 will need an adaptation of the second one. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39614) client connection list in start page
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614
Third step: client connection list side.
+ /cmdlevel and /cut send the username to the server, not the player
name which can be different.
+ the /cmdlevel ctrl menu item really makes it, no /cut.
Patch attached
Index: client/gui-gtk-2.0/pages.c
===
--- client/gui-gtk-2.0/pages.c (révision 13752)
+++ client/gui-gtk-2.0/pages.c (copie de travail)
@@ -1072,7 +1072,7 @@
/
Miscellaneous callback for the conn menu that allows an arbitrary command
- (/observe, /take, /hard) to be run on the player.
+ (/observe, /remove, /hard) to be run on the player.
/
static void conn_menu_player_command(GtkMenuItem *menuitem, gpointer data)
{
@@ -1104,6 +1104,23 @@
send_chat(buf);
}
+/
+ Miscellaneous callback for the conn menu that allows an arbitrary command
+ (/cmdlevel, /cut) to be run on the connection.
+/
+static void conn_menu_connection_command(GtkMenuItem *menuitem, gpointer data)
+{
+ char buf[1024];
+ const char *command = data;
+
+ assert(conn_menu_conn != NULL);
+ assert(command != NULL);
+
+ my_snprintf(buf, sizeof(buf), /%s \%s\,
+ command, conn_menu_conn-username);
+ send_chat(buf);
+}
+
/**
Show details about a user in the Connected Users dialog in a popup.
**/
@@ -1213,7 +1230,7 @@
(GtkDestroyNotify) gtk_widget_unref);
gtk_container_add(GTK_CONTAINER(menu), entry);
g_signal_connect(GTK_OBJECT(entry), activate,
- GTK_SIGNAL_FUNC(conn_menu_player_command), cut);
+ GTK_SIGNAL_FUNC(conn_menu_connection_command), cut);
}
}
@@ -1243,7 +1260,7 @@
(GtkDestroyNotify) gtk_widget_unref);
gtk_container_add(GTK_CONTAINER(menu), entry);
g_signal_connect(GTK_OBJECT(entry), activate,
- GTK_SIGNAL_FUNC(conn_menu_player_command),
+ GTK_SIGNAL_FUNC(conn_menu_connection_command),
cmdlevel info);
entry = gtk_menu_item_new_with_label(_(Give ctrl access));
@@ -1251,7 +1268,8 @@
(GtkDestroyNotify) gtk_widget_unref);
gtk_container_add(GTK_CONTAINER(menu), entry);
g_signal_connect(GTK_OBJECT(entry), activate,
- GTK_SIGNAL_FUNC(conn_menu_player_command), cut);
+ GTK_SIGNAL_FUNC(conn_menu_connection_command),
+ cmdlevel ctrl);
/* No entry for hack access; that would be a serious security hole. */
}
@@ -2467,4 +2485,3 @@
g_list_free(opts);
}
-
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39771) Freeciv .desktop files
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39771 Good daytime! As I said early, current freeciv.desktop is not proper. Attached are freeciv-server.desktop.in and patch to freeciv.desktop.in (and configure/Makefile.) Changed categories, removed version, removed extension of icons (allow to use not .png only.) IMHO, ready to commit. And i want it to be commited before 2.1.0 release. -- Thanks, evyscr freeciv-server.desktop.in Description: Binary data s2_1-desktops.diff Description: Binary data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
On 10/12/07, William Allen Simpson [EMAIL PROTECTED] wrote: I'm not sure how to tag the release (do I have to checkout 1 level above the branches?) -- Daniel can do that -- but version.in has been set. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev I follow Jason's steps at http://freeciv.wikia.com/wiki/Release Let's wait 24h before tagging, to let some final fixes go in. Between now and final, docs need some attention too. Especially translated docs. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#10284) [Request] Docs: distribute FAQ into freeciv/docs/
URL: http://bugs.freeciv.org/Ticket/Display.html?id=10284 On Fri, 28 Sep 2007 00:55:40 -0700 Daniel Markstedt wrote: [evyscr - Mon Jan 23 17:17:10 2006]: [evyscr - Sep 23 20:12:58 2004]: It would be nice to see FAQ file in freeciv distribution, wouldn't it? New version. * uses lynx instead of links * writes numbers at answers Generated text also available at http://evyscr.murom.net/freeciv/my/scripts/FAQ Opinions/suggestions? PS I'm not a perl coder, so if^Wwhen you see errors/stupidity/etc, please, give a right variant too :) Looks good to me! New version of script and generated FAQ file are attached (corrected script due to layout changes.) Actually, I'd prefer if most of the documents in doc/ were generated from wiki pages. It would be far more convenient to maintain all documentation in wiki and then generate plaintext versions to be distributed right before a release is made. With proper layout it wouldn't be too hard to made similar scripts for all of this pages. -- Thanks, evyscr fcgetfaq.pl Description: Binary data FAQ.gz Description: GNU Zip compressed data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
On 10/12/07, William Allen Simpson [EMAIL PROTECTED] wrote: Assuming we're following the usual commercial release criterion, problems that would stop the cycle now would be: 1) reproducible crashing bugs, 2) that aren't already in previous 2.0.x releases. Anything else waits until the next release (2.1.x or 2.2.0). I'm presuming that we still want translations? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev Sounds like reasonable guidelines. Updates to po's are always welcome, regardless of branch or state. Unless they break compilation of course, so we'd better check after each commit. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
Assuming we're following the usual commercial release criterion, problems that would stop the cycle now would be: 1) reproducible crashing bugs, 2) that aren't already in previous 2.0.x releases. Anything else waits until the next release (2.1.x or 2.2.0). I'm presuming that we still want translations? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39769) opendesktop icons
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39769 On Thu, 11 Oct 2007 14:44:07 -0700 Daniel Markstedt wrote: From: Egor Vyscrebentsov evyscr Date: Oct 12, 2007 1:05 AM Subject: Re: [Freeciv-Dev] Freeciv Icons To: freeciv-dev@gna.org On Thu, 11 Oct 2007 07:51:52 +0900 Daniel Markstedt wrote: Hi Egor, Since I really want you to resolve that opendesktop profile thing, I prepared an icon pack for ya. Sizes are 16,32,48,64,128 px set for client and server. Attached are: 1) data/icons subdirectory 2) patch for configure.ac/Makefile.am icons/Makefile.am is based on gnome-games/icons Makefile adapted to our server/client separation. TODO (not sure this is really needed): add .svg to $datadir/icons/hicolor/scalable/apps I am going to commit this in 24 hours if there will be no protests. -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39614) client connection list in start page
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614
Second step: notify to the clients all changes about connections:
+ new created players names when a client joins.
+ lost detached connections.
+ when a player get detached after a /remove usage.
+ when a game is loaded with /load, notify all changes. Don't change the
page if there are many connected users: the chat is removed, then the
people cannot communicate or type commands.
Patch attached
Index: server/connecthand.c
===
--- server/connecthand.c (révision 13752)
+++ server/connecthand.c (copie de travail)
@@ -136,8 +136,6 @@
notify_conn(dest, NULL, E_CONNECTION,
_(Couldn't attach your connection to new player.));
freelog(LOG_VERBOSE, %s is not attached to a player, pconn-username);
-} else {
- sz_strlcpy(pconn-player-name, pconn-username);
}
}
@@ -428,6 +426,7 @@
pplayer = game.players[game.info.nplayers];
server_player_init(pplayer, FALSE, TRUE);
game.info.nplayers++;
+ sz_strlcpy(pplayer-name, pconn-username);
}
}
Index: server/sernet.c
===
--- server/sernet.c (révision 13752)
+++ server/sernet.c (copie de travail)
@@ -211,6 +211,8 @@
pconn-player = NULL;
pconn-access_level = ALLOW_NONE;
connection_common_close(pconn);
+
+ send_conn_info(pconn-self, game.est_connections);
}
/*
Index: server/stdinhand.c
===
--- server/stdinhand.c (révision 13752)
+++ server/stdinhand.c (copie de travail)
@@ -3266,6 +3266,15 @@
return TRUE;
}
+ /* Detach all connection to prevent client crashes. */
+ conn_list_iterate(game.est_connections, pconn) {
+if (pconn-player) {
+ unattach_connection_from_player(pconn);
+}
+ } conn_list_iterate_end;
+ send_conn_info(game.est_connections, game.est_connections);
+ send_player_info(NULL, NULL);
+
/* we found it, free all structures */
server_game_free();
@@ -3290,16 +3299,17 @@
send_game_info(game.est_connections);
send_rulesets(game.est_connections);
- /* Everything seemed to load ok; spread the good news. */
- send_load_game_info(TRUE);
+ /* send_load_game_info() don't work well for multi-players games. */
+ if (conn_list_size(game.all_connections) == 1) {
+send_load_game_info(TRUE);
+ } else {
+send_player_info(NULL, NULL);
+ }
/* attach connections to players. currently, this applies only
* to connections that have the correct username. Any attachments
* made before the game load are unattached. */
conn_list_iterate(game.est_connections, pconn) {
-if (pconn-player) {
- unattach_connection_from_player(pconn);
-}
players_iterate(pplayer) {
if (strcmp(pconn-username, pplayer-username) == 0) {
attach_connection_to_player(pconn, pplayer);
@@ -3307,6 +3316,8 @@
}
} players_iterate_end;
} conn_list_iterate_end;
+ send_conn_info(game.est_connections, game.est_connections);
+
return TRUE;
}
Index: server/plrhand.c
===
--- server/plrhand.c (révision 13752)
+++ server/plrhand.c (copie de travail)
@@ -1127,6 +1127,7 @@
if (!unattach_connection_from_player(pconn)) {
die(player had a connection attached that didn't belong to it!);
}
+send_conn_info(pconn-self, game.est_connections);
} conn_list_iterate_end;
team_remove_player(pplayer);
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
William Allen Simpson wrote: 1) reproducible crashing bugs, PR#39602, 39615. 2) that aren't already in previous 2.0.x releases. PR#20772, 39697, 39613, 39744. And other incomplete features... Is it enough to have at least a week before release? _ Retrouvez Windows Live Messenger sur votre mobile ! http://www.messengersurvotremobile.com___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
Pepeto _ You seem to have interpreted these 2 criteria as /or/, but the usual English interpretation of *and* applies: both criteria must be met to delay the release. Bugs in 2.0 are *especially* not applicable. They are known and didn't affect the current/previous release cycle. If they are have not been fixed in 3 years, they are not critical bugs! I have reviewed your list, and none of them are reproducible crashes that prevent the game from being played. Please concentrate your efforts over the next few days on the vigorous effort to ensure the quick release of 2.1. In particular, there are 50 missing translations in fr.po? And 95 fuzzy translations? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.1.0-rc1 version set
On 10/13/07, William Allen Simpson [EMAIL PROTECTED] wrote: Pepeto _ You seem to have interpreted these 2 criteria as /or/, but the usual English interpretation of *and* applies: both criteria must be met to delay the release. Bugs in 2.0 are *especially* not applicable. They are known and didn't affect the current/previous release cycle. If they are have not been fixed in 3 years, they are not critical bugs! I have reviewed your list, and none of them are reproducible crashes that prevent the game from being played. Please concentrate your efforts over the next few days on the vigorous effort to ensure the quick release of 2.1. In particular, there are 50 missing translations in fr.po? And 95 fuzzy translations? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev There's also the translated docs in fr/ -- I haven't seen Rodrigo around for ages, so you might be the only French speaker around ATM, pepeto. As for your bugs, let's aim to have those fixed by 2.1.1! ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
