Re: [Freeciv-Dev] Gna email problems
2009/7/4 cazfi wrote: It seems that commit messages are not being sent to freeciv-commits. Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv - ML I already experienced this problem when I started to work in warclient. It is actually due to the sebnding rights. I think Book is not allowed to send e-mails to the commit mailing list. An administrator should fix that. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13865] iterator.h doesn't include the definition of type 'bool'
URL: http://gna.org/bugs/?13865 Summary: iterator.h doesn't include the definition of type 'bool' Project: Freeciv Submitted by: pepeto Submitted on: Sunday 07/05/2009 at 07:22 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: If you want to include the iterator.h header in a code file, you cannot apply what the coding style requires. You are supposed to include the files by alphabetic order, and iterator.h use the non-standard C type bool which is defined in shared.h. So you have to include shared.h before iterator.h to compile the code. Should it be possible to include shared.h in iterator.h to fix that problem? ___ Reply to this item at: http://gna.org/bugs/?13865 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40841) Bug: Corrupted city name crashes Freeciv
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40841 Dear people, I'm playing Freeciv-2.1.9-win32-gtk2 on Windows XP. I'm playing the Catalans on normal difficulty - it's now 1140 AD. The last few sessions, when I build a new city, the name that comes up first is Perpiny - with an X in a box immediately after it. Originally I don't think it had the X behind it, I could cancel a few times and eventually another name would come up. Once I said OK to Perpiny and it opened a city window with no city name - so I went back to the last save file. Now, no matter how many times I cancel, all that comes up is PerpinyX. I can delete the text in Perpiny, and I can highlight the X by dragging over it, but I can't delete or cut it. If I accept it, Freeciv crashes. Rebooting, and uninstalling and reinstalling Freeciv don't help. I suppose that means that that particular game file is corrupted, but I'm really attached to my little Catalan Republic - it's the best Freeciv game I've played yet. I would really like a way to fix it. In terms of what it says on your bug reporting page about asking me more questions, and having me compile the error log or whatever, *good luck!* I have a right brain injury which causes me to be chronically anxious, overwhelmed, and fatigued. I hate using email because of the lack of immediate feedback, and I respond to it, if I do at all, very slowly. I far prefer the phone. If someone wants to call me, you can sometimes reach me (or leave me voicemail) at 303-442-3663 (I'm up every two days, I turn off my ringer when I'm asleep, and I'm at my girlfriend's place a lot). As to me compiling the error log or whatever, I think that's beyond me at this point. I had a couple of jobs doing tech support, but that was ten years ago ago, and I was always low-level. That strikes me as programmer stuff, and I'm not a programmer. Also, I don't have a computer. All this is happening on my girlfriend's computer, so I don't have the ability to take as much time as I need to figure it out. I'm sorry I'm not much help - I just don't have the energy to be a fully participating member of an online community. I do really appreciate all the work you guys have put into Freeciv. It's a wonderful option for me right now. I don't want to buy Civilization IV for Windows because I'm going to buy another Mac. Thank you, Paul Angel 303-442-3663 -- Be kind, for everyone is fighting a hard battle. - Philo Dear people, Im playing Freeciv-2.1.9-win32-gtk2 on Windows XP. Im playing the Catalans on normal difficulty - its now 1140 AD. The last few sessions, when I build a new city, the name that comes up first is Perpiny - with an X in a box immediately after it. Originally I dont think it had the X behind it, I could cancel a few times and eventually another name would come up. Once I said OK to Perpiny and it opened a city window with no city name - so I went back to the last save file. Now, no matter how many times I cancel, all that comes up is PerpinyX. I can delete the text in Perpiny, and I can highlight the X by dragging over it, but I cant delete or cut it. If I accept it, Freeciv crashes. Rebooting, and uninstalling and reinstalling Freeciv dont help. I suppose that means that that particular game file is corrupted, but Im really attached to my little Catalan Republic - its the best Freeciv game Ive played yet. I would really like a way to fix it. In terms of what it says on your bug reporting page about asking me more questions, and having me compile the error log or whatever, good luck! I have a right brain injury which causes me to be chronically anxious, overwhelmed, and fatigued. I hate using email because of the lack of immediate feedback, and I respond to it, if I do at all, very slowly. I far prefer the phone. If someone wants to call me, you can sometimes reach me (or leave me voicemail) at 303-442-3663 (Im up every two days, I turn off my ringer when Im asleep, and Im at my girlfriends place a lot). As to me compiling the error log or whatever, I think thats beyond me at this point. I had a couple of jobs doing tech support, but that was ten years ago ago, and I was always low-level. That strikes me as programmer stuff, and Im not a programmer. Also, I dont have a computer. All this is happening on my girlfriends computer, so I dont have the ability to take as much time as I need to figure it out. Im sorry Im not much help - I just dont have the energy to be a fully participating member of an online community. I do really appreciate all the work you guys have put into Freeciv. Its a wonderful option for me right now. I dont want to buy Civilization IV for Windows because Im going to buy another Mac. Thank you, Paul Angel 303-442-3663 -- Be kind, for everyone is fighting a hard battle. - Philo ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines
While on the topic of asserts, I recommend using a macro similar to the ASSERT_OR_RETURN that I wrote for Warzone2100 -- http://warzone2100.svn.sourceforge.net/viewvc/warzone2100/trunk/lib/framework/debug.h?revision=7821view=markup The reason for this is that 1) you avoid having to do such double evaluations, and 2) you quickly get into the (addictive) habit of writing defensive code that fails softly for non-debug builds. Also a more descriptive ASSERT() macro with comments (see above link) helps when debugging. Feel free to copy paste this code ;) - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Tracking changes to translatable strings
We are nearing S2_2 branching point and first beta in a couple of months. This means also that new and changes translatable strings should be made available to translators faster. I have run update-po for translations every couple of months, but now, until S2_2 branching, I would want to run update-po soon after when ever there is change to translatable strings. When posting new patches, could you please mention if they contain changes to translatable strings so I would know to run update-po. Thanks. Updated po-files resulting from my update-po runs are placed to http://www.cazfi.net/freeciv/translations/ - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #6, bug #13846 (project freeciv): updated patch changes: - max 10 calls to read - check is possible for the read command (used for voting?) (file #6132) ___ Additional Item Attachment: File name: gna13846-recursion-checking-for-the-read-command.patch Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Update of bug #13843 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13841] [Patch] Worklist clean up
Follow-up Comment #1, bug #13841 (project freeciv): Please try to split your patches to smaller separate tickets which each do just one thing. That way it's much easier to confirm them. ___ Reply to this item at: http://gna.org/bugs/?13841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions
URL:
http://gna.org/bugs/?13867
Summary: [patch 01/07] get game settings via wrapper
functions
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 05.07.2009 um 22:15
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release:
Operating System: None
___
Details:
get game settings via wrapper functions
* cleanup naming:
- definition: struct setting {};
- data: struct setting settings[];
- pointer: struct setting *pset;
- functions: setting_*()
* remove 'extern' flag from settings
* define (and use) iterating macro for settings
Using '_()' within the setting_*() functions is not
done because the some callers need the untranslated
string (see stdinhand.c:send_server_setting()).
This patch serie includes the following patches:
[patch 01/07] get game settings via wrapper functions
[patch 02/07] use an union in the struct setting
[patch 03/07] simplify validation functions
[patch 04/07] extra functions to check and update settings
[patch 05/07] add settting action callback function
[patch 06/07] move sset_is_to_client() to settings.c
[patch 07/07] load game settings from ruleset file
It supersedes gna13621, gna13805, gna13810
Each step results in a working freeciv version if all
previous patches are applied.
___
File Attachments:
---
Date: Sonntag 05.07.2009 um 22:15 Name:
01-get-game-settings-via-wrapper-functions.patch Size: 39kB By: syntron
http://gna.org/bugs/download.php?file_id=6135
___
Reply to this item at:
http://gna.org/bugs/?13867
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13868] [patch 02/07] use an union in the struct setting
URL: http://gna.org/bugs/?13868 Summary: [patch 02/07] use an union in the struct setting Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:15 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: use an union in the struct setting * change the wrapper functions * protect the union by asserts Are the asserts needed or can we trust all callers? ___ File Attachments: --- Date: Sonntag 05.07.2009 um 22:15 Name: 02-use-an-union-in-the-struct-setting.patch Size: 11kB By: syntron http://gna.org/bugs/download.php?file_id=6136 ___ Reply to this item at: http://gna.org/bugs/?13868 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions
URL: http://gna.org/bugs/?13869 Summary: [patch 03/07] simplify validation functions Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:16 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: simplify validation functions * only one function is used * it will also be used for the action callbacks (patch05) ___ File Attachments: --- Date: Sonntag 05.07.2009 um 22:16 Name: 03-simplify-validation-functions.patch Size: 20kB By: syntron http://gna.org/bugs/download.php?file_id=6137 ___ Reply to this item at: http://gna.org/bugs/?13869 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13870] [patch 04/07] extra functions to check and update settings
URL: http://gna.org/bugs/?13870 Summary: [patch 04/07] extra functions to check and update settings Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:17 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: extra functions to check and update settings * create the functions - setting_check() - setting_update() * cleanup of set_command() ___ File Attachments: --- Date: Sonntag 05.07.2009 um 22:17 Name: 04-extra-functions-to-check-and-update-settings.patch Size: 22kB By: syntron http://gna.org/bugs/download.php?file_id=6138 ___ Reply to this item at: http://gna.org/bugs/?13870 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13850] add min/max definitions for saveturns
Update of bug #13850 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13850 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Update of bug #13846 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13841] [Patch] Worklist clean up
Follow-up Comment #2, bug #13841 (project freeciv): I'm not sure I could make separated patches for those changes because all of them are linked. ___ Reply to this item at: http://gna.org/bugs/?13841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13841] [Patch] Worklist clean up
Follow-up Comment #3, bug #13841 (project freeciv): I try to make more detailed splitting proposal when I have time to look this patch in more detail (or maybe I'll end admitting that it's not splittable :-) Anyway, obvious first patch would be init_worklist() - worklist_init(), copy_worklist() - worklist_copy() rename. ___ Reply to this item at: http://gna.org/bugs/?13841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13863] Remove old server goto code, step 1: warmap alternatives
Follow-up Comment #1, bug #13863 (project freeciv): There is a minor change in the pf code itself. I noticed that the node could be initialized many times if the first time, the node was considered unreachable. I added a new node status NS_INIT which just marks to don't initialize the node a second time (because it's only a waste of time). Can this be separated to separate ticket (of which this ticket would depend)? Would it make sense to commit it to S2_1 also? ___ Reply to this item at: http://gna.org/bugs/?13863 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13872] [patch 06/07] move sset_is_to_client() to settings.c
URL: http://gna.org/bugs/?13872 Summary: [patch 06/07] move sset_is_to_client() to settings.c Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:19 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: move sset_is_to_client() to settings.c remove 'static' flag * is needed in ruleset.c ___ File Attachments: --- Date: Sonntag 05.07.2009 um 22:19 Name: 06-move-sset_is_to_client-to-settings.c.patch Size: 2kB By: syntron http://gna.org/bugs/download.php?file_id=6140 ___ Reply to this item at: http://gna.org/bugs/?13872 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13873] [patch 07/07] load game settings from ruleset file
URL: http://gna.org/bugs/?13873 Summary: [patch 07/07] load game settings from ruleset file Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 22:21 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: load game settings from ruleset file * small correction for setting_check() * further simplification possible? ___ File Attachments: --- Date: Sonntag 05.07.2009 um 22:21 Name: 07-load-game-settings-from-ruleset-file.patch Size: 7kB By: syntron http://gna.org/bugs/download.php?file_id=6141 ___ Reply to this item at: http://gna.org/bugs/?13873 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13875] change O_MAX and O_COUNT to O_LAST
URL: http://gna.org/bugs/?13875 Summary: change O_MAX and O_COUNT to O_LAST Project: Freeciv Submitted by: syntron Submitted on: Sonntag 05.07.2009 um 23:06 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: change O_MAX and O_COUNT to O_LAST * if the O_LAST is loaded from the ruleset a lot of changes have to be coded; so stay at the moment with only one variable O_LAST for consistency ___ File Attachments: --- Date: Sonntag 05.07.2009 um 23:06 Name: 0001-change-O_MAX-and-O_COUNT-to-O_LAST.patch Size: 34kB By: syntron http://gna.org/bugs/download.php?file_id=6142 ___ Reply to this item at: http://gna.org/bugs/?13875 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13875] change O_MAX and O_COUNT to O_LAST
Update of bug #13875 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13875 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Follow-up Comment #1, bug #13843 (project freeciv): I'm sorry I'm posting after this bug is closed, but it's of interest to me. I'm in the middle of redoing a menu layout change that I originally submitted about a year ago. Would you be able to go into a bit more depth about why this path moves items into a submenu? I don't quite understand the context (I'm way behind on list reading, so please point me to the appropriate thread if there was a discussion). Also, these seem to make the two old entries redundant, but they remain in the orders menu (Build Airbase and Fortify/Build Fortress). ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
