[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Assigned to: pepeto = englabenny ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15862] in copy_chars_to_string16() [gui_string.c::196]: assertion 'pString != ((void *)0)' failed
Update of bug #15862 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15862 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15866] genlist_remove() may cause memory corruption
Update of bug #15866 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15866 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15869] Missing info labels for option dialog buttons
Update of bug #15869 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15869 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15870] Experimental ruleset fails to install
Update of bug #15870 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15870 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
Update of bug #15738 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1632] Implement color option type
URL: http://gna.org/patch/?1632 Summary: Implement color option type Project: Freeciv Submitted by: pepeto Submitted on: jeudi 15.04.2010 à 08:27 Category: client-xaw Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ Reply to this item at: http://gna.org/patch/?1632 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1624] Server setting packet definitions
Follow-up Comment #1, patch #1624 (project freeciv): Updating against current trunk. (file #8976) ___ Additional Item Attachment: File name: trunk_server_setting_packets2.diff.bz2 Size:9 KB ___ Reply to this item at: http://gna.org/patch/?1624 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1633] Add 'enum' option type
URL: http://gna.org/patch/?1633 Summary: Add 'enum' option type Project: Freeciv Submitted by: pepeto Submitted on: jeudi 15.04.2010 à 08:31 Category: client Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ...an integer option, rendered with string. ___ Reply to this item at: http://gna.org/patch/?1633 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1634] Implement 'enum' option type
URL: http://gna.org/patch/?1634 Summary: Implement 'enum' option type Project: Freeciv Submitted by: pepeto Submitted on: jeudi 15.04.2010 à 08:32 Category: client-gtk-2.0 Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ Reply to this item at: http://gna.org/patch/?1634 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1635] Implement 'enum' option type
URL: http://gna.org/patch/?1635 Summary: Implement 'enum' option type Project: Freeciv Submitted by: pepeto Submitted on: jeudi 15.04.2010 à 08:33 Category: client-sdl Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ Reply to this item at: http://gna.org/patch/?1635 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1634] Implement 'enum' option type
Update of patch #1634 (project freeciv): Depends on: = patch #1633 ___ Reply to this item at: http://gna.org/patch/?1634 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1635] Implement 'enum' option type
Update of patch #1635 (project freeciv): Depends on: = patch #1633 ___ Reply to this item at: http://gna.org/patch/?1635 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1637] Implement 'enum' server setting type
URL: http://gna.org/patch/?1637 Summary: Implement 'enum' server setting type Project: Freeciv Submitted by: pepeto Submitted on: jeudi 15.04.2010 à 08:35 Category: None Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: In server side, for settings like topology, borders, etc... ___ Reply to this item at: http://gna.org/patch/?1637 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1301] [Metaticket] settings patch series
Update of patch #1301 (project freeciv): Depends on: = patch #1631 ___ Reply to this item at: http://gna.org/patch/?1301 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15884] Use AM_SILENT_RULES for easier to read build output
URL: http://gna.org/bugs/?15884 Summary: Use AM_SILENT_RULES for easier to read build output Project: Freeciv Submitted by: englabenny Submitted on: torsdag 2010-04-15 den 11:07 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: englabenny Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: We can optionally enable an automake 1.11 feature called AM_SILENT_RULES. * The build output is much sparser (one line per compiled file), and it should be easier to see warnings or errors. * You can have full build output using 'make V=1' Example: make[4]: Entering directory `/home/ulrik/pt/src/freeciv/freeciv.git/common' CC ai.lo CC base.lo CC borders.lo CC capstr.lo CC city.lo city.c:49: warning: ‘citylog_map_index’ declared ‘static’ but never defined city.c:50: warning: ‘citylog_map_radius_sq’ declared ‘static’ but never defined CC combat.lo CC connection.lo CC dataio.lo CC diptreaty.lo CC effects.lo CC events.lo CC featured_text.lo CC game.lo CC government.lo Patch for trunk attached. It can also be made available, but not default if the [yes] is removed in the patch. It can then be enabled at configure time or with 'make V=0'. If automake older than 1.11 is used, this declaration is ignored and everything works as before. ___ File Attachments: --- Date: torsdag 2010-04-15 den 11:07 Name: 2010041501-Enable-AM_SILENT_RULES-by-default-where-availa.patch Size: 761 B By: englabenny http://gna.org/bugs/download.php?file_id=8977 ___ Reply to this item at: http://gna.org/bugs/?15884 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15884] Use AM_SILENT_RULES for easier to read build output
Update of bug #15884 (project freeciv): Category:None = bootstrap ___ Reply to this item at: http://gna.org/bugs/?15884 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Priority: 1 - Later = 5 - Normal Status: In Progress = Ready For Test ___ Follow-up Comment #6: Updated patches: 2.2: Minimal changes to accomplish this. No other changes riding in on that. trunk: Use a general solution in declarative style, it should be obvious how more properties can be added by just adding more methods inside a type's 'properties' subtable. (file #8978, file #8979) ___ Additional Item Attachment: File name: 2010041501-API-Restore-Player.id-field-using-properties.patch Size:4 KB File name: 2010041501-S2_2-API-Restore-Player.id-field-using-properties.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1582] UTF-8 utilities
Update of patch #1582 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #7: New version attached thanks to the comments. UTF-8 doesn't use longer characters than 4-byte sequences. Freeciv shouldn't output anything outside of that (accepting it is ok I guess, but where would it come from?) I set a variant for 6 bytes characters in a #ifdef block. Many of the functions are just there to make sure we do truncation in a nice way. IMO, truncation is the bad thing we are doing, it's not how we are doing it. We don't need this, if we stop truncating. However, a function to do truncation specifically when needed might be useful. We don't always want truncation when a string is not valid. Consider a string beginning with an Ö character in latin-1 encoding. With this code, it would be truncated to a zero-length string. Often where illegal encodings are used, replacement chars are inserted instead. Would it be better to render it ?text continues than just ? (We could use U+FFFD REPLACEMENT CHARACTER). The latter use is much better when we deal with illegal encodings/wrongly encoded text. The former much better when fixing up truncation (so same thing again). I added many fc_utf8_*_rep() functions to use the replacement character instead of truncate the strings. two typos: uft8_char, fc_ut8_next_char Didn't find. Where is it? Each function provided should do everything that it needs to. Specifically, fc_utf8_char_size is not a useful function in its current form (except for internal usage). Removed. Are we sure that using these variants everywhere is easier than converting all freeciv to wide characters? I think it's really easier to use those functions instead of converting the whole Freeciv codebase using wide characters because the usage of those functions can be really local. We need them only for input checks (files and packets). (file #8980) ___ Additional Item Attachment: File name: trunk_utf8_utilities3.diff Size:32 KB ___ Reply to this item at: http://gna.org/patch/?1582 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1582] UTF-8 utilities
Follow-up Comment #8, patch #1582 (project freeciv): Attached version 4: * Add a new module utility/fc_utf8.[ch]. * Fix the typos reported by Ulrik. * Generalize the usage of the suffixes: *_trunc(), *_rep(), *_len() and *_dup(). (file #8981) ___ Additional Item Attachment: File name: trunk_utf8_utilities4.diff Size:37 KB ___ Reply to this item at: http://gna.org/patch/?1582 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15858] Game crashes on startup
Follow-up Comment #2, bug #15858 (project freeciv): same bug as 15591? ___ Reply to this item at: http://gna.org/bugs/?15858 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities
Update of patch #1617 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1617 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1555] Scripting: Allow saving tables to script state
Update of patch #1555 (project freeciv): Status:None = Postponed ___ Reply to this item at: http://gna.org/patch/?1555 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15591] [10.5.8 PPC Mac] client doesn't start
Follow-up Comment #8, bug #15591 (project freeciv): See also bug #15858. ___ Reply to this item at: http://gna.org/bugs/?15591 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15858] Game crashes on startup
Follow-up Comment #4, bug #15858 (project freeciv): Same bug as #15591 ? To make a link, you have to precede the number directly by the word bug, patch or anything else, like bug #15591. It seems effectively a very similar. However, I don't have any knowledge on this. Do someone is able to help for the Mac OS issues? ___ Reply to this item at: http://gna.org/bugs/?15858 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15873] Experimental ruleset still claims to be default
Update of bug #15873 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15873 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15630] Don't allow leaving cities in the ocean (Cities in the ocean crash)
Update of bug #15630 (project freeciv): Category: editor = general Priority: 1 - Later = 5 - Normal Status:None = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #5: I followed the path to check how the terrain is changed. I found ways to modify the terrain of a city to a TER_NO_CITIES terrain: * From the editor. * From irrigating. * From mining. Last two points doesn't occur with default rulesets. Fixes attached. If I missed a point somewhere, I also added an error message (and an assertion in trunk) in tile_set_terrain(). (file #8982, file #8983) ___ Additional Item Attachment: File name: trunk_TER_NO_CITIES.diff Size:2 KB File name: S2_2_TER_NO_CITIES.diffSize:2 KB ___ Reply to this item at: http://gna.org/bugs/?15630 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15446] airbase not working on swamp?
Update of bug #15446 (project freeciv): Status: Fixed = Ready For Test Open/Closed: Closed = Open Planned Release: 2.2.1 = 2.2.1, 2.3.0 ___ Follow-up Comment #6: I missed some points there. ai_calc_irrigate() and ai_calc_mine() are also able to remove illegally the bases. Fix attached. (file #8984, file #8985) ___ Additional Item Attachment: File name: trunk_strange_base_removal.diff Size:2 KB File name: S2_2_strange_base_removal.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15446 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
