[Freeciv-Dev] [bug #15510] accidently clicking a settler/worker/engineer loses all terrain improvement progress

2010-07-19 Thread anonymous

Follow-up Comment #5, bug #15510 (project freeciv):

Yes, that's it. Thanks.

___

Reply to this item at:

  http://gna.org/bugs/?15510

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1739] [players] use pointers for players

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #7, patch #1739 (project freeciv):

updated version; do not use an extra struct but 'struct player **pslot'

(file #9527)
___

Additional Item Attachment:

File name: 20100719-01-trunk-use-pointers-for-players.patch Size:95 KB


___

Reply to this item at:

  http://gna.org/patch/?1739

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1741] [players] use player_slot_count

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1741 (project freeciv):

update (see patch #1739)

(file #9528)
___

Additional Item Attachment:

File name: 20100719-02-trunk-use-player_slot_count.patch Size:9 KB


___

Reply to this item at:

  http://gna.org/patch/?1741

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1743] [players] dynamically allocate player-diplstates

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1743 (project freeciv):

use 'struct player_diplstate **diplstates'

(file #9529)
___

Additional Item Attachment:

File name: 20100719-04-trunk-dynamically-allocate-player-diplstates.patch
Size:71 KB


___

Reply to this item at:

  http://gna.org/patch/?1743

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1744] [players] rename struct player-ai_data to ai_common

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #4, patch #1744 (project freeciv):

update to fix the patch wrt the other changes

 This affects only AI players, right? It should remain in
 structure clearly marked as AI stuff. I'm against polluting
 other structures with parts of AI stuff, especially with
 something that is only relevant to current AI implementation. 

OK

 This one makes sense. It's not part of AI, but tells if AI
 code should be used at all. Actually I think I already had
 patch to move it away from ai_data somewhere. 

In another update

 I'm a bit undecided about this. Should all implementations of
 modular AI to implement same skill levels, or can they define
 skill levels differently? 

A clear guideline is needed if this value is used in the client(s)

(file #9530)
___

Additional Item Attachment:

File name: 20100719-05-trunk-rename-struct-player-ai_data-to-ai_common.patch
Size:109 KB


___

Reply to this item at:

  http://gna.org/patch/?1744

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1745] [players] dynamically allocate ai_data

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #1, patch #1745 (project freeciv):

use 'struct ai_dip_intel **player_intel'

(file #9531)
___

Additional Item Attachment:

File name: 20100719-06-trunk-dynamically-allocate-ai_data.patch Size:48 KB


___

Reply to this item at:

  http://gna.org/patch/?1745

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1739] [players] use pointers for players

2010-07-19 Thread Matthias Pfafferodt

Follow-up Comment #8, patch #1739 (project freeciv):

as this and the following patches break the editor (one of 'the' features of
2.2) it needs to be fixed before this patch can be applied. Who does know the
inner workings of the editor? I think mbook but ...

___

Reply to this item at:

  http://gna.org/patch/?1739

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1753] Canadian ruleset new leaders

2010-07-19 Thread Scott Watkins

URL:
  http://gna.org/patch/?1753

 Summary: Canadian ruleset new leaders
 Project: Freeciv
Submitted by: gnomegarten
Submitted on: Tuesday 07/20/2010 at 01:16
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

I submitted this to the wishlist a while ago. I just checked back and saw a
request to post it here.

Not sure about formatting, so here's what I posted there:

This is a small thing, but I find it irksome in the new civclient, despite
the fact that overall I'm quite impressed. 

The list of available leaders is really not representative of Canadian
history, politics or gender. 

To give you an idea of what I mean, here's the list: 

Kim Campbell 
- the only woman on the list, the first female Prime Minister of Canada, and
one of the shortest serving. She was chosen to replace Brian Mulroney, and
was massively defeated in the subsequent election. 
Conservative. 

Brian Mulroney 
- Campbell's immediate predecessor, a leader who's massive unpopularity very
nearly destroyed the Conservatives. He did negotiate the Canada US Free Trade
Agreement, but beyond that his historical contributions are pretty
questionable. He has recently been implicated in a corruption scandal. 
Conservative. 

William Lyon McKenzie King 
- The longest serving Prime Minister in the history of the British
Commonwealth. Canada's Prime Minister during WWII. Noted anti-semite. There's
lots to say good and bad about McKenzie King, but he certainly was significant
to Canadian history. 
Liberal. 

John Diefenbaker 
- Prime Minister during the late 50's and early 60's. Introduced the Canadian
Bill of Rights. Cancelled the AVRO Arrow project (a sore point to Canadians as
we very briefly were developing what would have been the most advanced jet
fighter in the world). 
Conservative. 

John A. MacDonald 
- First Prime Minister of Canada. One of the Founders of Confederation.
Legendary drinker. Depicted on the 10 dollar bill. 
Conservative. 

Pierre Trudeau 
- Prime Minister from the late 60's to the late 70's, and again for the first
half of the 80's. Patriated and formalized the Constitution. Wrote the Charter
of Rights. Dealt with terrorists in Quebec during the October Crisis of 1970
(some say too harshly). His wife left him for the Rolling Stones. Considered
the father of Canadian multiculturalism. 
Liberal. 

The problem with this list is that it's got only one woman, too many
Conservatives, and a few who's historical contributions are questionable at
best. (I'm not looking at this ideologically, I just think that there's a
bias here). 

There are several others who would be better choices for the list, including
non Prime Ministers. 

A few obvious choices: 

Lester B. Pearson 
- Prime Minister in the mid 60's. Won the Nobel Peace Prize in 1957 as a
diplomat for defusing the Suez Crisis. Father of the modern concept of
Peacekeeping. Introduced official bilingualism. 
Liberal. 

Tommy Douglas 
- First leader of the New Democrats, and the father of medicare in Canada. A
Canadian TV series voting competition selected him as the Greatest Canadian.


Laura Secord 
- Heroine of the War of 1812. Overheard plans of an American attack on the
Province of Canada, and drove her cows 30 km to warn the British generals.
(seriously, this actually happened) 

Nellie McClung 
- Pioneering activist who successfully won the right to vote for women. 

I realize that this is in many ways a small matter, but looking at the list
for other nations, particularly the Americans, the Canadian list does not
seem up to snuff.




___

Reply to this item at:

  http://gna.org/patch/?1753

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev