[Freeciv-Dev] [bug #19103] Fix minor bugs in new nations
URL: http://gna.org/bugs/?19103 Summary: Fix minor bugs in new nations Project: Freeciv Submitted by: jtn Submitted on: Sat Dec 3 17:24:20 2011 Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.4.0,2.5.0 ___ Details: Time for the usual pre-release nation check running the server with various rulesets and diagnostics. ___ Reply to this item at: http://gna.org/bugs/?19103 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19103] Fix minor bugs in new nations
Update of bug #19103 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-nations-minor-bugs.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?19103 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19094] Superseded motswana/mosotho rulesets should be deleted
Update of bug #19094 (project freeciv): Category: bootstrap = rulesets Assigned to:None = jtn Planned Release: 2.5.0 = 2.4.0,2.5.0 Summary: Some nations rulesets not added to tarball = Superseded motswana/mosotho rulesets should be deleted ___ Follow-up Comment #1: These nation files exist on S2_4 as well, so presumably we want to deal with this for 2.4.0. In fact, these nations (Motswana, Mosotho) aren't plumbed in at all. I think these files should just be deleted -- this should have happened under bug #18182: * motswana.ruleset was supposed to be replaced by botswanan.ruleset (and tswana.ruleset was split out) * mosotho.ruleset was split into lesothoan.ruleset and sotho.ruleset The former is still referenced in namibian.ruleset as a civilwar_nation. Should it be replaced by botswanan, or tswana, or both? I've assumed just the former by default. (Didn't see any email to freeciv-dev, btw...) (file #14639) ___ Additional Item Attachment: File name: trunk-S2_4-nations-rm-superseded.diff Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?19094 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19104] [traits] in sanity_check_size() [mem.c::61]: Warning: malloc with size 0
URL: http://gna.org/bugs/?19104 Summary: [traits] in sanity_check_size() [mem.c::61]: Warning: malloc with size 0 Project: Freeciv Submitted by: jtn Submitted on: Sat Dec 3 18:11:10 2011 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.5.0 ___ Details: Running a trunk server with -d 3 gives a bunch of the quoted message. This is due to an off-by-one when malloc'ing space for nation traits (there's currently one, placeholder, but we malloc k*trait_max() where trait_max() is 0). This presumably doesn't lead to segfaults because fc_real_malloc() suppresses the allowed/common C behaviour of returning NULL from malloc(0) (although it's still malloc'ing only 1 char, not sizeof(int)). ___ Reply to this item at: http://gna.org/bugs/?19104 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19104] [traits] in sanity_check_size() [mem.c::61]: Warning: malloc with size 0
Update of bug #19104 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-trait-nation-alloc.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19104 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19105] File information in logged repeated messages can be misleading
URL: http://gna.org/bugs/?19105 Summary: File information in logged repeated messages can be misleading Project: Freeciv Submitted by: jtn Submitted on: Sat Dec 3 18:15:45 2011 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r20621 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: When tracking down bug #19104 with -d 3 -l file, the stuff in the file looked like: 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: Warning: malloc with size 0 at line 570 of nation.c 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 2 times 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 2 times (total 4 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 4 times (total 8 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 8 times (total 16 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 16 times (total 32 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 32 times (total 64 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 64 times (total 128 repeats) 3: [T000 - 2011/12/03 17:27:04] in sanity_check_size() [mem.c::61]: last message repeated 128 times (total 256 repeats) 3: [T000 - 2011/12/03 17:27:04] in valid_ruleset_filename() [ruleset.c::205]: last message repeated 246 times (total 502 repeats) 3: [T000 - 2011/12/03 17:57:30] in valid_ruleset_filename() [ruleset.c::205]: Trying default/effects.ruleset. The penultimate line is misleading -- the repeated message can't come from ruleset.c (that's the line that says Trying...). I assume the mem.c::61 isn't being saved so that it can be output in the final last message repeated X times that's output when a different message comes along. ___ Reply to this item at: http://gna.org/bugs/?19105 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19104] [traits] in sanity_check_size() [mem.c::61]: Warning: malloc with size 0
Follow-up Comment #1, bug #19104 (project freeciv): On second thoughts, let's use fc_calloc(). We don't need the zeroing, but otherwise it's tidier. (file #14641) ___ Additional Item Attachment: File name: trunk-trait-nation-alloc-bis.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19104 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3036] specenum _size()
Follow-up Comment #2, patch #3036 (project freeciv): I think this already exists -- if you were to #define SPECENUM_COUNT trait_array_size before #including specenum_gen.h, for example, you'd get an enum constant trait_array_size which could be used in place of trait_max()+1. (Added in patch #1678.) ___ Reply to this item at: http://gna.org/patch/?3036 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19034] installer demands root access
Update of bug #19034 (project freeciv): Assigned to:None = bitaxis ___ Reply to this item at: http://gna.org/bugs/?19034 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3063] Removing some minor/useless 'leaders' from ukrainian nation
Update of patch #3063 (project freeciv): Assigned to:None = mixcoatl ___ Reply to this item at: http://gna.org/patch/?3063 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19094] Superseded motswana/mosotho rulesets should be deleted
Follow-up Comment #2, bug #19094 (project freeciv): You have to remove them from POTFILES.in too. ___ Reply to this item at: http://gna.org/bugs/?19094 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19094] Superseded motswana/mosotho rulesets should be deleted
Follow-up Comment #3, bug #19094 (project freeciv): True. (file #14643) ___ Additional Item Attachment: File name: trunk-S2_4-nations-rm-superseded-bis.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?19094 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3043] Comparisons trait_end() - != trait_end()
Follow-up Comment #3, patch #3043 (project freeciv):
I asked:
Could we add the usual iterator pattern to specenums?
On a moment's more thought: we can't define trait_iterate(t) { ... }
because that would involve a #define parameterised by a #define. The best we
can easily do would be SPECENUM_ITERATE(trait, t) { ... } which might be
sufficiently more ugly as to not be worth it (compared to the explicit for
loop).
___
Reply to this item at:
http://gna.org/patch/?3043
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19019] Language selection in Windows installer
Update of bug #19019 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19019 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19107] Senate blocking war declaration is tied to Any_Government effect
URL: http://gna.org/bugs/?19107 Summary: Senate blocking war declaration is tied to Any_Government effect Project: Freeciv Submitted by: jtn Submitted on: Sun Dec 4 00:20:40 2011 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.3.0 Discussion Lock: Any Operating System: Any Planned Release: 2.4.0,2.5.0 ___ Details: Split from bug #18773: In the supplied rulesets, buildings like the Statue of Liberty effectively neuter the senate in Republic/Democracy: if you try to break pact when you have a senate, it lets it through anyway (The senate refuses to break treaty with the Eastasians, but you have no trouble finding a new senate.) However, this behaviour is triggered off Any_Government, not No_Anarchy (both of which attach to the Statue of Liberty). This looks wrong; I think it should come with No_Anarchy, since I think the feature is for consistency with the other aspects of that effect (no point having a senate blocking things if you can get round it by changing government with no cost). This wouldn't change the behaviour of any of the supplied rulesets, as they always use these two effects together. This could be considered a file format change, as it could change the behaviour of existing rulesets. Is anyone going to object to me putting this on S2_4 as well as trunk? ___ Reply to this item at: http://gna.org/bugs/?19107 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19107] Senate blocking war declaration is tied to Any_Government effect
Update of bug #19107 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-no-anarchy-no-senate.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?19107 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fullmoon build results
This is build report automatically generated by FullMoon Ilmarinen (0.4.50.1) Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from TRUNK. Component svn, Host cazfi.net, Phase Source update(1): Succeeded Component autogen.sh, Host cazfi.net, Phase Other command(0): Succeeded Component server, Host cazfi.net, Phase Build(2): Succeeded Component gtk2, Host cazfi.net, Phase Build(2): Succeeded Component sdl, Host cazfi.net, Phase Build(2): Succeeded Component xaw, Host cazfi.net, Phase Build(2): Succeeded Component qt, Host cazfi.net, Phase Build(2): Succeeded Component stub, Host cazfi.net, Phase Build(2): Succeeded Component QualityCheck, Host cazfi.net, Phase Check(4): FAILED ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
