[Freeciv-Dev] S2_4 valgrind

2012-10-07 Thread Marko Lindqvist 
 Memory-leak wise S2_4 server seems to be in excellent condition! I
just had server-only autogame running in valgrind for several days. In
the end there was just a bit over 300k of unfreed memory. Seems like
there was no single continuous leak - that 300k is just some buffers
allocated in the beginning, kept in memory and not freed in the end. I
don't think any earlier branch has been clean of leaks when tested for
the first time.

 Next I'll investigate if some of those unfreed buffers can be freed
on program exit to reduce spam from future reports, run another server
test with different settings, and then look in to time-consuming runs
of valgrinding clients in autogame.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3346] Ranklog: add player's score to log -- rank even if game ends for /endturn

2012-10-07 Thread Davide Baldini 
Follow-up Comment #14, patch #3346 (project freeciv):

Yes, math.h in srv_main.c is not required. I must have forgot it across my
several local revisions.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3536] Pillageable property for roads

2012-10-07 Thread Marko Lindqvist 
URL:
  

 Summary: Pillageable property for roads
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Oct 2012 07:45:42 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add pillageable property for roads similar to what bases have.



___

File Attachments:


---
Date: Mon 08 Oct 2012 07:45:42 AM EEST  Name: PillageableRoads.patch  Size:
8kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3535] Fix road's native_to comment in rulesets

2012-10-07 Thread Marko Lindqvist 
URL:
  

 Summary: Fix road's native_to comment in rulesets
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Oct 2012 07:33:16 AM EEST
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Comments in rulesets document road's "native_to" as if it alone would make
tile native to units. "native_to" units just get movement benefit from the
road unless road has also "NativeTile" flag. Patch to correct comments
attached.



___

File Attachments:


---
Date: Mon 08 Oct 2012 07:33:16 AM EEST  Name: NativeRoadDocFix.patch  Size:
8kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20110] Lack of "legend" in nations/nation.ruleset leads to server segfault

2012-10-07 Thread Marko Lindqvist 
Follow-up Comment #1, bug #20110 (project freeciv):

It crashes already when loading rulesets, not when freeing them.

(gdb) bt
#0  __strlen_sse42 () at ../sysdeps/x86_64/multiarch/strlen-sse4.S:32
#1  0x005ec579 in real_fc_strdup (str=0x0, 
called_as=called_as@entry=0x634f53 "strdup", line=line@entry=3198, 
file=file@entry=0x64f400 "src.patched/server/ruleset.c")
at src.patched/utility/mem.c:141
#2  0x004a61db in load_ruleset_nations (file=file@entry=0xc09b40)
at src.patched/server/ruleset.c:3197
#3  0x004acd88 in load_rulesetdir (rsdir=0xac9383 "classic")
at src.patched/server/ruleset.c:4680
#4  0x004ae63e in load_rulesets () at
src.patched/server/ruleset.c:4611
#5  0x0043de26 in srv_prepare () at
src.patched/server/srv_main.c:2412
#6  srv_main () at src.patched/server/srv_main.c:2720
#7  0x0043530e in main (argc=1, argv=0x7fffe378)
at src.patched/server/civserver.c:453


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20109] Compilation fails with stdinhand on OSX

2012-10-07 Thread Marko Lindqvist 
Follow-up Comment #1, bug #20109 (project freeciv):

Can you check if rl_completion_suppress_append is listed in your
readline/readline.h?

I have
extern int rl_completion_suppress_append;

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3346] Ranklog: add player's score to log -- rank even if game ends for /endturn

2012-10-07 Thread Marko Lindqvist 
Follow-up Comment #13, patch #3346 (project freeciv):

- Removed math.h include from srv_main.c. Changes made to that file could no
way require it. Maybe it was leftover from some earlier experiment you did?

(file #16668)
___

Additional Item Attachment:

File name: RankingFixes-2.patch   Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3530] Indent --enable-ai-static help correctly

2012-10-07 Thread Marko Lindqvist 
Follow-up Comment #1, patch #3530 (project freeciv):

- Helptexts for several other options aligned too

(file #1, file #16667)
___

Additional Item Attachment:

File name: ConfHelpAlign.patchSize:2 KB
File name: ConfHelpAlign-S2_4.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20226] AI settlers continue city building mission when borders change

2012-10-07 Thread Marko Lindqvist 
Update of bug #20226 (project freeciv):

  Status:  Ready For Test => Invalid
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Too hasty. It's handled in city_can_be_built_here() after all.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20226] AI settlers continue city building mission when borders change

2012-10-07 Thread Marko Lindqvist 
URL:
  

 Summary: AI settlers continue city building mission when
borders change
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 08 Oct 2012 01:47:54 AM EEST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.3, 2.4.0, 2.5.0

___

Details:

AI settlers are prevented from building cities on peaceful neighbours land. It
knows that when planning placement for new cities. But it does not abort city
building missions if borders change while settler is on its way.

Fix attached.



___

File Attachments:


---
Date: Mon 08 Oct 2012 01:47:55 AM EEST  Name:
AbortCityBuildingOnBorderChange.patch  Size: 963B   By: cazfi


---
Date: Mon 08 Oct 2012 01:47:55 AM EEST  Name:
AbortCityBuildingOnBorderChange-S2_4.patch  Size: 950B   By: cazfi


---
Date: Mon 08 Oct 2012 01:47:55 AM EEST  Name:
AbortCityBuildingOnBorderChange-S2_3.patch  Size: 912B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)

2012-10-07 Thread Marko Lindqvist 
Update of bug #19977 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to: jtn => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19800] Server crash after reading "multiplayer.serv" or "civ2.serv"

2012-10-07 Thread Marko Lindqvist 
Update of bug #19800 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-10-07 Thread Marko Lindqvist 
Update of patch #3495 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.5.0  

___

Follow-up Comment #16:

Attached patch adds boolean server setting "startcity" controlling whether
player starts with first city already in place or not.

(file #16662)
___

Additional Item Attachment:

File name: StartCity.patchSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3534] Include libgen.h to support.c for POSIX basename()

2012-10-07 Thread Marko Lindqvist 
Update of patch #3534 (project freeciv):

 Summary: Include libgen.h to support.h for POSIX basename()
=> Include libgen.h to support.c for POSIX basename()


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3534] Include libgen.h to support.h for POSIX basename()

2012-10-07 Thread Marko Lindqvist 
URL:
  

 Summary: Include libgen.h to support.h for POSIX basename()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 07 Oct 2012 09:14:32 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0, 2.5.0

___

Details:

Windows build gives warning about undefined basename(). That's because we rely
on GNU version on string.h. Attached patch adds libgen.h include for POSIX
version declaration.



___

File Attachments:


---
Date: Sun 07 Oct 2012 09:14:32 PM EEST  Name: LibgenBasename.patch  Size: 1kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20006] Server option "-a" help says "-D" required, but omitting one is not considered error

2012-10-07 Thread Marko Lindqvist 
Update of bug #20006 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17595] Odd code in client/gui-gtk-2.0/wldlg.c:refresh_worklist()

2012-10-07 Thread Marko Lindqvist 
Follow-up Comment #1, bug #17595 (project freeciv):

pgwl gets assigned only if ptr->pcity == NULL.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev