[Freeciv-Dev] [bug #20751] assertion 'normal_player_count() <= game.server.max_players' failed

2013-04-20 Thread Marko Lindqvist
Update of bug #20751 (project freeciv): Status:None => Ready For Test Planned Release: => 2.3.5, 2.4.0, 2.5.0 ___ Follow-up Comment #3: Maxplayers in saveg

[Freeciv-Dev] [bug #20751] assertion 'normal_player_count() <= game.server.max_players' failed

2013-04-20 Thread Jordi Negrevernis i Font
Follow-up Comment #2, bug #20751 (project freeciv): This game is a savegame of a recent revision of S2_4, maybe a couple of weeks ago... ___ Reply to this item at: __

[Freeciv-Dev] [bug #20747] Units in nested transport considered defensive units

2013-04-20 Thread Emmet Hikory
Follow-up Comment #3, bug #20747 (project freeciv): The same patch applies to S2_4 with a 1-line offset, and should be suitable there as well. ___ Reply to this item at: _

[Freeciv-Dev] [patch #3839] Low hanging nativity fixes

2013-04-20 Thread Emmet Hikory
Follow-up Comment #2, patch #3839 (project freeciv): Heh, perhaps my definition of "lightweight" was adjusted by the remainder of the nativity stuff :) I've no objection to splitting this into bits: it was assembled from bits as I tried to clean up nativity everywhere: these were the ones that we

[Freeciv-Dev] [bug #20747] Units in nested transport considered defensive units

2013-04-20 Thread Emmet Hikory
Follow-up Comment #2, bug #20747 (project freeciv): >From code inspection, it appears that the same patch could also be applied to S2_4 (I'll test when my current autogames are complete), and that it would provide a similar benefit. About combat.c: get_virtual_defense_power() uses can_unit_exist

[Freeciv-Dev] [patch #3839] Low hanging nativity fixes

2013-04-20 Thread Marko Lindqvist
Update of patch #3839 (project freeciv): Status:None => In Progress Assigned to:None => cazfi ___ Follow-up Comment #1: > all fairly light

[Freeciv-Dev] [patch #3860] Nations ruleset: allow terrain checking against explicit compatibility list

2013-04-20 Thread Jacob Nevins
Follow-up Comment #2, patch #3860 (project freeciv): Rats, missed that. ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ _

[Freeciv-Dev] [patch #3708] Reinstate terrain checks for natural city names

2013-04-20 Thread Jacob Nevins
Update of patch #3708 (project freeciv): Status:None => Duplicate Open/Closed:Open => Closed ___ Follow-up Comment #1: Will be fixed in p

[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset

2013-04-20 Thread Jacob Nevins
Follow-up Comment #8, bug #19841 (project freeciv): > Would it be better to have a section in nationlist.ruleset > explicitly listing all allowed govs in leader titles (and > e.g. terrains) [...] I've implemented this in the patch series starting at patch #3859. _

[Freeciv-Dev] [patch #3861] Nations ruleset: replace warn_city_style with allowed_city_styles

2013-04-20 Thread Jacob Nevins
Update of patch #3861 (project freeciv): Status: In Progress => Ready For Test Depends on: => patch #3860 ___ Additional Item Attachment: File name: t

[Freeciv-Dev] [patch #3860] Nations ruleset: allow terrain checking against explicit compatibility list

2013-04-20 Thread Jacob Nevins
Update of patch #3860 (project freeciv): Status: In Progress => Ready For Test Depends on: => patch #3859 ___ Additional Item Attachment: File name: t

[Freeciv-Dev] [patch #3859] Nations ruleset: move government compatibility checking to nationlist.ruleset

2013-04-20 Thread Jacob Nevins
Additional Item Attachment, patch #3859 (project freeciv): File name: trunk-nations-allowed-govs-bis.patch Size:10 KB ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #20752] Errors in nation rulesets cause spurious messages about lack of defined barbarians

2013-04-20 Thread Jacob Nevins
Update of bug #20752 (project freeciv): Status: In Progress => Ready For Test ___ Additional Item Attachment: File name: trunk-nations-ruleset-barbarian-errors.patch Size:0 KB __

[Freeciv-Dev] [patch #3759] Make freesounds the default soundset

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #7, patch #3759 (project freeciv): > Would this patch be the best place to discuss it? Yes, that would keep the discussion stored where one would be looking for the info. ___ Reply to this item at:

[Freeciv-Dev] [patch #3860] Nations ruleset: allow terrain checking against explicit compatibility list

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #1, patch #3860 (project freeciv): Seems like duplicate of patch #3708, but if you're adding patch here, it's probably better to mark #3708 as duplicate of this. ___ Reply to this item at:

[Freeciv-Dev] [patch #3861] Nations ruleset: replace warn_city_style with allowed_city_styles

2013-04-20 Thread Jacob Nevins
URL: Summary: Nations ruleset: replace warn_city_style with allowed_city_styles Project: Freeciv Submitted by: jtn Submitted on: Sun Apr 21 00:10:11 2013 Category: None Priority

[Freeciv-Dev] [patch #3860] Nations ruleset: allow terrain checking against explicit compatibility list

2013-04-20 Thread Jacob Nevins
URL: Summary: Nations ruleset: allow terrain checking against explicit compatibility list Project: Freeciv Submitted by: jtn Submitted on: Sun Apr 21 00:07:49 2013 Category: None

[Freeciv-Dev] [bug #20747] Units in nested transport considered defensive units

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #1, bug #20747 (project freeciv): This affects both S2_4 and TRUNK, or? Also, I remember there being equivalent logic of "transported unit stepping out to defend" in defense value calculation in combat.c. Have you checked if it's ok in this respect? _

[Freeciv-Dev] [bug #20752] Errors in nation rulesets cause spurious messages about lack of defined barbarians

2013-04-20 Thread Jacob Nevins
URL: Summary: Errors in nation rulesets cause spurious messages about lack of defined barbarians Project: Freeciv Submitted by: jtn Submitted on: Sat Apr 20 23:57:28 2013 Category: None

[Freeciv-Dev] [patch #3692] Reduce SHIELD_WEIGHTING

2013-04-20 Thread Marko Lindqvist
Update of patch #3692 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed

2013-04-20 Thread Marko Lindqvist
Update of bug #20542 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] Nativity restrictions in clients

2013-04-20 Thread Emmet Hikory
The client code seems to use UMT_*, TC_OCEAN, is_foo_unit(), and is_ocean() in several places for which I don't really understand the correct behaviour to support complex unit nativity. Suggestions, opinions, and pointers to open bugs or patches welcome. climisc.c:unit_color_type() Thi

[Freeciv-Dev] [bug #20751] assertion 'normal_player_count() <= game.server.max_players' failed

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #1, bug #20751 (project freeciv): Is that savegame also created with some recent freeciv revision, or is it from older freeciv? ___ Reply to this item at: __

[Freeciv-Dev] [bug #20751] assertion 'normal_player_count() <= game.server.max_players' failed

2013-04-20 Thread Jordi Negrevernis i Font
URL: Summary: assertion 'normal_player_count() <= game.server.max_players' failed Project: Freeciv Submitted by: jorneg Submitted on: Sat Apr 20 20:15:51 2013 Category: general

[Freeciv-Dev] [patch #3859] Nations ruleset: move government compatibility checking to nationlist.ruleset

2013-04-20 Thread Jacob Nevins
Update of patch #3859 (project freeciv): Status: In Progress => Ready For Test ___ Additional Item Attachment: File name: trunk-nations-allowed-govs.patch Size:10 KB

[Freeciv-Dev] [patch #3859] Nations ruleset: move government compatibility checking to nationlist.ruleset

2013-04-20 Thread Jacob Nevins
URL: Summary: Nations ruleset: move government compatibility checking to nationlist.ruleset Project: Freeciv Submitted by: jtn Submitted on: Sat Apr 20 20:56:13 2013 Category: None

[Freeciv-Dev] [patch #3759] Make freesounds the default soundset

2013-04-20 Thread Gavin van L
Follow-up Comment #6, patch #3759 (project freeciv): Hey all. Bernd Jendrissek just pointed out to me that you were re-evaluating the freesound soundset. I'd be more than happy to take on the project of re-evaluating the licencing issues with the soundset. It would be fantastic to get it included.

[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1

2013-04-20 Thread Jacob Nevins
Follow-up Comment #16, task #7599 (project freeciv): (The Windows Gtk3 build story continues in task #7681.) ___ Reply to this item at: ___ Message sent via/by Gn

[Freeciv-Dev] [task #7681] Distribute Windows build of Gtk3 client

2013-04-20 Thread Jacob Nevins
URL: Summary: Distribute Windows build of Gtk3 client Project: Freeciv Submitted by: jtn Submitted on: Sat Apr 20 15:23:04 2013 Should Start On: Sat Apr 20 00:00:00 2013 Should be Finished on: Mon A

[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c

2013-04-20 Thread Matthias Pfafferodt
Update of bug #20585 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => syntron Open/Closed:Open => Closed _

[Freeciv-Dev] [task #7678] Windows packages for 2.4.0-beta2

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #2, task #7678 (project freeciv): Now the very latest (on the mirror I'm using) ImageMagick, 6.8.4-10, compiles too. ___ Reply to this item at: __

[Freeciv-Dev] [bug #18517] unable to drag items in Target Worklist to reorder.

2013-04-20 Thread Marko Lindqvist
Follow-up Comment #17, bug #18517 (project freeciv): Tested with crosser build that uses gtk+-2.24.10. Reordering by dragging seems to work. ___ Reply to this item at: ___

[Freeciv-Dev] [bug #20750] packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

2013-04-20 Thread Jacob Nevins
URL: Summary: packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable] Project: Freeciv Submitted by: jtn Submitted on: Sat Apr 20 10:58:51 2013

[Freeciv-Dev] 2.4.0-beta2 release soon

2013-04-20 Thread Jacob Nevins
At last, we're expecting to release 2.4.0-beta2 next weekend sometime (27-28 April). We have a vague hope that this will be the last beta before we go to release candidates. For translators: since this is a beta, I can't promise a string freeze, although I'm not aware of any expected string change

[Freeciv-Dev] [patch #3858] Drop support for pre-2.0 savegame loading

2013-04-20 Thread Marko Lindqvist
URL: Summary: Drop support for pre-2.0 savegame loading Project: Freeciv Submitted by: cazfi Submitted on: Sat 20 Apr 2013 10:54:59 AM EEST Category: general Priority: 5 - Norma

[Freeciv-Dev] [patch #3857] Remove savegame.c:savefile_options_default[]

2013-04-20 Thread Marko Lindqvist
URL: Summary: Remove savegame.c:savefile_options_default[] Project: Freeciv Submitted by: cazfi Submitted on: Sat 20 Apr 2013 10:50:04 AM EEST Category: general Priority: 5 - No