[Freeciv-Dev] [patch #3936] In GTK2, fullscreen mode, menu bar is not clickable at the very top
URL: http://gna.org/patch/?3936 Summary: In GTK2, fullscreen mode, menu bar is not clickable at the very top Project: Freeciv Submitted by: englabenny Submitted on: fre 7 jun 2013 13.11.25 Category: client-gtk-2.0 Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: It's much easier to use a menu bar (in fullscreen) if you can click the menu items when the pointer is on the edge of the screen. This following screenshot demonstrates with the patch (left) and current freeciv (right), with the mouse pointer flush to the edge of the screen. The current freeciv needs you to click a few pixels below the top edge of the screen. http://i.imgur.com/zVkvfBN.png As an aside, GIMP 2.8 in fullscreen has the expected menu behavior where it is clickable on the edge of the screen. The patch changes shadow type on two widgets (GtkViewport and GtkScrolledWindow) and the shadow type style variable on GtkMenuBar. The patch applies identically to the gtk-2 client on 2.3, 2.4 and master. I have not yet attempted the gtk-3 client. The patch depends on a tweak in the gtk theme so at the moment it will only work with the Freeciv (default) theme. Not sure if this is practical to work around. ___ File Attachments: --- Date: fre 7 jun 2013 13.11.25 Name: menubar_flush_top_edge.diff Size: 3 kB By: englabenny Patch for gtk2 client http://gna.org/patch/download.php?file_id=18055 ___ Reply to this item at: http://gna.org/patch/?3936 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies
Follow-up Comment #2, patch #3933 (project freeciv): Attachment 1 affects the following files: common/fc_types.h common/game.h common/packets.def server/citytools.c:unit_enter_city() server/ruleset.c I.e. the same ones as the original submission plus fc_types.h - I hope that was the correct place to define the new enum (on a sidenote, using SPECENUM was surprisingly easy considering how scary the code looked). Apart from that I also added another couple of possible settings (see below). I had to add to the possible cpu workload and player notification spam in unit_enter_city(), but on the plus side the new code makes use of existing notifications and thus doesn't add any work for translators. Attachment 2 affects the game.ruleset files for alien, civ1, civ2, civ2civ3, classic, experimental and multiplayer. Full addition: ; Method of transferring unit upkeep from cities lost to conquering enemies ; (all styles but None require gold_upkeep_style 0). Where applicable ; units will have their upkeep transferred to the city closest to their ; current location in which they can exist. ; None - (Default) No units are transferred. ; BaseGold - Units with gold only or free of upkeep prior to applying any ;effects have their upkeep transferred. ; EffGold - Units with gold only or free of upkeep after applying player- ;and city effects (including Shield2Gold) have their upkeep transferred. ; BaseNoFood - Units without food upkeep prior to applying any effects have ;their upkeep transferred. ; EffNoFood - Units without food upkeep after applying current effects have ;their upkeep transferred. ; All - All units have their upkeep transferred. upkeep_transfer_style = None (file #18056, file #18057) ___ Additional Item Attachment: File name: upkeep_transfer_style.patchSize:7 KB File name: uts_rulesets.patch Size:8 KB ___ Reply to this item at: http://gna.org/patch/?3933 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3936] In GTK2, fullscreen mode, menu bar is not clickable at the very top
Follow-up Comment #1, patch #3936 (project freeciv): Second patch version, with changes to ./data/freeciv.rc-2.0 to make sure it works the same way with any freeciv gtk theme. We could attempt to only disable the shadows (borders) around the GtkScrolledWindow when in fullscreen. Is it worth it to try? (file #18058) ___ Additional Item Attachment: File name: 0001-Make-sure-the-GTK-2-client-s-menu-bar-is-flush-to-th.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?3936 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
