[Freeciv-Dev] [bug #21201] freeciv-ruledit: build fails with --enable-fcdb

2013-10-19 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?21201

 Summary: freeciv-ruledit: build fails with --enable-fcdb
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Oct 19 12:19:09 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r23595
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Just tried adding --enable-ruledit to my configure rune for laughs, and the
build fell over:


  CCLD   freeciv-ruledit
../../server/.libs/libfreeciv-srv.a(script_fcdb.o): In function
`script_fcdb_init':
/home/jtn/src/freeciv/git/server/scripting/script_fcdb.c:204: undefined
reference to `luaopen_luasql_mysql'
/home/jtn/src/freeciv/git/server/scripting/script_fcdb.c:212: undefined
reference to `luaopen_luasql_sqlite3'
collect2: ld returned 1 exit status
make[3]: *** [freeciv-ruledit] Error 1


Presumably a fairly straightforward disentanglement of fcdb/scripting from the
server libs needed by ruledit is needed.

Full configure rune:


./configure --enable-debug=yes --enable-client=gtk2,sdl,xaw,stub,qt
--enable-auth --enable-fcdb=sqlite3,mysql --enable-ai-static=classic,threaded
--prefix=/home/jtn/src/freeciv/git/inst --enable-fcmp=all --enable-ruledit
CC=ccache gcc CXX=ccache g++





___

Reply to this item at:

  http://gna.org/bugs/?21201

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21177] Mapuche ruleset improved and fixed

2013-10-19 Thread Jacob Nevins
Update of bug #21177 (project freeciv):

 Assigned to:None = mixcoatl   


___

Reply to this item at:

  http://gna.org/bugs/?21177

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?21202

 Summary: Assertion failures and segfault removing player in
pregame
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Oct 19 13:46:24 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r23595
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.6.0

___

Details:

Two players attached to server in pregame; one uses the menu in the client to
remove the other (but I expect '/remove' at the server prompt would break
too).

Works fine on current head of S2_5 or S2_4, so seems trunk-specific.


herp: '/remove Derp'
2: Removing player Derp.
2: AI*1 has been added as Easy level AI-controlled player (classic).
2: AI*1 has been added as Easy level AI-controlled player (classic).
1: in genlist_size() [genlist.c::233]: assertion '((void *)0) != pgenlist'
failed.
2: Backtrace:
2: 0: server/freeciv-server() [0x6207bb]
2: 1: server/freeciv-server(vdo_log+0x9b) [0x62428b]
2: 2: server/freeciv-server(do_log+0x7d) [0x62435d]
2: 3: server/freeciv-server(fc_assert_fail+0x9f) [0x62458f]
2: 4: server/freeciv-server(genlist_size+0x35) [0x622cf5]
2: 5: server/freeciv-server(server_remove_player+0x102) [0x49e402]
2: 6: server/freeciv-server() [0x44a565]
2: 7: server/freeciv-server(handle_chat_msg_req+0x45d) [0x4f06ed]
2: 8: server/freeciv-server(server_handle_packet+0x6d2) [0x495c22]
2: 9: server/freeciv-server(server_packet_input+0xbb) [0x43933b]
2:10: server/freeciv-server(server_sniff_all_input+0x8b2) [0x4d6bd2]
2:11: server/freeciv-server(srv_main+0x1ad) [0x43bb6d]
2:12: server/freeciv-server(main+0x78a) [0x433f9a]
2:13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)
[0x7fc86347176d]
2:14: server/freeciv-server() [0x4345f1]
1: Please report this message at http://gna.org/projects/freeciv/
[...]
1: in server_remove_player() [plrhand.c::1576]: assertion
'(player_index(pplayer)) = 0  (player_index(pplayer))  (signed int)
sizeof((aplayer-real_embassy).vec) * 8' failed.
2: Backtrace:
2: 0: server/freeciv-server() [0x6207bb]
2: 1: server/freeciv-server(vdo_log+0x9b) [0x62428b]
2: 2: server/freeciv-server(do_log+0x7d) [0x62435d]
2: 3: server/freeciv-server(fc_assert_fail+0x9f) [0x62458f]
2: 4: server/freeciv-server(server_remove_player+0x2cb) [0x49e5cb]
2: 5: server/freeciv-server() [0x44a565]
2: 6: server/freeciv-server(handle_chat_msg_req+0x45d) [0x4f06ed]
2: 7: server/freeciv-server(server_handle_packet+0x6d2) [0x495c22]
2: 8: server/freeciv-server(server_packet_input+0xbb) [0x43933b]
2: 9: server/freeciv-server(server_sniff_all_input+0x8b2) [0x4d6bd2]
2:10: server/freeciv-server(srv_main+0x1ad) [0x43bb6d]
2:11: server/freeciv-server(main+0x78a) [0x433f9a]
2:12: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)
[0x7fc86347176d]
2:13: server/freeciv-server() [0x4345f1]
1: Please report this message at http://gna.org/projects/freeciv/
[...]
Segmentation fault (core dumped)


Backtrace of segfault:


#0  0x0049e5e7 in server_remove_player (pplayer=0x30c1ec0)
at plrhand.c:1576
aplayer = 0x236edb0
_pslot = 0x1783160
pslot = 0x1783168
__FUNCTION__ = server_remove_player
#1  0x0044a565 in remove_player_command (check=false, 
arg=0x7fff51a37840 \Derp\, caller=0x949520) at stdinhand.c:1183
match_result = optimised out
pplayer = 0x30c1ec0
name = Derp, '\000' repeats 20 times\357,
IC\000\000\000\000\000@\251\243Q\377\177\000\000\000\000\000\000\000\000\000
#2  handle_stdin_input_real (caller=0x949520, str=optimised out, 
check=false, read_recursion=optimised out) at stdinhand.c:4297
command =
remove\000\000\260\224\r\003\000\000\000\000\360|\243Q\377\177\000\000\340|\243Q\377\177\000\000\210~\243Q\377\177\000\000\305\\g\000\000\000\000\000\025\000\000\000\000\000\000\000ĚŠIc\310\177\000\000\000\000\000\000\000\000\000\000\314\\g,
'\000' repeats 13 times, \001, '\000' repeats 103 times,  , '\000'
repeats 55 times,
\002\000\000\000\000\000\000\000\377\377\377\377\000\000\000\000\377\377\377\377\377\377\377\377,
'\000' repeats 16 times,
@\001\000\000\000\000\000\000\313\\g\000\000\000\000\000\000\225\224\000\000\000\000\000\300x\243Q\377\177\000\000\016\000\000\000\000\000\000\000\340\205\243Q\377\177\000\000\001\000\000\000\000\000\000\000\374\261Ic\310\177\000\000\001,
'\000' repeats 15 times\305, \\g, '\000' repeats 13 times,
P\234\224\000\000\000\000\000\326\001, '\000' repeats 14 times...
arg =

[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
Follow-up Comment #1, bug #21202 (project freeciv):

First assertion failure is here in server_remove_player():


  while (conn_list_size(pplayer-connections)  0) {
connection_detach(conn_list_get(pplayer-connections, 0));
  }


This goes round one iteration, but connection_detach() itself calls
server_remove_player() before returning, which is where I suspect things go
wrong. Not sure how this ever worked?

___

Reply to this item at:

  http://gna.org/bugs/?21202

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
Update of bug #21202 (project freeciv):

 Planned Release:   2.6.0 = 2.5.0,2.6.0

___

Follow-up Comment #2:

 Works fine on current head of S2_5 or S2_4, so seems trunk-specific.
Oh, it just happened on S2_5 r23564. Since I think the reason
pplayer-connections is giving NULL is that pplayer has been freed, I guess we
can expect intermittency.

___

Reply to this item at:

  http://gna.org/bugs/?21202

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
Follow-up Comment #3, bug #21202 (project freeciv):

This mutual recursion is present at least back to S2_3, looking at the code
and the double Removing player Derp. messages.

___

Reply to this item at:

  http://gna.org/bugs/?21202

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
Update of bug #21202 (project freeciv):

  Status:None = In Progress
 Assigned to:None = jtn


___

Reply to this item at:

  http://gna.org/bugs/?21202

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21202] Assertion failures and segfault removing player in pregame

2013-10-19 Thread Jacob Nevins
Update of bug #21202 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release: 2.5.0,2.6.0 = 2.3.5,2.4.1,2.5.0,2.6.0

___

Additional Item Attachment:

File name: trunk-S2_5-S2_4-remove-pregame-crash.patch Size:8 KB
File name: S2_3-remove-pregame-crash.patch Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?21202

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Fullmoon build results

2013-10-19 Thread fullmoon
This is build report automatically generated by Fullmoon Ilmarinen (0.5.50.0)

Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from 
TRUNK.

Component svn, Host build.cazfi.net, Phase Source update(1): Succeeded
Component autogen.sh, Host build.cazfi.net, Phase Other command(0): 
Succeeded
Component server, Host build.cazfi.net, Phase Build(2): Succeeded
Component gtk2, Host build.cazfi.net, Phase Build(2): Succeeded
Component sdl, Host build.cazfi.net, Phase Build(2): FAILED
Component xaw, Host build.cazfi.net, Phase Build(2): Succeeded
Component qt, Host build.cazfi.net, Phase Build(2): Succeeded
Component stub, Host build.cazfi.net, Phase Build(2): Succeeded


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3448] Nation sets: allow set of nations that will ever appear in-game to be chosen

2013-10-19 Thread Jacob Nevins
Update of patch #3448 (project freeciv):

 Planned Release:   2.5.0 = 2.5.0,2.6.0

___

Follow-up Comment #6:

Current WIP patch stack attached (these will become separate tickets in
time).
Pretty much completely working for server and Gtk2 client. Work still needed
on tidying and other clients.

(file #19212)
___

Additional Item Attachment:

File name: trunk-nation-sets-wip-bis.mbox Size:151 KB


___

Reply to this item at:

  http://gna.org/patch/?3448

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3448] Nation sets: allow set of nations that will ever appear in-game to be chosen

2013-10-19 Thread Jacob Nevins
Follow-up Comment #7, patch #3448 (project freeciv):

(Oh, and it still has loads of debug logging detritus.)

___

Reply to this item at:

  http://gna.org/patch/?3448

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev