[Freeciv-Dev] [bug #21272] freeciv-gtk2.exe caused an Access Violation at location 01b76408
Follow-up Comment #1, bug #21272 (project freeciv): Have now had 3 crashes with this error. Am using a plain vanilla windows 2.3.4 gtk client. The common factor in the crashes was looking inside a city. But different city each time with different things inside, and two of the 3 (possibly all) were team mates cities. This crash is not reproducible. After reconnecting I can look inside the city with no problem. ___ Reply to this item at: http://gna.org/bugs/?21272 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21272] freeciv-gtk2.exe caused an Access Violation while looking inside city
Update of bug #21272 (project freeciv): Summary: freeciv-gtk2.exe caused an Access Violation at location 01b76408 = freeciv-gtk2.exe caused an Access Violation while looking inside city ___ Follow-up Comment #2: I had a look at what's been fixed on the S2_3 branch since 2.3.4 was released (results on the wiki http://www.freeciv.org/wiki/NEWS-2.3.5), and didn't spot anything which we've already fixed which I thought could cause this symptom. So it might be something new. I've also played quite a few turns of the civ2-3 ruleset using head-of-S2_3 (not 2.3.4) on Linux without obvious issues. two of the 3 (possibly all) were team mates cities I wonder if this is significant (although you also say when looking inside one of my own cities, so it would have to be something triggered by the mere existence of teams in the game, such as pooled research?) I'm guessing this is a multiplayer game, so we can't see the savegame? ___ Reply to this item at: http://gna.org/bugs/?21272 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4307] Add Lua Script Ability to Increase Size Population Size
Follow-up Comment #1, patch #4307 (project freeciv): Hi Mark, thank you for your patch. This is my first post Welcome. Your next step is to address my feed back. If you think I'm wrong about something post a comment that explains why. If you think I'm right about something upload a fixed patch. More documentation can be found at: * http://freeciv.wikia.com/wiki/Testing_Tips * http://freeciv.wikia.com/wiki/Coding_Style * http://freeciv.wikia.com/wiki/How_to_Contribute I had a look at you patch. Some issues: * city.h is from common, not server. Please put it in the correct group. * Nit pick: You cover the case of subtracting as well. If you change the name from _add to _change it becomes self documenting. * You should inform the client when the city size changes. (Unless the client belong to a player that can't see the city size change) * Your patch makes a city of the size 0 possible. This is wrong. Destroying the city properly when the size becomes 0 or simply refusing to set the size to 0 are two possible ways to fix this. * Please look for assertion errors when you test your code. I managed to make you patch apply but it took some time. Advice on patch creation to make it easier in the future: * if this is accepted it will enter trunk, not 2.4. The patch should therefore be against trunk. You can download trunk from svn://svn.gna.org/svn/freeciv/trunk using your favorite SVN client. (If you aren't familiar with SVN but know other version control systems plug ins exists that let you use git, hg or bazaar as a SVN client) * the patch should be for the Freeciv source root even if it only modifies files in one sub folder. This way it won't be necessary to enter the sub folder to apply it. Your SVN client will probably handle this for you (if you use it to create the patch). * You patch has line break issues. Hopefully your text editor allows you to set line break style. Alternatively you can probably make your SVN client handle it. ___ Reply to this item at: http://gna.org/patch/?4307 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7681] Distribute Windows build of Gtk3 client
Update of task #7681 (project freeciv): Status: Need Info = Ready For Test Assigned to:None = cproc ___ Follow-up Comment #5: The attached patch makes the necessary changes to the Windows installer creation files. The updated gnuwin32 build environment is available at http://download.gna.org/freeciv/packages/windows/gnuwin32/gnuwin32-2013-11-18.7z. The GTK+ GUI names are now GTK+2 client and GTK+3 client and GTK+3 is used for the modpack installer in every package. The patch also removes the gtkrc file creation which caused problems with theme selection (bug #21163). (file #19357) ___ Additional Item Attachment: File name: task7681-20131119.patchSize:21 KB ___ Reply to this item at: http://gna.org/task/?7681 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4308] Environment upset flags for extras
URL: http://gna.org/patch/?4308 Summary: Environment upset flags for extras Project: Freeciv Submitted by: cazfi Submitted on: Tue 19 Nov 2013 02:36:48 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add extra flags GlobalWarming and NuclearWinter. Extras with these flags count toward environment upset. It used to be hardcoded so that just S_POLLUTION and S_FALLOUT cause upset. ___ File Attachments: --- Date: Tue 19 Nov 2013 02:36:48 AM EET Name: EnvUpsetFlags.patch Size: 12kB By: cazfi http://gna.org/patch/download.php?file_id=19358 ___ Reply to this item at: http://gna.org/patch/?4308 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fullmoon build results
This is build report automatically generated by Fullmoon Ilmarinen (0.5.50.0) Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from TRUNK. Component svn, Host build.cazfi.net, Phase Source update(1): Succeeded Component autogen.sh, Host build.cazfi.net, Phase Other command(0): Succeeded Component server, Host build.cazfi.net, Phase Build(2): Succeeded Component gtk2, Host build.cazfi.net, Phase Build(2): Succeeded Component sdl, Host build.cazfi.net, Phase Build(2): Succeeded Component sdl2, Host build.cazfi.net, Phase Build(2): FAILED Component xaw, Host build.cazfi.net, Phase Build(2): Succeeded Component qt, Host build.cazfi.net, Phase Build(2): Succeeded Component stub, Host build.cazfi.net, Phase Build(2): Succeeded ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4307] Add Lua Script Ability to Increase Size Population Size
Follow-up Comment #2, patch #4307 (project freeciv): Hi Sveinumg, Thanks for your feedback and all the time you put into your reply. I will work on addressing the issues identified. Cheers, Mark ___ Reply to this item at: http://gna.org/patch/?4307 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
