[Freeciv-Dev] [bug #21726] Gtk3 Freeciv theme extremely slow
Follow-up Comment #5, bug #21726 (project freeciv): There's discussion about the theme engine bug that's probably causing our problems in the forums: http://forum.freeciv.org/f/viewtopic.php?f=8t=317 I'm still about to commit the theme change. It doesn't hurt, and workaround in our own system helps end-users more than just saying that it's not our fault. ___ Reply to this item at: http://gna.org/bugs/?21726 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21726] Gtk3 Freeciv theme extremely slow
Update of bug #21726 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21726 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22180] Server crashes after first turn in a new game.
Follow-up Comment #18, bug #22180 (project freeciv): Could this linked with bug #22126? ___ Reply to this item at: http://gna.org/bugs/?22180 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21774] Pathfinding crash with 2.4.2-gtk2 Windows client
Update of bug #21774 (project freeciv): Operating System: Microsoft Windows = Any ___ Reply to this item at: http://gna.org/bugs/?21774 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4795] Rename automake cariables xxx_CAPITAL to xxx_capital
URL: http://gna.org/patch/?4795 Summary: Rename automake cariables xxx_CAPITAL to xxx_capital Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 12:13:13 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: automake-ng considers various target_XXXFLAGS variable namess reserved to the extend that it checks all variables fitting that pattern (having such suffix) against typos and giving an error if there is no equivalent target. We have been using such variables to store temporary/partial values, not referring to actual targets. Attached patches renames the offending variables, usually just making them lower-case. ___ File Attachments: --- Date: Fri 13 Jun 2014 12:13:13 AM EEST Name: amng-illegalvariables.patch.bz2 Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20986 --- Date: Fri 13 Jun 2014 12:13:13 AM EEST Name: amng-illegalvariables-S2_5.patch.bz2 Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20987 ___ Reply to this item at: http://gna.org/patch/?4795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22180] Server crashes after first turn in a new game.
Follow-up Comment #19, bug #22180 (project freeciv): Could this linked with bug #22126? More probably to the original trait ranges change that was causing also bug #22126. It changed when the traits get allocated, and this seems like they are not correctly allocated (though why it then doesn't crash during the normal turn change, but onyl during saving I don't know - maybe it's human player whose traits are not really used). Dennis: Could you run it in debugger again and get some values out of it? print plr print player_name(plr) print tr print plr-ai_common.traits print *plr-ai_common.traits[tr] ___ Reply to this item at: http://gna.org/bugs/?22180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4796] SDL_FillRectAlpha() - fill_rect_alpha()
URL: http://gna.org/patch/?4796 Summary: SDL_FillRectAlpha() - fill_rect_alpha() Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 02:42:43 AM EEST Category: client-sdl2 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Rename sdl2-client's SDL_FillRectAlpha() as fill_rect_alpha() to make clear it's not part of SDL like the old namespace suggested. As usual with sdl2-client, a lot of surrounding code has been cleaned coding style -wise. ___ File Attachments: --- Date: Fri 13 Jun 2014 02:42:43 AM EEST Name: FillRectAlpha.patch.bz2 Size: 18kB By: cazfi http://gna.org/patch/download.php?file_id=20989 ___ Reply to this item at: http://gna.org/patch/?4796 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4790] --enable-ruledit=test
Update of patch #4790 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4790 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22077] Brief snatch of opening music played when changing player during game
Update of bug #22077 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22077 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22183] Python files listed as source files
URL: http://gna.org/bugs/?22183 Summary: Python files listed as source files Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 03:28:08 AM EEST Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: We're not compiling anything from python scripts, so they should not be listed as source files. automake-ng gives an error about them. Fix attached. ___ File Attachments: --- Date: Fri 13 Jun 2014 03:28:08 AM EEST Name: PythonNotSource.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=20990 ___ Reply to this item at: http://gna.org/bugs/?22183 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22180] Server crashes after first turn in a new game.
Follow-up Comment #20, bug #22180 (project freeciv): Here are the requested values except tr which didn't seem to be available in the context I was in after the crash: (lldb) print plr (player *) $0 = 0x000102037200 (lldb) print player_name(plr) (const char *) $1 = 0x000102037208 Hattusilis (lldb) print tr error: use of undeclared identifier 'tr' error: 1 errors parsing expression (lldb) print plr-ai_common.traits (ai_trait *) $2 = 0x I also see this message when I start up the game after removing my ~/.freeciv directory: /fcgui -a Unable to find client executable: freeciv Searching for freeciv clients ... ... using ./client/freeciv-gtk3 Running ./client/freeciv-gtk3 2: Didn't find '.freeciv/freeciv-client-rc-2.6' option file, loading from '.freeciv-client-rc-2.4' instead. Is this a harmless message? ___ Reply to this item at: http://gna.org/bugs/?22180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4797] dai_find_source_building() to consider all unit related requirement types
URL: http://gna.org/patch/?4797 Summary: dai_find_source_building() to consider all unit related requirement types Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 05:02:55 AM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Currently dai_find_source_building() checks only VUT_UCLASS requirements for match of the potential attacker (or other unit affected) by the effect. Attached patch makes it to consider any unit related requirement types (class, type, type flag, class flag) by using is_req_active(). All the callers previously passing unit class were already actually interested about unit type, so now passing unit type as parameter (and thus getting also that type and type flag cases covered). Alternative move type -parameter dropped - the only remaining user have to live without it (may affect rulesets where defense building against sea or amphibious units is available before one against land units). ___ File Attachments: --- Date: Fri 13 Jun 2014 05:02:55 AM EEST Name: FindSrcBuildingReqTypes.patch Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20991 ___ Reply to this item at: http://gna.org/patch/?4797 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22180] Server crashes after first turn in a new game.
Follow-up Comment #21, bug #22180 (project freeciv): Is Hattusilis human or AI player? Obviously he has no traits allocated. There must be something special in how he gets created (as I cannot easily reproduce this crash). The message about using .freeciv-client-rc-2.4 just means that there's no client settings file saved with later version, so it migrates settings from there. ___ Reply to this item at: http://gna.org/bugs/?22180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4798] Always build defender before walls
URL: http://gna.org/patch/?4798 Summary: Always build defender before walls Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 05:18:42 AM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Quite often AI still has cities with city walls, but undefended when my attacker arrives. I think it's due to the fact that *before* I'm close, AI prefers to build City Walls (as the defender first is currently applied only in urgent situations) and even uses all its money to build them. When I then arrive, it has no time to build the defender, nor money to buy one. Attached patch makes AI to build defender before Walls even if there's no urgency. ___ File Attachments: --- Date: Fri 13 Jun 2014 05:18:42 AM EEST Name: FirstDefender.patch Size: 651B By: cazfi http://gna.org/patch/download.php?file_id=20992 ___ Reply to this item at: http://gna.org/patch/?4798 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4798] Always build defender before walls
Update of patch #4798 (project freeciv): Planned Release: 2.6.0 = 2.5.0, 2.6.0 ___ Reply to this item at: http://gna.org/patch/?4798 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4799] Unhardcode IgWall
URL: http://gna.org/patch/?4799 Summary: Unhardcode IgWall Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 05:46:54 AM EEST Category: general Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Attached patch removes IgWall unit type flag. It has never been very clean implementation in that it causes unit to ignore *any* kind of Defend_Bonus effects, with no way of ruleset author to affect that. Since we have UnitFlag requirement type and user defined unit type flags, it's much better to implement this kind of ruleset features as negated (not present) requirements for the defense bonus effects. In addition to removing the IgWall -flag from the engine, attached patch adds Howitzer user defined flag to rulesets having IgWall Howitzer. I'm going to change that to next version of the patch, though. As there's just one unit type where it applies, it's better to use UnitType requirement directly than UnitFlag. ___ File Attachments: --- Date: Fri 13 Jun 2014 05:46:54 AM EEST Name: IgWallRm.patch.bz2 Size: 6kB By: cazfi http://gna.org/patch/download.php?file_id=20993 ___ Reply to this item at: http://gna.org/patch/?4799 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4798] Always build defender before walls
Follow-up Comment #1, patch #4798 (project freeciv): Actually AI still builds Walls first if left completely alone. This patch only affects the situation where danger 0 but there's no urgency. Doesn't mean that patch wouldn't be step to right direction, so I'm still about to commit it. ___ Reply to this item at: http://gna.org/patch/?4798 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
