[Freeciv-Dev] [patch #5003] Requirers dialog

2014-07-30 Thread Marko Lindqvist
URL: Summary: Requirers dialog Project: Freeciv Submitted by: cazfi Submitted on: Thu 31 Jul 2014 04:24:50 AM EEST Category: freeciv-ruledit Priority: 5 - Normal

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-07-30 Thread Emmet Hikory
Follow-up Comment #4, patch #4759 (project freeciv): I like 2.99.99 : it makes the next step obvious to readers. ___ Reply to this item at: ___ Message sent via/

[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()

2014-07-30 Thread Marko Lindqvist
Update of bug #22216 (project freeciv): Assigned to: cazfi => pepeto ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #22330] civ2civ3 barbarian waste

2014-07-30 Thread Marko Lindqvist
Update of bug #22330 (project freeciv): Status:None => Ready For Test Assigned to:None => cazfi Planned Release: => 2.5.0, 2.6.0 _

[Freeciv-Dev] [bug #22273] Add action to the Unit UserData as a property and method

2014-07-30 Thread Jeffrey C. Jacobs
Follow-up Comment #5, bug #22273 (project freeciv): My fellow developers, I'm afraid I need your help again. I am trying to add a field for setting the unit's activity at the client level. I have code that checks a given activity value and then attempts to update the object. As far as I can tel

[Freeciv-Dev] [patch #4830] Multipliers to effects

2014-07-30 Thread Marko Lindqvist
Follow-up Comment #30, patch #4830 (project freeciv): > In multipliers.c: do multipliers, multiplier_count, and > multiplier_used need the "static" keyword? I had thought this > was necessary for persistent variables defined at file scope. Good catch. They should not be globals but limited to mod

[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread Marko Lindqvist
Follow-up Comment #2, bug #22404 (project freeciv): I see at least three ways one could argue to be the right way to do this. I don't have strong opinion about this. Do you want to implement the patch some certain way? If my original patch is to be used, it should be changed at least to initialize

[Freeciv-Dev] [bug #22378] Specialist name with space breaks savegames

2014-07-30 Thread Marko Lindqvist
Update of bug #22378 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #22399] Negative tech want for building effect

2014-07-30 Thread Marko Lindqvist
Update of bug #22399 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #22398] can_build_extra_base() has EC_BASE check reversed

2014-07-30 Thread Marko Lindqvist
Update of bug #22398 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-07-30 Thread Marko Lindqvist
Follow-up Comment #3, patch #4759 (project freeciv): As the version this development branch leads to is not freeciv-2.7 but freeciv-3.0, version number could be 2.99.0 or 2.99.99 (I prefer former, but need to check if our code assumes development version micro to be "99") instead of 2.6.99. - Min

[Freeciv-Dev] [patch #5002] Minimum libtool version 1.5.2

2014-07-30 Thread Marko Lindqvist
URL: Summary: Minimum libtool version 1.5.2 Project: Freeciv Submitted by: cazfi Submitted on: Wed 30 Jul 2014 07:54:04 PM EEST Category: bootstrap Priority: 5 - Normal

[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()

2014-07-30 Thread pepeto
Follow-up Comment #1, bug #22404 (project freeciv): IIRC, my original plan was to initialize this variable in the switch statement. case 0 should have "=" instead of "+=", and case 1,2,3,4 should have it initialized. Else, there is no sense to set it explicitly for the default case.

[Freeciv-Dev] [bug #22400] Stealing random and future tech don't work

2014-07-30 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, bug #22400 (project freeciv): New version attached. It ignores numbering. It merges the two if statements that validated tech target. _Your test looks a bit weak._ Correct. A new renumbering could have broken it. _What would happen if the tech is A_LAST? Or if the tech is o

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread Sveinung Kvilhaugsvik
Update of bug #22407 (project freeciv): Status:None => Duplicate Open/Closed:Open => Closed ___ Follow-up Comment #2: _This looks like bu

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread pepeto
Follow-up Comment #1, bug #22407 (project freeciv): This looks like bug #22346. ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org/ ___

[Freeciv-Dev] [bug #22407] Assertion failure while loading classic in Freeciv ruledit

2014-07-30 Thread Sveinung Kvilhaugsvik
URL: Summary: Assertion failure while loading classic in Freeciv ruledit Project: Freeciv Submitted by: sveinung Submitted on: Wed 30 Jul 2014 11:50:40 AM UTC Category: freeciv-ruledit

[Freeciv-Dev] [bug #22401] Freeciv ruledit stores appended requirements to action enablers

2014-07-30 Thread Sveinung Kvilhaugsvik
Update of bug #22401 (project freeciv): Category:None => freeciv-ruledit Status: Ready For Test => Fixed Open/Closed:Open => Closed _

[Freeciv-Dev] [patch #4996] Metaknowledge for Terrain, TerrainFlag, TerrainClass, Resource, Extra, BaseFlag and RoadFlag

2014-07-30 Thread Sveinung Kvilhaugsvik
Update of patch #4996 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22405] Base help & lack of happyborders

2014-07-30 Thread Marko Lindqvist
Update of bug #22405 (project freeciv): Status: In Progress => Ready For Test Planned Release: => 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #1: Fix (file #21592,