[Freeciv-Dev] [patch #5597] civ2civ3: achievements

2016-04-10 Thread Marko Lindqvist 
Follow-up Comment #4, patch #5597 (project freeciv):

Increase of the max achievement count -> patch #7097.

Since S2_6 formats have been frozen already, it can't be made before
freeciv-3.0.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7097] Increase max number of achievements to 40

2016-04-10 Thread Marko Lindqvist 
URL:
  

 Summary: Increase max number of achievements to 40
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 11 Apr 2016 08:14:46 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

As noted by David Fernandez  in patch #5597:
"There is a hardcoded limit of max 10 achievements, so I used only one of each
type (8 in total)."

That limit is rather low. Multiply it by 4 -> 40.




___

File Attachments:


---
Date: Mon 11 Apr 2016 08:14:46 AM EEST  Name: Achievements40.patch  Size: 1kB 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5597] civ2civ3: achievements

2016-04-10 Thread Marko Lindqvist 
Update of patch #5597 (project freeciv):

Category:None => rulesets   
 Planned Release: => 2.6.0, 3.0.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24046] dataio_json.c lacking many function headers

2016-04-10 Thread Marko Lindqvist 
Update of bug #24046 (project freeciv):

Category: general => freeciv-web


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24269] sg_load_map_tiles() has no function header

2016-04-10 Thread Marko Lindqvist 
Update of bug #24269 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 2.6.0-beta1, 3.0.0 

___

Follow-up Comment #1:

Not critical, but OTOH very easy -> let's clear these before any release so
that it won't get into forever-postponing loop.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24347] A quote mark in a server option string value can break it

2016-04-10 Thread Marko Lindqvist 
Update of bug #24347 (project freeciv):

 Planned Release: => 2.5.x, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24577] Editor tool_init() functions not called when ruleset changed / has ruleset specific part

2016-04-10 Thread Marko Lindqvist 
Update of bug #24577 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

Fix

(file #27083, file #27084)
___

Additional Item Attachment:

File name: ToolsByRuleset.patch   Size:4 KB
File name: ToolsByRuleset-S2_5.patch  Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24577] Editor tool_init() functions not called when ruleset changed / has ruleset specific part

2016-04-10 Thread Marko Lindqvist 
Update of bug #24577 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 2.5.4, 2.6.0, 3.0.0

___

Follow-up Comment #1:

S2_5 is also affected in a sense that tool used under one ruleset might have
been left to value so high that it's illegal under new ruleset.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7096] civ2civ3 - allow cities to claim tiles worked by enemy cities

2016-04-10 Thread David Fernandez 
URL:
  

 Summary: civ2civ3 - allow cities to claim tiles worked by
enemy cities
 Project: Freeciv
Submitted by: bardo
Submitted on: Mon 11 Apr 2016 01:19:06 AM UTC
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This patch sets a negative value to radius_sq_city_permanent = -5, that should
restore the old behavior before bug #23501 was fixed.

In my tests it allows large cities to steal all tiles from small enemy cities
(except the center tile). I like it this way to encourage border fights.



___

File Attachments:


---
Date: Mon 11 Apr 2016 01:19:06 AM UTC  Name: civ2civ3-claim_city_tiles-S2_6 
Size: 511B   By: bardo



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7095] Display real attack/defense values on middle click

2016-04-10 Thread David Fernandez 
URL:
  

 Summary: Display real attack/defense values on middle click
 Project: Freeciv
Submitted by: bardo
Submitted on: Mon 11 Apr 2016 12:38:30 AM UTC
Category: client
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

A wish requested by case81 in the forum:
http://forum.freeciv.org/f/viewtopic.php?f=13=652

My suggestion would be to display the final attack and defense values used to
calculate the "chance to win".
For example, middle-click could show the real attack/defense of the clicked
unit against the selected unit.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24368] Transported units not upgraded by Leonardo's Workshop

2016-04-10 Thread Marko Lindqvist 
Update of bug #24368 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6712] Cleanup editor extras handling packets

2016-04-10 Thread Marko Lindqvist 
Update of patch #6712 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24577] Editor tool_init() functions not called when ruleset changed / has ruleset specific part

2016-04-10 Thread Marko Lindqvist 
URL:
  

 Summary: Editor tool_init() functions not called when ruleset
changed / has ruleset specific part
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 10 Apr 2016 11:30:37 PM EEST
Category: editor
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

tool_init() for each tool is called only from editor_init(), which is
documented as
"This only needs to be done once at client start."
In S2_6/TRUNK the range of sensible values for ETT_TERRAIN_SPECIAL depends on
the ruleset, so the initialization value set based on one ruleset (or not
ruleset at all) may not be legal when another ruleset is being used.

My WIP solution for patch #6712 makes the overall problem much more serious.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

2016-04-10 Thread Marko Lindqvist 
Update of bug #19526 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

> Either the server shouldn't send the chat message, or the
> client should be more relaxed about receiving early chat
> messages (client_packet_input()), or possibly both.

Attached (untested) fix takes option 4; add a new packet type that that client
accepts early.
The reason I didn't want open it up for all chat messages is that there might
be game related chat messages coming to all connections that we shouldn't
really receive/handle before we are all set up for that game.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

2016-04-10 Thread Marko Lindqvist 
Additional Item Attachment, bug #19526 (project freeciv):

File name: EarlyChat.patchSize:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23790] Capital_City is evaluated on the client

2016-04-10 Thread Marko Lindqvist 
Follow-up Comment #3, bug #23790 (project freeciv):

Any progress on this?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7094] Save documentation comment about 'techs' format to ruleset

2016-04-10 Thread Marko Lindqvist 
URL:
  

 Summary: Save documentation comment about 'techs' format to
ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 10 Apr 2016 06:17:52 PM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

This is second of the "documentation comments about ruleset object type"
patches.
In patch #7090 I claimed that I won't make all of these as separate patches,
but at least this one contains many formatting changes to the "original"
comments in existing ruleset making it practical size patch this way.



___

File Attachments:


---
Date: Sun 10 Apr 2016 06:17:52 PM EEST  Name: RuleditTechsComment.patch.bz2 
Size: 4kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7090] Save documentation comment about 'buildings' format to ruleset

2016-04-10 Thread Marko Lindqvist 
Update of patch #7090 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6683] Floating point network representation

2016-04-10 Thread Marko Lindqvist 
Update of patch #6683 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 3.0.0  

___

Follow-up Comment #2:

> This ticket is not a blocker for S2_6.

So postponing.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7924] S2_6 network protocol freeze

2016-04-10 Thread Marko Lindqvist 
Update of task #7924 (project freeciv):

  Dependency Removed: => patch #6683


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7973] S3_0 network protocol freeze

2016-04-10 Thread Marko Lindqvist 
Update of task #7973 (project freeciv):

  Depends on: => patch #6683


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7924] S2_6 network protocol freeze

2016-04-10 Thread Marko Lindqvist 
Update of task #7924 (project freeciv):

  Dependency Removed: => patch #6907


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7973] S3_0 network protocol freeze

2016-04-10 Thread Marko Lindqvist 
Update of task #7973 (project freeciv):

  Depends on: => patch #6907


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7973] S3_0 network protocol freeze

2016-04-10 Thread Marko Lindqvist 
URL:
  

 Summary: S3_0 network protocol freeze
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 10 Apr 2016 04:24:10 PM EEST
 Should Start On: Sun 10 Apr 2016 12:00:00 AM EEST
   Should be Finished on: Sun 10 Apr 2016 12:00:00 AM EEST
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00
 Planned Release: 

___

Details:

Lesson learned from S3_0 freeze tickets:
Open the ticket early enough so that dependencies can be added there for
safekeeping from the beginning. Some very old issues, already postponed from
older releases to S2_6, were rediscovered only when S2_6 freeze was about to
happen.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6907] Network protocol support for "emergency" release version number part

2016-04-10 Thread Marko Lindqvist 
Update of patch #6907 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 3.0.0  

___

Follow-up Comment #1:

We can't expand initial packet containing the version number. So to implement
this we would need "extended versioning" mechanism. We would have no other use
for it in S2_6, so instead of introducing it in the late phase of this release
cycle, postpone all of this to 3.0.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7093] FC_STATIC_STRLEN configure test

2016-04-10 Thread Marko Lindqvist 
URL:
  

 Summary: FC_STATIC_STRLEN configure test
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 10 Apr 2016 03:56:04 PM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Add configure test to check if strlen() can be used in static assert under
certain conditions (namely those that apply to one such static assert we
currently have)
Define new macro FC_STATIC_STRLEN_ASSERT() like FC_C11_STATIC_ASSERT() or
empty depending if strlen() can be used that way. Change the relevant static
assert to use that new macro instead.

At least some versions of clang were choking to old code, but work with this
change.



___

File Attachments:


---
Date: Sun 10 Apr 2016 03:56:04 PM EEST  Name: StaticStrlen.patch  Size: 3kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24565] Indicator icon pixbufs not freed

2016-04-10 Thread Marko Lindqvist 
Update of bug #24565 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6987] Indicator icons as GtkImage

2016-04-10 Thread Marko Lindqvist 
Follow-up Comment #4, patch #6987 (project freeciv):

New S2_6 version:
- Updated against svn
- Fix for bug #24565 integrated to this patch


(file #27078)
___

Additional Item Attachment:

File name: ImageIndicatorIcons-S2_6-2.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24564] Ruleset choices list not freed

2016-04-10 Thread Marko Lindqvist 
Update of bug #24564 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24426] It is impossible to propose a non-root tech in diplomacy dialog when tech trading

2016-04-10 Thread Marko Lindqvist 
Update of bug #24426 (project freeciv):

 Planned Release: 2.5.4, 2.6.0, 3.0.0 => 2.5.x, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24539] Experimental: Big Land units unaffected by Sun Tzu's War Academy

2016-04-10 Thread Marko Lindqvist 
Update of bug #24539 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24567] configure tries to run qtpaths without checking if it exist

2016-04-10 Thread Marko Lindqvist 
Update of bug #24567 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24571] Player attribute block loading from a savegame fails

2016-04-10 Thread Marko Lindqvist 
Follow-up Comment #2, bug #24571 (project freeciv):

New TRUNK version of the patch that handles also loading of the savegame2.c
format savegames.

(file #27077)
___

Additional Item Attachment:

File name: UnquoteAcceptCorrectSize-2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23836] Autogames not reproducible because of turn change time value

2016-04-10 Thread Marko Lindqvist 
Update of bug #23836 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev