[Freeciv-Dev] Memory leaks in JSON protocol

[Andreas Røsdal]

Hi!

I have discovered some memory leaks in the JSON protocol in the Freeciv
server by running Valgrind on it, and created an issue here:
http://www.hostedredmine.com/issues/658181

We now have a 250-player LongTurn game running on Freeciv-web, where this
issue has an impact on memory usage. (The problem is worked-around by me
restarting that particuar server about once a week, but it would be nice to
fix the issue at the root-cause.)

Thanks in advance for any help with this. :)

Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25614] Rivers not displaying in freeciv-web when using included Civ2Civ3 ruleset

[Andreas Røsdal]

Update of bug #25614 (project freeciv):

  Status:None => Fixed  

___

Follow-up Comment #1:

This has been fixed in Freeciv-web now. EXTRA_* variables are now defined
dynamically.

Could you please give it a try and report if it is working correctly for you
now?

Sveinung: perhaps you can take a look at the commit, and see if it can be done
better?

This is the fix:
https://github.com/freeciv/freeciv-web/commit/858cc4c6ba9589bb26470253eb4b975a684591be

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Freeciv WebGL 3D Development Update

[Andreas Røsdal]

I have released a new version of Freeciv WebGL 3D to play.freeciv.org

The new release contains support for rendering borders and animated unit
movement.
Some more details about the release can be found here:
http://forum.freeciv.org/f/viewtopic.php?f=24=71874

The source code of Freeciv-web can be found here:
https://github.com/freeciv/freeciv-web

Andreas R.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Freeciv-web WebGL/Three.js prototype

[Andreas Røsdal]

Hi again everyone,

I have just released an update of the Freeciv-web 3D WebGL version to the
production server.
The updated version is able to render the 3d unit models from Cimpletoon
blender collection,
and it should be possible to play a complete game. There is still a lot to
do, though!

The 3D WebGL version can be tested here:  https://play.freeciv.org/  (click
the "Single-player 3D Beta" button).

More information can be found on the project Github page:
https://github.com/freeciv/freeciv-web

Andreas



2016-11-12 22:23 GMT+01:00 Andreas Røsdal <andreas.ros...@gmail.com>:

> Hello,
>
> We've been working on a 3D WebGL/Three.js prototype for Freeciv-web and
> the progress has been good so far. More information can be found here:
> http://forum.freeciv.org/f/viewtopic.php?f=24=39021
>
> The prototype can be tested here: https://play.freeciv.
> org/webclient/?action=new=webgl=true
>
> Andreas
>
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Freeciv-web WebGL/Three.js prototype

[Andreas Røsdal]

Hello,

We've been working on a 3D WebGL/Three.js prototype for Freeciv-web and
the progress has been good so far. More information can be found here:
http://forum.freeciv.org/f/viewtopic.php?f=24=39021

The prototype can be tested here:
https://play.freeciv.org/webclient/?action=new=webgl=true

Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25230] Some logs from Freeciv servers running Freeciv-web

[Andreas Røsdal]

URL:
  

 Summary: Some logs from Freeciv servers running Freeciv-web
 Project: Freeciv
Submitted by: andreasr
Submitted on: Tue 25 Oct 2016 06:36:17 PM UTC
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Here are some logs from running Freeciv servers for Freeciv-web on
play.freeciv.org. Since they are based on real usage of Freeciv in production,
I hope that they can be useful in perhaps finding some bugs in the Freeciv
server. There are lots of warnings which are suggested to be reported as
bugs.

Here are the logs:
https://play.freeciv.org/data/freeciv-logs.txt




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25199] Validate savegames for consistency before importing them

[Andreas Røsdal]

URL:
  

 Summary: Validate savegames for consistency before importing
them
 Project: Freeciv
Submitted by: andreasr
Submitted on: Tue 18 Oct 2016 01:56:49 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Please add validation of savegames for consistency before importing them into
the Freeciv C server.

This will make the Freeciv server more secure and prevent segfaults like the
one in Bug #25197.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25185] autogen.sh unable to detect Python on Ubuntu 16.10

[Andreas Røsdal]

Update of bug #25185 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25197] Segmentation fault in send_ruleset_control

[Andreas Røsdal]

Update of bug #25197 (project freeciv):

  Status:None => Invalid
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

I think I understand this problem now. Some Freeciv-web savegames became
corrupted because of a change I did to the Freeciv-web savegame handling a
couple of days ago. I have fixed the savegame issue in Freeciv-web now. I will
create a separate bugreport to request that the Freeciv C server validates
savegames before loading them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25197] Segmentation fault in send_ruleset_control

[Andreas Røsdal]

URL:
  

 Summary: Segmentation fault in send_ruleset_control
 Project: Freeciv
Submitted by: andreasr
Submitted on: Tue 18 Oct 2016 05:50:38 AM UTC
Category: general
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Segmentation fault in Freeciv-web, in the Freeciv C server.
SVN revision 34115. The crash occurs in about 2% of games.

Backtrace from core-dump:

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/home/freeciv/freeciv/bin/freeciv-web --debug=1 --port
6022 -q 20 --Announce no'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  __strncpy_sse2 (s1=0x7fffbcf2821f "", s2=0x1 , n=1466)
at ./strncpy.c:41
41  ./strncpy.c: No such file or directory.
(gdb) bt full
#0  __strncpy_sse2 (s1=0x7fffbcf2821f "", s2=0x1 , n=1466)
at ./strncpy.c:41
n4 = 366
c = 
s = 0x7fffbcf28220 "\377\377\377\377\377\377\377\377\r"
#1  0x0048625c in send_ruleset_control ()
No symbol table info available.
#2  0x0049966f in send_rulesets ()
No symbol table info available.
#3  0x00419a5c in load_command ()
No symbol table info available.
#4  0x0041bac0 in handle_stdin_input_real ()
No symbol table info available.
#5  0x004e2940 in handle_chat_msg_req ()
No symbol table info available.
#6  0x004739e8 in server_handle_packet ()
No symbol table info available.
#7  0x0040c534 in server_packet_input ()
No symbol table info available.
#8  0x004c3d9e in server_sniff_all_input ()
No symbol table info available.
#9  0x0040efdb in srv_main ()
No symbol table info available.
#10 0x0040713e in main ()
No symbol table info available.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25185] autogen.sh unable to detect Python on Ubuntu 16.10

[Andreas Røsdal]

URL:
  

 Summary: autogen.sh unable to detect Python on Ubuntu 16.10
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 15 Oct 2016 07:04:06 PM UTC
Category: bootstrap
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

autogen.sh is unable to detect Python on Ubuntu 16.10 and fails with this
error message:

+ checking for python ...
You must have python installed to compile freeciv.
Download the appropriate package for your distribution,
or get the source tarball at https://www.python.org/


On Ubuntu 16.10 there is a /usr/bin/python3.5 executable, but no
/usr/bin/python. 




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25170] Segmentation fault in map_distance_vector

[Andreas Røsdal]

URL:
  

 Summary: Segmentation fault in map_distance_vector
 Project: Freeciv
Submitted by: andreasr
Submitted on: Tue 11 Oct 2016 05:09:12 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

New type of segmentation fault in Freeciv-web with Freeciv C server svn
revision 34020.


Core was generated by `/home/freeciv/freeciv/bin/freeciv-web --debug=1 --port
6090 -q 20 --Announce no'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00547bb8 in map_distance_vector ()
(gdb) bt full
#0  0x00547bb8 in map_distance_vector ()
No symbol table info available.
#1  0x00547be9 in real_map_distance ()
No symbol table info available.
#2  0x00547c05 in is_tiles_adjacent ()
No symbol table info available.
#3  0x00550fbd in unit_move_to_tile_test ()
No symbol table info available.
#4  0x004ccb3f in expl_act_not_enabl ()
No symbol table info available.
#5  0x004ce14a in illegal_action_msg ()
No symbol table info available.
#6  0x004d2464 in unit_perform_action ()
No symbol table info available.
#7  0x004d3070 in handle_unit_do_action ()
No symbol table info available.
#8  0x00473698 in server_handle_packet ()
No symbol table info available.
#9  0x0040c98d in server_packet_input ()
No symbol table info available.
#10 0x004c3d2e in server_sniff_all_input ()
No symbol table info available.
#11 0x0040f6a5 in srv_main ()
No symbol table info available.
#12 0x0040713e in main ()
No symbol table info available.


Some debugging information is missing because the Freeciv server has been
compiled with -O3. I have recompiled and the next time I'll get more
information.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25134] Request for server-side CMA for Freeciv-web

[Andreas Røsdal]

URL:
  

 Summary: Request for server-side CMA for Freeciv-web
 Project: Freeciv
Submitted by: andreasr
Submitted on: Fri 30 Sep 2016 05:31:14 AM UTC
Category: freeciv-web
Severity: 1 - Wish
Priority: 4
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Hello!

Some users have requested CMA support for Freeciv-web.

Would it be possible to implement server-side CMA in the Freeciv C server? 

To make the API and protocol over JSON as simpe as possible, would it be
possible to let the Freeciv-web client just choose which CMA preset to use,
eg. "Max Food", "Max Science" etc.

Regards,
Andreas 




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Git branching model for Freeciv-web

[Andreas Røsdal]

Hello,

I would like to make a change to the git branching model for Freeciv-web.
The Freeciv-web git repo can be found here:
https://github.com/freeciv/freeciv-web

Today all development happens in the master branch in git and is released
from the master
branch to production when I have the chance to do it at random time
intervals. There are also some other feature-specific branches and the
testing branch currently.

I would like to change the branching model for Freeciv-web to have a master
branch and a develop branch. This is based on "A successful Git branching
model", more details here:
http://nvie.com/posts/a-successful-git-branching-model/

The master branch should be production-ready and will be deployed to the
production server every night automatically, if there are any git changes
and the tests pass.

The develop branch is where development of new features occurs. There can
also be other branches, which would be merged to the develop branch when
ready.

So in order to deploy to production, simply merge from develop to the
master branch,
and then the master branch will be deployed to production the coming night.

I will implement this change very soon if there are no objections.

Regards,
Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

[Andreas Røsdal]

Follow-up Comment #2, bug #24957 (project freeciv):

Yes, the patch has fixed this, based on 0 crashes in 614 games.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

[Andreas Røsdal]

URL:
  

 Summary: Segmentation faul in is_action_enabled.constprop 
 Project: Freeciv
Submitted by: andreasr
Submitted on: Wed 10 Aug 2016 07:44:41 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Freeciv-web is now has slightly more segmentation faults than normal (about 1%
of games now, it used to be about 0,1%). 
This is Freeciv server svn r33476.

This is a backtrace from a core-dump which was created on the most recent
segmentation fault:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0055be84 in is_action_enabled.constprop ()
(gdb) bt full
#0  0x0055be84 in is_action_enabled.constprop ()
No symbol table info available.
#1  0x0055e3cc in is_action_enabled_unit_on_city ()
No symbol table info available.
#2  0x004f26e1 in handle_unit_do_action ()
No symbol table info available.
#3  0x0048a8d8 in server_handle_packet ()
No symbol table info available.
#4  0x0040e96d in server_packet_input ()
No symbol table info available.
#5  0x004e2c5e in server_sniff_all_input ()
No symbol table info available.
#6  0x00411935 in srv_main ()
No symbol table info available.
#7  0x004084ce in main ()
No symbol table info available.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7522] AI always selling almost all buildings

[Andreas Røsdal]

Follow-up Comment #3, patch #7522 (project freeciv):

Also related to AI production: The AI seems to change the production in it's
cities almost every turn, never making a consistent decision about what to
build. For example switching between building barracks and library in a city
every other turn. This "flickering" between different production choices can
not be a good winning strategy.

This from the games that I have observed, most recently today with Freeciv-web
in production running Freeciv server svn r33324.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7507] Launch server by correct name in freeciv-web mode

[Andreas Røsdal]

Follow-up Comment #4, patch #7507 (project freeciv):

> Topology is not ruleset setting, but server setting. So you are saying that
freeciv-web should be able to use classic ruleset as it is, except for the
capability string?

Yes, I think so. Well, except for topology and arctic terrain coast tendering.
The diff between Fcweb and classic should be very small.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7507] Launch server by correct name in freeciv-web mode

[Andreas Røsdal]

Follow-up Comment #1, patch #7507 (project freeciv):

This is interesting!

About the Fcweb rulesets: Freeciv-web should be able to use the classic
rulesets, except that Freeciv-web doesn't support all map topoligies, and that
is doesn't support arctic coast tendering. If there was a different way to
negotiate map topology support than in the rulesets, then Freeciv-web could
use classic. Maintaining and updating Fcweb is costly.

What would a typical usage of this patch be? 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24825] fcweb observation

[Andreas Røsdal]

Follow-up Comment #1, bug #24825 (project freeciv):

Which version of Freeciv-manual are you using? I think you should build
Freeciv-manual from svn r32928 (same revision as fcweb in github is based
on).

fcweb is pretty much the same as the classic ruleset for most practical
purposes. There is no difference with the 'Cities' flag in units.ruleset which
is mentioned in the error message.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24741] Branches

[Andreas Røsdal]

Follow-up Comment #1, bug #24741 (project freeciv):

The Freeciv-web branch in svn can be deleted. Thanks for saying that
Freeciv-web is alive and kicking on github. 

https://github.com/freeciv/freeciv-web

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24668] "Username is null" after having closed the "Welcome" popup

[Andreas Røsdal]

Update of bug #24668 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

This has been fixed here now: 
https://github.com/freeciv/freeciv-web/commit/e1231dd2ff17cc78e439a2e4cec8dbf632feabbd

It will be pushed to production very soon.

Thanks for the bugreport!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7179] Initial patch for run-time language switching; low-level switch_lang()

[Andreas Røsdal]

Follow-up Comment #2, patch #7179 (project freeciv):

The network protocol also needs to be updated, so that the client can request
the correct language for the user upon connect.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7179] Initial patch for run-time language switching; low-level switch_lang()

[Andreas Røsdal]

Follow-up Comment #1, patch #7179 (project freeciv):

This will be very useful for Freeciv-web! Great!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

Update of bug #24524 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

Follow-up Comment #7, bug #24524 (project freeciv):

I can confirm that this problem has been fixed, and that the map generation
works correctly in Freeciv-web without the init_game_seed.patch. Great!

> I can't run entire freeciv-web machinery at the moment, though, but run just
the server & autogame on it.

I can help you get Freeciv-web running. Do you have some more details? 


Andreas

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

Follow-up Comment #5, bug #24524 (project freeciv):

It's great that you investigate this! Can you reproduce this in Freeciv-web
git master without the patch init_game_seed.patch?  
Has there been any changes in Freeciv-web server in svn in the few revisions
which has been updated in Freeciv-web? I will test once I get the chance, but
I don't think this has been fixed. The problem used to occur in my system, as
well as in production.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

Follow-up Comment #3, bug #24524 (project freeciv):

It seems that in init_game_seed(), that game.server.seed is always 26479 when
that function is called (game.server.seed should be 0 there).

I have created a very primitive workaround here:
https://github.com/freeciv/freeciv-web/commit/ebe143a793c0d6dfe1e68f890a873991bfc38dc9

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

Follow-up Comment #2, bug #24524 (project freeciv):

All savegames have the same mapseed setting, like this:
"mapseed",153977005,153977005

There is no map.random_seed.

Attaching a savegame.

(file #26996)
___

Additional Item Attachment:

File name: test.sav.xzSize:11 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24524] Freeciv-web server generates the same map for each new game

[Andreas Røsdal]

URL:
  

 Summary: Freeciv-web server generates the same map for each
new game
 Project: Freeciv
Submitted by: andreasr
Submitted on: Tue 15 Mar 2016 07:18:15 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

In Freeciv-web the map generator creates the exact same map for each new game.
This is with Freeciv server svn revision 30871.
The problem is not reproducible in the regular desktop Freeciv server and
clients. 
Any advice about how to debug and solve this? I don't think Freeciv-web has
any special mapseed configuration. Could it be related to the fcweb ruleset,
or some other configuration in Freeciv-web?




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24430] freeciv-web uses civ2civ3 tutorial scenario with fcweb ruleset

[Andreas Røsdal]

Follow-up Comment #1, bug #24430 (project freeciv):

Good observation. How do you suggest we fix this? 

At some point it would be nice if Freeciv-web supported the same rulesets as
Freeciv. 

Perhaps in the short-term, then both Freeciv-web and Freeciv should use
civ2civ3 as default?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24418] Global warming crashes Freeciv server

[Andreas Røsdal]

Follow-up Comment #2, bug #24418 (project freeciv):

OK. Possibly json protocol related?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Installation Issues

[Andreas Røsdal]

Hello Matthew

Note that vagrant is used to build Freeciv-web, which is the browser-based
version of Freeciv, playable on https://play.freeciv.org/  Freeciv-web is
also the most used version of Freeciv. If you wanted to build the desktop
version, then there is another way to do that.

Can you please attach the full output og the vagrant up command?

Which version of Vagrant and Virtualbox are you using? Is it the latest
version?

What operating system are you using?

Have you enabled virtualization in your BIOS?

Regards
Andreas
15. feb. 2016 1.58 p.m. skrev "Matthew Martin" :

Hello,

I'm not sure if this is the correct method of asking you guys for
assistance, if there's a more appropriate forum or contact info to use
please let me know.

I'm trying to contribute to the freeciv project and have followed the
installation instructions for developing on  a vagrant box. However, once I
get to the "vagrant up" command, it won't allow me to ssh into the box,
instead timing out and repeating the message:

 default: Warning: Connection timeout. Retrying...

A cursory search suggested I enable VirtualBox's GUI in order to see if it
was awaiting user input, but the screen remains blank. If there's any
solution you could suggest I'd love to hear it, and again I apologize if
this isn't the correct way to contact you with such issues.

Thanks,
Matt

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24343] Segmentation fault in send_packet_tile_info_100 -> dio_put_memory_json

[Andreas Røsdal]

URL:
  

 Summary: Segmentation fault in send_packet_tile_info_100 ->
dio_put_memory_json
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sun 24 Jan 2016 05:40:46 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Hi!  

I'm getting a segmentation fault in Freeciv-web, in the Freeciv C server. This
is from production with Freeciv svn revision 30535.
The crash seems to be in hashtable.c called from dio_put_memory_json and
send_packet_tile_info_100 and update_environmental_upset.

Here is the backtrace from the core dump:

Core was generated by `freeciv-web --debug=1 --port 6023 -q 20 --Announce none
- 
 e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  bucket_is_empty (bucket=bucket@entry=0xf0, hashtable=0x7f54b8030140,
hashtable@entry=0x66403e) at hashtable.c:57
57  hashtable.c: No such file or directory.
Traceback (most recent call last):
  File
"/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gd 
  
  b.py", line 63, in 
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt full
#0  bucket_is_empty (bucket=bucket@entry=0xf0, hashtable=0x7f54b8030140,
hashtable@entry=0x66403e) at hashtable.c:57
No locals.
#1  hashtable_find_pair (hashtable=hashtable@entry=0x7f54b8030140,
bucket=bucket@entry=0xf0, key=key@entry=0x66403e "extras",
hash=hash@entry=1046743727) at hashtable.c:81
list = 
pair = 
#2  0x7f54c63ef7c0 in hashtable_set (hashtable=0x7f54b8030140,
key=0x66403e "extras", serial=9, value=value@entry=0x7f54bbfffee0)
at hashtable.c:225
pair = 
bucket = 0xf0
hash = 1046743727
index = 15
#3  0x7f54c63f4556 in json_object_set_new_nocheck (json=,
key=, value=0x7f54bbfffee0) at value.c:118
object = 
#4  0x0060e84f in dio_put_memory_json ()
No symbol table info available.
#5  0x00591ec0 in send_packet_tile_info_100 ()
No symbol table info available.
#6  0x0048940e in send_tile_info.part.7.constprop ()
No symbol table info available.
#7  0x0048e29e in check_terrain_change ()
No symbol table info available.
#8  0x0048e717 in climate_change ()
No symbol table info available.
#9  0x0048e782 in global_warming ()
No symbol table info available.
#10 0x0040ca28 in update_environmental_upset ()
No symbol table info available.
#11 0x0041277e in srv_main ()
No symbol table info available.
#12 0x00407e89 in main ()
No symbol table info available.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Andreas Røsdal]

URL:
  

 Summary: Freeciv-web server using max cpu
 Project: Freeciv
Submitted by: andreasr
Submitted on: Thu 14 Jan 2016 10:42:45 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

In the current version of Freeciv-web, sometimes the Freeciv C server begins
using 100% CPU and several gigabytes of memory. This is with Freeciv server
svn revision 30535.

Here is a backtrace from attaching to such as process:

(gdb) bt full
#0  utf8_check_string (string=string@entry=0x7ffef2285ec0 "You can't modify your spaceship after launch!",
length=length@entry=74) at utf.c:174
count = 1
i = 62
#1  0x7f059f346e96 in json_stringn (value=0x7ffef2285ec0 "You can't modify your spaceship after launch!",
len=74) at value.c:699
No locals.
#2  0x0060ea82 in dio_put_string_json ()
No symbol table info available.
#3  0x00589f89 in send_packet_chat_msg_100 ()
No symbol table info available.
#4  0x004092d8 in notify_conn_packet ()
No symbol table info available.
#5  0x00409a19 in notify_player ()
No symbol table info available.
#6  0x00433714 in adv_spaceship_autoplace ()
No symbol table info available.
#7  0x0041156b in srv_main ()
No symbol table info available.
#8  0x00407e89 in main ()
No symbol table info available.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Andreas Røsdal]

Follow-up Comment #2, bug #24309 (project freeciv):

Thanks! Pushed to production.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5936] Play By Email for Freeciv-web

[Andreas Røsdal]

Update of patch #5936 (project freeciv):

  Status: In Progress => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Freeciv-web now has Play-By-EMail support in production. 

If anyone has any feedback on it that would be nice.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

[Andreas Røsdal]

> Are the AI players unusually slow for the number of units and cities they
have?

I think the AI is unusually slow in this scenario. At the moment the Europe
1901 is not usable on the production server.
Possibly the AI will have to behave differently with a very large number of
cities and units, for example perform less calculations for each unit if
the number of units is above some threshold value.


Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

[Andreas Røsdal]

Follow-up Comment #1, bug #24018 (project freeciv):

Yes, I can confirm that this is the issue with Freeciv-web as well. 
The freeciv server process is running at 100% CPU usage.
Attaching a backtrace generated with gdb when attatching to such a process.

(file #25582)
___

Additional Item Attachment:

File name: freeciv-europe.txt Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24008] Building server only now requires sdl

[Andreas Røsdal]

URL:
  

 Summary: Building server only now requires sdl
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sun 01 Nov 2015 09:19:42 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Building only the Freeciv server (as Freeciv-web does), now requires SDL:

https://travis-ci.org/freeciv/freeciv-web/builds/88309075

+ running autoconf ... 
configure:24004: error: possibly undefined macro: AM_PATH_SDL
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24008] Building server only now requires sdl

[Andreas Røsdal]

Update of bug #24008 (project freeciv):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Yes, sorry..

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

[Andreas Røsdal]

Follow-up Comment #2, bug #23966 (project freeciv):

Attaching a savegame where this crash can be reproduced.

(file #25495)
___

Additional Item Attachment:

File name: lambrus.sav.xz Size:299 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

[Andreas Røsdal]

Follow-up Comment #4, bug #23966 (project freeciv):

>Does freeciv-web in production have bug #23891 fixed?

No. So this seems to be a very likely cause. Thanks!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

[Andreas Røsdal]

Follow-up Comment #1, bug #23966 (project freeciv):

bt full
#0  __strncpy_sse2 (s1=0x7ffcd2647aff "", s1@entry=0x7ffcd2647b00 "",
    s2=0x1 , n=n@entry=47)
    at ./strncpy.c:41
    n4 = 11
    c = 
    s = 0x7ffcd2647b00 ""
#1  0x7f0f3722dfba in __strncpy_chk (s1=s1@entry=0x7ffcd2647b00 "",
    s2=, n=n@entry=47, s1len=s1len@entry=4076) at
strncpy_chk.c:32
No locals.
#2  0x0047e08d in strncpy (__len=, __src=,
    __dest=0x7ffcd2647b00 "") at
/usr/include/x86_64-linux-gnu/bits/string3.h:120
No locals.
#3  send_ruleset_control (dest=dest@entry=0x2538470) at ruleset.c:3512
    part = {
  text =
"\000\000\000\000\000\000\000\000`{d\322\374\177\000\000\377\377\377\377\377\377\377\377\016",
'\000' , "
\000\000\000\000\000\000\000\000\000Ёd\322\374\177\000\000uta\000\000\000\000\000\002\000\000\000\000\000\000\000\020\000\000\000\"#FFyta\000\000\000\000\000*5
has been removed from the
game.\000APd\000\000\000`\202d\322\374\177\000\000
\204d\322\374\177\000\000`\202d\322\374\177\000\000W\205^\000\000\000\000\000\b\204d\322\374\177\000\000\001\000\000\000\000\000\000\000\377\003\000\000\000\000\000\000\030\000\000\000\060\000\000\000І"...}
    this_len = 
    packet = {num_unit_classes = 0, num_unit_types = 0,
num_impr_types = 0,
  num_tech_types = 0, num_extra_types = 14, num_base_types =
0,
  num_road_types = 0, num_goods_types = 1, num_disaster_types
= 0,
  num_achievement_types = 0, num_multipliers = 0, num_styles
= 0,
  num_music_styles = 0, government_count = 0, nation_count =
0,
  styles_count = 0, terrain_count = 0, resource_count = 0,
  num_specialist_types = 0, prefered_tileset = '\000'
,
  prefered_soundset = '\000' ,
  prefered_musicset = '\000' ,
popup_tech_help = false,
  name = "Web-default", '\000' ,
  version = '\000' , desc_length = 47}
    desc_left = 
    index = 0
#4  0x00490d21 in send_rulesets (dest=0x2538470) at ruleset.c:7176
No locals.
#5  0x00418527 in load_command (
    caller=caller@entry=0x87a560 ,
    filename=filename@entry=0x7ffcd264b1e0 "JLV", check=check@entry=false)
    at stdinhand.c:3662
    loadtimer = 0x6efde80
    uloadtimer = 0x33ac6a0
    file = 0x25f42b0
    arg =
"/home/freeciv/freeciv-web/freeciv-web/resin/webapps/ROOT/savegames/JLV.sav.xz",
'\000' ,
"I\a\032\067\017\177\000\000p\223d\322\374\177\000\000`\223d\322\374\177\000\000)0\027\067\017\177\000\000\071\341]\000\000\000\000\000\020\341]\000\000\000\000\000\352\364\026\067\017\177",
'\000' ...
    __FUNCTION__ = "load_command"
#6  0x0041ab2c in handle_stdin_input_real (
    caller=caller@entry=0x87a560 , str=,
    str@entry=0x7ffcd264bd00 "/load JLV", check=check@entry=false,
    read_recursion=read_recursion@entry=0) at stdinhand.c:4229
    full_command = "load JLV", '\000' ,
"\377\377\377\377\377\377\377\377", '\000' , "
\000\000\000\000\000\000\000\000\000N\000\000\000\374\177", '\000' , "\001\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377N",
'\000' , "\374\177
\000\000\000\000\000\000\000\000\000`\260d\322\374\177\000\000cy`\000\000\000\000\000\002\000\000\000\000\000\000\000O\000\000\000\017\177\000\000fy`",
'\000' ...
    command =
"load\000\000\000\000\300V\031\004\000\000\000\000\000\020\000\000\000\000\000\000\006)\031\067\017\177\000\000\020\000\000\000\000\000\000\000i%\000\000\000\000\000\000\001\000\000\000\000\000\000\000\244\201",
'\000' ,
"\372\000\000\000\000\000\000\000\000\020\000\000\000\000\000\000\b\000\000\000\000\000\000\000\252\312)V\000\000\000\000\b\302>8\000\000\000\000)y(V\000\000\000\000\340\201\321\b\000\000\000\000)y(V\000\000\000\000\340\223K\t",
'\000' ,
"\300V\031\004\000\000\000\000\n\000\000\000\000\000\000\000\000+Freeci"...---Type
 to continue, or q  to quit---

    arg = "JLV", '\000' ,
"\340\263d\322\374\177\000\000P\262d\322\374\177\000\000\340\223Z\002\000\000\000\000p\224Z\002\000\000\000\000search
your-server.de\n\000\061\060\060\n\000BY HAND -- YOUR CHANGES WILL BE
OVERWRITTEN\n\000nf(8)\n\000|\000\000\000\374\177\000\000\300\225Z\002\000\000\000\000\200\224Z\002\000\000\000\000@Dž0\017\177\000\000`\264d\322\374\177\000\000\200\265d\322\374\177\000\000\000\024[\002\000\000\000\000)\333\024\067\017\177\000\000\000challeng"...
    cptr_s = 
    cptr_d = 
    cmd = CMD_LOAD
    level = 
    __FUNCTION__ = "handle_stdin_input_real"
#7  0x0041d199 in handle_stdin_input (
    caller=caller@entry=0x87a560 ,
    str=str@entry=0x7ffcd264bd00 "/load JLV") at stdinhand.c:4028
No locals.
#8  0x004c1e00 in handle_chat_msg_req (
    pconn=pconn@entry=0x87a560 , message=)
    at handchat.c:343
    real_message = "/load JLV", '\000' ,

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

[Andreas Røsdal]

URL:
  

 Summary: Segfault when loading in Freeciv web
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 24 Oct 2015 11:07:49 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The following segfault occurs regularly when loading å game in Freeciv web:




pplayer = 
__FUNCTION__ = "server_packet_input"
#11 0x004a624e in incoming_client_packets (pconn=)
at sernet.c:460
command_ok = 
packet = {data = 0x25f6c60, type = PACKET_CHAT_MSG_REQ}
#12 server_sniff_all_input () at sernet.c:856
pconn = 0x87a560 
nb = 
i = 
s = 
max_desc = 
readfs = {fds_bits = {64, 0 }}
writefs = {fds_bits = {0 }}
exceptfs = {fds_bits = {0 }}
tv = {tv_sec = 0, tv_usec = 17389}
__FUNCTION__ = "server_sniff_all_input"
#13 0x0040e5cd in srv_main () at srv_main.c:3187
__FUNCTION__ = "srv_main"
#14 0x00406c19 in main (argc=20, argv=0x7ffcd264ed18) at
civserver.c:459
inx = 20
showhelp = 
showvers = 
option = 
__FUNCTION__ = "main"




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23884] Some segmentation faults seen in production

[Andreas Røsdal]

Follow-up Comment #2, bug #23884 (project freeciv):

Thanks! Pushed to production.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23887] command crashes server

[Andreas Røsdal]

URL:
  

 Summary: command crashes server
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 19 Sep 2015 10:40:23 PM UTC
Category: general
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The following command will cause a segmentation fault in the current
Freeciv-web server:

/set reveal map start

Backtrace here:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  __GI___libc_free (mem=0x686374616d206f4e) at malloc.c:2929
2929malloc.c: No such file or directory.
Traceback (most recent call last):
  File
"/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py",
line 63, in 
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt full
#0  __GI___libc_free (mem=0x686374616d206f4e) at malloc.c:2929
ar_ptr = 
p = 
hook = 0x0
#1  0x0059f716 in free_tokens (tokens=tokens@entry=0x7fffb99157e0,
ntokens=ntokens@entry=3) at shared.c:334
i = 2
#2  0x00413d6d in set_command (
caller=caller@entry=0x87a560 ,
str=str@entry=0x7fffb99164f0 "reveal map start", check=check@entry=false)
at stdinhand.c:2975
args = {0xeb8e30 "\340", ,
  0xeb5c20 " \216", }
val = 119
cmd = 
nargs = 3
pset = 
do_update = 
reject_msg = "No match for \"map\".", '\000' 
ret = false
#3  0x0041a060 in handle_stdin_input_real (
caller=caller@entry=0x87a560 , str=,
str@entry=0x7fffb9917010 "/set reveal map start",
check=check@entry=false,
---Type  to continue, or q  to quit---
read_recursion=read_recursion@entry=0) at stdinhand.c:4277
full_command = "set reveal map start", '\000' ,
"\377\377\377\377\377\377\377\377", '\000' , "
\000\000\000\000\000\000\000\000\000N\000\000\000\377\177", '\000' , "\001\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377N",
'\000' , "\377\177
\000\000\000\000\000\000\000\000\000pc\221\271\377\177\000\000cz`\000\000\000\000\000\002\000\000\000\000\000\000\000O\000\000\000v\177\000\000fz`",
'\000' ...
command =
"set\000\000\000\000\000P\353\244\002\000\000\000\000\000\020\000\000\000\000\000\000\006\311\324\377v\177\000\000\020\000\000\000\000\000\000\000\274%\000\000\000\000\000\000\001\000\000\000\000\000\000\000\244\201",
'\000' ,
"\372\000\000\000\000\000\000\000\000\020\000\000\000\000\000\000\b\000\000\000\000\000\000\000*\223\375U\000\000\000\000\340\034U\034\000\000\000\000\252A\374U\000\000\000\000È\216+\000\000\000\000\252A\374U\000\000\000\000È\216+",
'\000' ,
"P\353\244\002\000\000\000\000\n\000\000\000\000\000\000\000\000+Freeciv."...
arg = "reveal map
start\000f\221\271\377\177\000\000`e\221\271\377\177\000\000`\236\346\000\000\000\000\000\360\236\346\000\000\000\000\000search
your-server.de\n\000\061\060\060\n\000BY HAND -- YOUR CHANGES WILL BE
OVERWRITTEN\n\000nf(8)\n\000|\000\000\000\377\177\000\000@\240\346\000\000\000\000\000\000\237\346\000\000\000\000\000@gA\371v\177\000\000pg\221\271\377\177\000\000\220h\221\271\377\177\000\000\200\036\347\000\000\000\000\000){\320\377v\177\000\000\000challen"...
---Type  to continue, or q  to quit---
cptr_s = 
cptr_d = 
cmd = CMD_SET
level = 
__FUNCTION__ = "handle_stdin_input_real"
#4  0x0041d199 in handle_stdin_input (
caller=caller@entry=0x87a560 ,
str=str@entry=0x7fffb9917010 "/set reveal map start") at stdinhand.c:4028
No locals.
#5  0x004c1e40 in handle_chat_msg_req (
pconn=pconn@entry=0x87a560 , message=)
at handchat.c:343
real_message = "/set reveal map start", '\000' ,
"\024\213\354\000w\177\000\000\016\224\337\000\000\000\000\000\020\222\337\000\000\000\000\000\016\224\337\000\377\000\000\000\024\213\354\000w\177\000\000\016\224\337\000\000\000\000\000\020\222\337\000\000\000\000\000\000\000\000\000\377\000\000\000Dq\221\271\377\177\000\000\276Q\207\000\000\000\000\000\362Q\207\000\000\000\000\000\370p`\000\000\000\000\000"...
cp = 
double_colon = 
#6  0x0046f418 in server_handle_packet (
type=type@entry=PACKET_CHAT_MSG_REQ, packet=,
pplayer=pplayer@entry=0x0, pconn=pconn@entry=0x87a560 )
---Type  to continue, or q  to quit---
at hand_gen.c:40
No locals.
#7  0x0040c008 in server_packet_input (
pconn=pconn@entry=0x87a560 , packet=,
type=26)
at srv_main.c:1884
pplayer = 
__FUNCTION__ = "server_packet_input"
#8  0x004a62be in incoming_client_packets (pconn=)
at sernet.c:460
   

[Freeciv-Dev] [bug #23884] Some segmentation faults seen in production

[Andreas Røsdal]

URL:
  

 Summary: Some segmentation faults seen in production
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 19 Sep 2015 07:10:26 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I'm seeing a slight increase in the number of crashes in production with the
current Freeciv server running on play.freeciv.org. This is running SVN
revision 29829 of the Freeciv server.

I'm attaching backtraces from three separate segmentation faults seen in
production on Freeciv-web.

I have added a quick-fix to try to temporarily fix these crashes here:
https://github.com/freeciv/freeciv-web/commit/fb7de683581b7830160ad96a46998a3c7a3cd799



___

File Attachments:


---
Date: Sat 19 Sep 2015 07:10:26 AM UTC  Name: segfault1.txt  Size: 3kB   By:
andreasr


---
Date: Sat 19 Sep 2015 07:10:26 AM UTC  Name: segfault2.txt  Size: 3kB   By:
andreasr


---
Date: Sat 19 Sep 2015 07:10:26 AM UTC  Name: segfault3.txt  Size: 3kB   By:
andreasr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23880] First goto always fails

[Andreas Røsdal]

Update of bug #23880 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Thanks å lot for the fix!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23842] The tests will randomly fail

[Andreas Røsdal]

Update of bug #23842 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23842] The tests will randomly fail

[Andreas Røsdal]

Follow-up Comment #2, bug #23842 (project freeciv):

The timeouts have been increased. Do you still get this problem?

https://github.com/freeciv/freeciv-web/commit/7adc53eb29da0a7cec0774ca879982f80a152c12

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23842] The tests will randomly fail

[Andreas Røsdal]

Follow-up Comment #1, bug #23842 (project freeciv):

Yes, this can be improved, the timeout limit for some of the tests needs to be
increased, so that the tests works regardless of CPU speed.

The tests can be found here:
https://github.com/freeciv/freeciv-web/blob/master/tests/freeciv-web-tests.js

When the tests are run on Travis-CI the tests works pretty consistently. 

Do all tests fail randomly, or just some of them fail randomly?

https://casperjs.readthedocs.org/en/latest/modules/

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23835] City names with special characters are not accepted as valid

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23835

 Summary: City names with special characters are not accepted
as valid
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 29 Aug 2015 09:26:42 PM UTC
Category: freeciv-web
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

In the most recent version of Freeciv-web, city names with special characters,
eg single-quote ', are not accepted as valid. This is related to patch #6296.

For example, start a new game as the Guarani nation, and try to build a new
city. You will then get a suggested city name as 'Akã'. Using this suggested
city name will give an error message: Akã is not a valid name. Only ASCII or
ruleset names are allowed for cities.

The real city name is Akã'ai from guarani.ruleset file. 




___

Reply to this item at:

  http://gna.org/bugs/?23835

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6295] JSON protocol: support URI encoded strings

[Andreas Røsdal]

Follow-up Comment #1, patch #6295 (project freeciv):

Looks good, I support this change very much!

___

Reply to this item at:

  http://gna.org/patch/?6295

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23764] Loading savegame reveals hidden cities

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23764

 Summary: Loading savegame reveals hidden cities
 Project: Freeciv
Submitted by: andreasr
Submitted on: Fri 07 Aug 2015 05:20:30 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Loading savegame reveals cities which are hidden by fog-of-war.
This was observed by Nook on his Let's Play Freeciv Youtube video,
when loading the game for part 9 here:

Part 8: https://www.youtube.com/watch?v=JWH77zxtbr8
Part 9: https://www.youtube.com/watch?v=IQlHb5yQ18s




___

Reply to this item at:

  http://gna.org/bugs/?23764

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6154] Suggestion: Development version specific savegame compatibility

[Andreas Røsdal]

Follow-up Comment #1, patch #6154 (project freeciv):

Good suggestion!

___

Reply to this item at:

  http://gna.org/patch/?6154

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23707] Segmentation fault in style_of_nation in nation.c:654

[Andreas Røsdal]

Update of bug #23707 (project freeciv):

  Status:None = Invalid
 Open/Closed:Open = Closed 

___

Follow-up Comment #2:

This segmentation fault doesn't happen any more. It was most likely caused by
the new Freeciv server loading savegames from an older server revision.
Closing.

___

Reply to this item at:

  http://gna.org/bugs/?23707

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

Follow-up Comment #2, bug #23708 (project freeciv):

This patch has resolved the segmentation faults for the Freeciv server running
on Freeciv-web production server:

https://github.com/freeciv/freeciv-web/blob/91b6b810d25f16a4464b7f2b8ab46e5dd203849f/freeciv/patches/city_traderoute_hotfix.patch

It is not a proper fix, just a short-term solution to prevent the server from
crashing. 

___

Reply to this item at:

  http://gna.org/bugs/?23708

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #23707] Segmentation fault in style_of_nation in nation.c:654

[Andreas Røsdal]

 Do you have the logs for a game that crashed? I'm interested in assertion
failures.

This could be a log from this server, but I'm not really sure (it is the
log file from servers running on that port).
http://play.freeciv.org/freeciv-web-log-6043.log

 Do you have a way of seeing what settings the game was played with? Did
the
 player pick a nation for himself or was it randomly assigned?

No, I don't think that information is logged in production.

Andreas


2015-07-22 19:55 GMT+02:00 Sveinung Kvilhaugsvik 
no-reply.invalid-addr...@gna.org:

 Follow-up Comment #1, bug #23707 (project freeciv):

 Do you have the logs for a game that crashed? I'm interested in assertion
 failures.

 Do you have a way of seeing what settings the game was played with? Did the
 player pick a nation for himself or was it randomly assigned?

 ___

 Reply to this item at:

   http://gna.org/bugs/?23707

 ___
   Message sent via/by Gna!
   http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23707] Segmentation fault in style_of_nation in nation.c:654

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23707

 Summary: Segmentation fault in style_of_nation in
nation.c:654
 Project: Freeciv
Submitted by: andreasr
Submitted on: Wed 22 Jul 2015 05:13:32 PM UTC
Category: general
Severity: 5 - Blocker
Priority: 7 - High
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I frequently get segmentation faults in style_of_nation() in nation.c, on the
current production server for Freeciv-web. I pushed the current github master
version to production today, which is based on the Freeciv server svn revision
29233 (trunk).  The error occurs in about 6% of all games on startup.

Here is a backtrace generated from a core dump:

Core was generated by `freeciv-web --debug=1 --port 6043 -q 20 --Announce none
-e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  style_of_nation (pnation=pnation@entry=0x0) at nation.c:654
654 nation.c: No such file or directory.
Traceback (most recent call last):
  File
/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py,
line 63, in module
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt full
#0  style_of_nation (pnation=pnation@entry=0x0) at nation.c:654
No locals.
#1  0x0040bdda in player_nation_defaults
(pplayer=pplayer@entry=0x27e4180, pnation=0x0,
set_name=optimized out) at srv_main.c:2220
pleader = optimized out
#2  0x0040cafa in player_set_nation_full (pnation=optimized out,
pplayer=0x27e4180) at srv_main.c:2205
No locals.
#3  generate_players () at srv_main.c:2411
pnation = optimized out
pplayer = 0x27e4180
_pslot = 0x3fff750
needs_startpos = false
nations_to_assign = optimized out
#4  srv_ready () at srv_main.c:2792
__FUNCTION__ = srv_ready
#5  0x0040d3e0 in srv_main () at srv_main.c:3101
__FUNCTION__ = srv_main
#6  0x00405aa9 in main (argc=20, argv=0x78228868) at
civserver.c:459
inx = 20
showhelp = optimized out
showvers = optimized out
option = optimized out
__FUNCTION__ = main





___

Reply to this item at:

  http://gna.org/bugs/?23707

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #23707] Segmentation fault in style_of_nation in nation.c:654

[Andreas Røsdal]

Here's a relevant log file:
http://play.freeciv.org/freeciv-web-log-6033.log

I rebuilt the servers with debugging enabled, and now this can be found in
the logs:

1: in generate_players() [srv_main.c::2410]: assertion 'pnation !=
NO_NATION_SELECTED' failed.
1: in generate_players() [srv_main.c::2410]: Please report this
message at http://gna.org/projects/freeciv/
1: in player_nation_defaults() [srv_main.c::2216]: assertion
'NO_NATION_SELECTED != pnation' failed.



Andreas



2015-07-22 20:07 GMT+02:00 Andreas Røsdal andreas.ros...@gmail.com:

  Do you have the logs for a game that crashed? I'm interested in assertion
 failures.

 This could be a log from this server, but I'm not really sure (it is the
 log file from servers running on that port).
 http://play.freeciv.org/freeciv-web-log-6043.log

  Do you have a way of seeing what settings the game was played with? Did
 the
  player pick a nation for himself or was it randomly assigned?

 No, I don't think that information is logged in production.

 Andreas


 2015-07-22 19:55 GMT+02:00 Sveinung Kvilhaugsvik 
 no-reply.invalid-addr...@gna.org:

 Follow-up Comment #1, bug #23707 (project freeciv):

 Do you have the logs for a game that crashed? I'm interested in assertion
 failures.

 Do you have a way of seeing what settings the game was played with? Did
 the
 player pick a nation for himself or was it randomly assigned?

 ___

 Reply to this item at:

   http://gna.org/bugs/?23707

 ___
   Message sent via/by Gna!
   http://gna.org/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23708

 Summary: Segmentation fault in cities_trade_route_type
 Project: Freeciv
Submitted by: andreasr
Submitted on: Wed 22 Jul 2015 07:59:59 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The following segmentation fault occurred in the Freeciv server of Freeciv-web
today.  I pushed the current github master version to production today, which
is based on the Freeciv server svn revision 29233 (trunk).


Core was generated by `freeciv-web --debug=1 --port 6029 -q 20 --Announce none
-e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
1074  return pcity-tile;
Traceback (most recent call last):
  File
/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py,
line 63, in module
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt full
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
No locals.
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2b86080,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
ds = 0x0
plr1 = optimized out
plr2 = optimized out
__FUNCTION__ = cities_trade_route_type
#2  0x0051f5bb in set_city_production (pcity=0x2b86080) at
city.c:2612
type = optimized out
settings = optimized out
tcity = 0x0
can_trade = optimized out
proute_iter = 0x2b8a020
proute = 0x2b89fc0
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2b86080,
workers_map=workers_map@entry=0x0)
at city.c:2785
No locals.
#4  0x0045d209 in city_refresh (pcity=pcity@entry=0x2b86080) at
cityturn.c:154
retval = false
#5  0x0049866f in sg_load_player_cities
(loading=loading@entry=0x2835490,
plr=plr@entry=0x4a6f1b0) at savegame3.c:4069
buf =
player0.c5\000ceship\000\000\377\000\000\000\000\200I\000\000\000\000\000
pcity = 0x2b86080
ncities = 8
i = 5
plrno = 0
tasks_handled = optimized out
__FUNCTION__ = sg_load_player_cities
#6  0x0049f634 in sg_load_players (loading=loading@entry=0x2835490) at
savegame3.c:3220
pplayer = 0x4a6f1b0
_pslot = 0x251bf30
__FUNCTION__ = sg_load_players
#7  0x004a1926 in savegame3_load_real (file=optimized out) at
savegame3.c:520
loading = 0x2835490
was_send_city_suppressed = false
was_send_tile_suppressed = false
__FUNCTION__ = savegame3_load_real
#8  0x00418193 in load_command (caller=caller@entry=0x8a0e20
connections,
filename=filename@entry=0x7ffe1e057940 liberty, check=check@entry=false)
at stdinhand.c:3648
loadtimer = 0x32cbb80
uloadtimer = 0x24cc950
file = 0x2519900
arg =
/home/freeciv/freeciv-web/freeciv-web/resin/webapps/ROOT/savegames/liberty.sav.xz,
'\000' repeats 63 times, \377\377\377\377, '\000' repeats 44 times,
\377\377\377\377\377\377\377\377...
__FUNCTION__ = load_command
#9  0x00419fd4 in handle_stdin_input_real
(caller=caller@entry=0x8a0e20 connections,
str=optimized out, str@entry=0x7ffe1e058470 /load liberty,
check=check@entry=false,
read_recursion=read_recursion@entry=0) at stdinhand.c:4228
full_command = load liberty\000\177\000\000`{\005\036\376\177,
'\000' repeats 42 times, \377\377\377\377\377\377\377\377, '\000' repeats
14 times,  \000\000\000\000\000\000\000\000\000N\000\000\000\376\177,
'\000' repeats 34 times,
\001\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377N, '\000'
repeats 11 times, \376\177
\000\000\000\000\000\000\000\000\000\320w\005\036\376\177\000\000\303Kb\000\000\000\000\000\002\000\000\000\000\000\000\000...
command =
load\000\000\000\000\000P\370i\240\177\000\000\070*d\000\000\000\000\000`\305\v\004\0


and


#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2765880,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
#2  0x0051f5bb in set_city_production (pcity=0x2765880) at
city.c:2612
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2765880,
workers_map=workers_map@entry=0x0)
at city.c:2785
#4  0x0045d209 in city_refresh (pcity=pcity@entry=0x2765880) at
cityturn.c:154
#5  0x0049866f in sg_load_player_cities
(loading=loading@entry=0x2414ca0,
plr=plr@entry=0x46500d0) at savegame3.c:4069
#6  0x0049f634 in sg_load_players (loading=loading@entry=0x2414ca0) 

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

Follow-up Comment #1, bug #23708 (project freeciv):

Another backtrace generated from a core. It seems that when server_quit() is
called, soem city tile is null?

Core was generated by `freeciv-web --debug=1 --port 6038 -q 20 --Announce none
-e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
1074  return pcity-tile;
Traceback (most recent call last):
  File
/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py,
line 63, in module
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2194670,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
#2  0x0051f5bb in set_city_production (pcity=0x2194670) at
city.c:2612
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2194670,
workers_map=workers_map@entry=0x0)
at city.c:2785
#4  0x0045d209 in city_refresh (pcity=0x2194670) at cityturn.c:154
#5  0x0045d9dc in city_refresh_queue_processing () at cityturn.c:208
#6  0x0047546e in server_remove_player (pplayer=0x1a7db50) at
plrhand.c:1649
#7  0x0040cee5 in server_game_free () at srv_main.c:3056
#8  0x0040d038 in server_quit () at srv_main.c:1574
#9  0x004a9c05 in server_sniff_all_input () at sernet.c:575
#10 0x0040d88d in srv_running () at srv_main.c:2574
#11 srv_main () at srv_main.c:3102
#12 0x00405485 in main (argc=20, argv=0x7ffdf71fec08) at
civserver.c:459



(gdb) bt full
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
No locals.
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2194670,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
ds = 0x0
plr1 = optimized out
plr2 = optimized out
__FUNCTION__ = cities_trade_route_type
#2  0x0051f5bb in set_city_production (pcity=0x2194670) at
city.c:2612
type = optimized out
settings = optimized out
tcity = 0x0
can_trade = optimized out
proute_iter = 0x0
proute = 0x22a1eb0
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2194670,
workers_map=workers_map@entry=0x0)
at city.c:2785
No locals.
#4  0x0045d209 in city_refresh (pcity=0x2194670) at cityturn.c:154
retval = false
#5  0x0045d9dc in city_refresh_queue_processing () at cityturn.c:208
pcity_iter = 0x0
..

___

Reply to this item at:

  http://gna.org/bugs/?23708

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23683] Freeciv segfault on load savegame

[Andreas Røsdal]

Follow-up Comment #1, bug #23683 (project freeciv):

Attaching a backtrace from gdb from this segfault, seems there is a crash in
get_trade_illness():

Starting program: /usr/local/bin/freeciv-server --file fajnie.sav.gz
[Thread debugging using libthread_db enabled]
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
This is the server for Freeciv version 2.90.99-dev
You can learn a lot about Freeciv at http://www.freeciv.org/
2: Loading rulesets.
2: Ruleset: 'migration' has been set to enabled.
2: Ruleset: 'migration' has been locked by the ruleset.
2: Ruleset: 'mgr_turninterval' has been set to 3.
2: Ruleset: 'mgr_distance' has been set to 3.
2: Ruleset: 'mgr_nationchance' has been set to 75.
2: Ruleset: 'mgr_worldchance' has been set to 25.
2: Ruleset: 'foggedborders' has been set to enabled.
2: Ruleset: 'techlost_recv' has been set to 5.
2: Ruleset: 'techlost_donor' has been set to 3.
2: Ruleset: 'ec_turns' has been set to 9.
2: Ruleset: 'ec_max_size' has been set to 100.
2: Ruleset: 'ec_info' has been set to enabled.
2: Ruleset: 'techlossforgiveness' has been set to 15.
2: AI*1 has been added as Easy level AI-controlled player (classic).
2: AI*2 has been added as Easy level AI-controlled player (classic).
2: AI*3 has been added as Easy level AI-controlled player (classic).
2: AI*4 has been added as Easy level AI-controlled player (classic).
2: AI*5 has been added as Easy level AI-controlled player (classic).
2: Savegame: 'compresstype' has been set to Using zlib (gzip format)
(LIBZ).
2: Savegame: 'gameseed' has been set to 1436384899.
2: Savegame: 'mapseed' has been set to 2072522909.
2: Savegame: 'tilesperplayer' has been set to 233.
2: Savegame: 'xsize' has been set to 54.
2: Savegame: 'ysize' has been set to 72.
2: Removing player AI*1.
2: Removing player AI*2.
2: Removing player AI*3.
2: Removing player AI*4.
2: Removing player AI*5.

Program received signal SIGSEGV, Segmentation fault.
get_trade_illness (pcity=0xff6ac0) at city.c:2472
2472if (trade_city-turn_plague != -1
(gdb) bt full
#0  get_trade_illness (pcity=0xff6ac0) at city.c:2472
trade_city = 0x0
_proute__iter = 0x0
_proute_ = 0xebff10
illness_trade = 0
#1  city_illness_calc (pcity=0xff6ac0, ill_base=0x0, ill_size=0x0, 
ill_trade=0xff6c10, ill_pollution=0x0) at city.c:2520
use_size = optimized out
illness_size = 199
illness_trade = 0
illness_pollution = 0
illness_base = optimized out
illness_percent = optimized out
#2  0x0049de20 in sg_load_player_city (citystr=optimized out, 
pcity=optimized out, plr=optimized out, loading=optimized out)
at savegame3.c:4229
i = 2
value = 0
string = 0xebff10 ~
nat_x = 16
past = 0x0
nat_y = 16
radius_sq = 15466256
---Type return to continue, or q return to quit---
id = 0
stylename = 0x0
partner = 0
#3  sg_load_player_cities (loading=0xdf42b0, plr=0x7e) at savegame3.c:4041
buf = player0.c1\000ceship, '\000' repeats 14 times
pcity = 0xff6ac0
ncities = 3
__FUNCTION__ = sg_load_player_cities
#4  0x004a3ce4 in sg_load_players (loading=0xdf42b0)
at savegame3.c:3220
pplayer = 0x2a46fc0
__FUNCTION__ = sg_load_players
#5  0x004a5f85 in savegame3_load_real (file=optimized out)
at savegame3.c:520
loading = 0xdf42b0
was_send_city_suppressed = false
was_send_tile_suppressed = false
__FUNCTION__ = savegame3_load_real
#6  0x00418654 in load_command (caller=optimized out, 
filename=optimized out, check=check@entry=false) at stdinhand.c:3653
loadtimer = 0xb7b670
uloadtimer = 0xdf4270
file = 0xb8fe30
---Type return to continue, or q return to quit---
arg = fajnie.sav.gz, '\000' repeats 1507 times...
#7  0x00419e7e in load_command (caller=caller@entry=0x0, 
filename=filename@entry=0xb25e38 srvarg+568 fajnie.sav.gz, 
check=check@entry=false) at stdinhand.c:3714
No locals.
#8  0x0040d5f4 in srv_prepare () at srv_main.c:2695
No locals.
#9  srv_main () at srv_main.c:3075
__FUNCTION__ = srv_main
#10 0x00405524 in main (argc=3, argv=0x7fffde18) at
civserver.c:459
inx = 3
showvers = false
__FUNCTION__ = main


___

Reply to this item at:

  http://gna.org/bugs/?23683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Performance issues with app not present in chrome.

[Andreas Røsdal]

Hi Mike,

I have released a new version of the Android app of Freeciv-web today, here:
https://play.google.com/store/apps/details?id=org.freeciv.play

This new version is a native Android app using a webview to display
play.freeciv.org, while the
previous version was a Phonegap app displaying play.freeciv.org. Could you
please give the new
version of the app a try, and report if this performance problem has become
better?

Regards,
Andreas



2015-06-16 21:25 GMT+02:00 Mike Mestnik) (the Archmage Forever 
che...@mikemestnik.net:

 On Mon, Jun 15, 2015 at 07:28:45PM +0200, Andreas Røsdal wrote:
 
  2015-06-13 17:05 GMT+02:00 Mike Mestnik che...@domain.hid:
  
   https://youtu.be/JKYkZFn4sBo
  
   I've confirmed this issue with the Browser application.  Being able
   to chose an alternate rendering engine would be ideal.
  
  Hi Mike, and thanks for the bugreport to Freeciv-web. If I understand you
  correctly,
  then Freeciv-web works correctly in Google Chrome, but there is a
  performance problem
  with the Browser application only? Perhaps the Browser application is
 not
  as fast as Google Chrome.
  If it works acceptable in Chrome, then I can only suggest you use that
  instead.
 
  Andreas
 
 That's about 66% correct.  It's not ONLY Browser but also the
 freeciv-web Android app available from the play store.  I'd like to use
 Chrome instead of whatever is currently being used as the renderer for the
 Android app.

 Though I'm not sure what the app does, perhaps it does nothing though I'd
 assumed(given the size) it has cached content.

 ___
 Freeciv-dev mailing list
 Freeciv-dev@gna.org
 https://mail.gna.org/listinfo/freeciv-dev

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Freeciv-web and Mozilla Firefox

[Andreas Røsdal]

Hello Silvio,

I think it is very exciting that the Mozilla bizdev team shows interest in
Freeciv-web, and I am positive to any cooperation
where we can expose Freeciv-web to an even larger number of users through
the Firefox browser and the Firefox OS.
Freeciv-web is already featured on the Firefox marketplace, but if there
are other things we can do with Freeciv-web
running on Firefox that would be of interest.

A default install of Freeciv-web on all Firefox OS devices would be a
fantastic situation for the Freeciv-web project. Further, featuring
Freeciv-web on the frontpage of the Firefox marketplace would also help.
Freeciv-web works best on tablets, desktop and devices with larger screens
currently. It is also of interest to get me access to some devices running
Firefox OS, particularly mobile devices with small screens, since there is
still some work remaining to adapt the game to mobile devices with small
screens. If you have some other suggestions for Freeciv-web and how it
could be made better on the Firefox OS please let me know!

Regards,
Andreas R.



2015-07-02 7:02 GMT+02:00 Silvio Chiba sch...@mozilla.com:

 Hi, I'm part of the Mozilla bizdev team working on content acquisition and
 distribution for desktop.

 It would be great opportunity to figure out how to get your games and the
 Firefox browser could play together. Awesome open source HTML5 games by the
 way!

 Since you made this title using web technology the port should be seamless
  Let me know if there is interest here to learn about how we can help
 expose these awesome games to our 350M MAUs.

 Regards,
 Silvio

 --
 * Silvio Chiba*
 *Business Development*
 *San Francisco, CA*
 *Mozilla Corp.*
 *m: 949-419-7469*
 *linkedin.com/in/silviochiba http://linkedin.com/in/silviochiba*




 ___
 Freeciv-dev mailing list
 Freeciv-dev@gna.org
 https://mail.gna.org/listinfo/freeciv-dev


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6115] Freeciv-web translation and i18n support

[Andreas Røsdal]

URL:
  http://gna.org/patch/?6115

 Summary: Freeciv-web translation and i18n support
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sun Jun 28 09:01:27 2015
Category: freeciv-web
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

I would like to add support for i18n to Freeciv-web. The usage of Freeciv-web
is steadily increasing, and making it available in more languages will help
usage further. In bug #20828 I have added an initial patch for i18n support to
Freeciv-web using the i18next javascript library.

Freeciv-web has some new translatable strings compared to Freeciv, and I think
it would be very helpful if these new translatable strings in Freeciv-web
could be translated by the Freeciv translators in the same way as they
translate other strings. One way to allow this would be that we maintain a
source file containing translatable strings from Freeciv-web in the Freeciv
SVN repository, so translators could easily translate strings there as normal.
This source file could contain only the strictly neccessary translatable
strings, and be carefully reviewed. I would estimate that there is a need for
perhaps 30 or 40 strings, so the work for translators is not that much.

Also, Freeciv-web has a need for the client to specify the server language, I
can patch this on the Freeciv-web side. Also there is a question about what to
do in multiplayer games. 




___

Reply to this item at:

  http://gna.org/patch/?6115

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Watch Debian Linux unit input bug. on YouTube

[Andreas Røsdal]

Hi Mike,

Thanks a lot for creating this video, this will be very useful for
improving the unit controls in the game.
I have already spent a lot of time improving and tweaking the unit
controls, but as this video shows, the user-interface
can always become more user-friendly. I agree that improving this is very
important, so I will do my best to make it better in the next version of
Freeciv-web pushed to the production server.

Regards,
Andreas


2015-06-16 19:35 GMT+02:00 Mike Mestnik che...@mikemestnik.net:

 This is related to the tablet input bug, showing the issue cross
 platform.  However the game is fully playable, because of the wider range
 of input afforded on the desktop/laptop platform.

 Debian Linux unit input bug.: https://youtu.be/8DnNIY-SQxA

 ___
 Freeciv-dev mailing list
 Freeciv-dev@gna.org
 https://mail.gna.org/listinfo/freeciv-dev


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Performance issues with app not present in chrome.

[Andreas Røsdal]

Hi Mike, and thanks for the bugreport to Freeciv-web. If I understand you
correctly,
then Freeciv-web works correctly in Google Chrome, but there is a
performance problem
with the Browser application only? Perhaps the Browser application is not
as fast as Google Chrome.
If it works acceptable in Chrome, then I can only suggest you use that
instead.

Andreas


2015-06-13 17:05 GMT+02:00 Mike Mestnik che...@mikemestnik.net:

 https://youtu.be/JKYkZFn4sBo

 I've confirmed this issue with the Browser application.  Being able
 to chose an alternate rendering engine would be ideal.

 ___
 Freeciv-dev mailing list
 Freeciv-dev@gna.org
 https://mail.gna.org/listinfo/freeciv-dev

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Html5 version input issues.

[Andreas Røsdal]

Hello Mike, and thanks for testing Freeciv-web on the Android tablet tf300t.

I have not tested the HTML5 version of the tf300t, since I don't have
access to one.
However, I have tested it on a Google Nexus running Android 5, and it
seemed to worknicely there. I suspect that there is some problem detecting
the correct device type (touch support, screen size) which will cause the
problems you are describing.

Could you please make a screen recording where you reproduce this problem,
for example using the following app:
https://play.google.com/store/apps/details?id=uk.org.invisibility.recordablefreehl=en
Then upload the resulting video for example to youtube or vimeo.

If there is a way to reproduce this problem on a browser running in Windows
or Linux, that would be of interest too.  Thanks again for reporting this
issue.

Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5930] Remove compression code from json protocol

[Andreas Røsdal]

Follow-up Comment #4, patch #5930 (project freeciv):

Thanks, looks good!

___

Reply to this item at:

  http://gna.org/patch/?5930

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23283] Use libwebsockets in Freeciv-web, remove freeciv-proxy

[Andreas Røsdal]

Follow-up Comment #3, bug #23283 (project freeciv):

This is next on my wishlist of things to improve in Freeciv.

___

Reply to this item at:

  http://gna.org/bugs/?23283

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Raw Data from The Battle of 100 Freeciv AIs

[Andreas Røsdal]

 I enjoyed your blog about the 100 Freeciv AIs - really cool stuff!

Thanks!

 Would it be possible for you to send me the data you used to make the
awesome line graphs? If I managed to get any nice visualisations done I'd
send it your way and you could put it on the blog.

Freeciv scorelog file:
http://play.freeciv.org/blog/battle-of-100-freeciv-ais/data/freeciv-score.log.gz

Python script to parse scorelog files (modified), run like this python
freeciv-score-log.py --size=3200x1800 freeciv-score.log.gz
http://play.freeciv.org/blog/battle-of-100-freeciv-ais/data/freeciv-score-log.py

Savegame at last turn:
http://play.freeciv.org/blog/battle-of-100-freeciv-ais/data/savegame.sav.bz2

Server settings:
http://play.freeciv.org/blog/battle-of-100-freeciv-ais/data/biggame.serv

Requires Freeciv from subversion at date 25.04.2015.

Here are some random things I discovered:
- Graphs from freeciv-score-log.py don't show which player has which color.
- freeciv-score-log.py extended to support more than 16 players.
- The Freeciv server takes multiple hours to complete each turn with 100
players on large maps.
- With 256 players on large maps, then the client connection to the server
is cut very often, due to a buffer overflow error message.


Regards,
Andreas R.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23526] Give warning when creating more AI players than available in nationset

[Andreas Røsdal]

Follow-up Comment #3, bug #23526 (project freeciv):

Thanks for fixing this!

___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23526] Unable to create more than 50 AI players

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23526

 Summary: Unable to create more than 50 AI players
 Project: Freeciv
Submitted by: andreasr
Submitted on: Thu 23 Apr 2015 04:29:14 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I'm unable to create more than 50 AI players, with the /set aifill command.
For example, setting aifill to 120 will not create more than 50 players.

This is both with Freeciv 2.5.0 GTK2 on Windows, and current SVN trunk on
Linux.

However, creating more AI players on Freeciv 2.4.2 Windows works correctly, so
this seems like a regression.




___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23526] Give warning when creating more AI players than available in nationset

[Andreas Røsdal]

Update of bug #23526 (project freeciv):

Severity:  3 - Normal = 4 - Important  
Priority:  5 - Normal = 3 - Low
 Summary: Unable to create more than 50 AI players = Give
warning when creating more AI players than available in nationset

___

Follow-up Comment #2:

I didn't know about the nationset concept. Perhaps the Freeciv server should
give a warning or error message when attempting to create more AI players than
is available in the nationset, instead of failing silently like now.  

Thanks for enlightening me about nationsets.

___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23526] Give warning when creating more AI players than available in nationset

[Andreas Røsdal]

Update of bug #23526 (project freeciv):

Severity:   4 - Important = 2 - Minor  


___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

[Andreas Røsdal]

Follow-up Comment #8, patch #5955 (project freeciv):

I have tested and reviewed this patch, and can gladly report that JSON arrays
are now transferred correctly! Thanks a lot to Sveinung for resolving this
complicated issue in a very good way, I don't think I could have done this
myself!  :)

Andreas (Happy!) :)

___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6028] JSON protocol: Use the address of a field to read from and write to it.

[Andreas Røsdal]

Follow-up Comment #1, patch #6028 (project freeciv):

This patch looks good to me, I have built and tested it. What are the
remaining steps to getting JSON array support, do you think?

___

Reply to this item at:

  http://gna.org/patch/?6028

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6017] JSON protocol: location in packet as parameter to the dio_* functions.

[Andreas Røsdal]

Follow-up Comment #1, patch #6017 (project freeciv):

Nice work on the JSON array support so far. This patch looks good to me. Could
you please explain a little why the location in packet is required?

___

Reply to this item at:

  http://gna.org/patch/?6017

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6017] JSON protocol: location in packet as parameter to the dio_* functions.

[Andreas Røsdal]

Follow-up Comment #3, patch #6017 (project freeciv):

Thanks for the explanation.

___

Reply to this item at:

  http://gna.org/patch/?6017

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5773] Distribute a tool to parse scorelogs

[Andreas Røsdal]

Follow-up Comment #3, patch #5773 (project freeciv):

There could be a tool which parses scorelogs and generates a HTML-page with
the results. The same tool could also generate and include the animated gif
from the mapimg output with the game replay in the HTML-page. This could be
very useful to create a score and replay dialog after the game completes, both
for Freeciv-web and the Freeciv desktop clients.

Two links for inspiration:
https://www.youtube.com/watch?v=xzO3T6h70qQ
http://forums.civfanatics.com/showthread.php?t=402101

___

Reply to this item at:

  http://gna.org/patch/?5773

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

[Andreas Røsdal]

Follow-up Comment #6, patch #5955 (project freeciv):

Thanks, Sveinung, I really encourage you to help find a good solution to this!

___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

[Andreas Røsdal]

Follow-up Comment #5, patch #5955 (project freeciv):

 One way to separate addressing and reading/writing is to make
generate_packets.py generate code that handles addressing. Would anyone object
to this approach?

I don't object to this approach. My main objective here is that arrays in the
JSON protocol should be actual JSON arrays as defined in the specification.
The actual implementation of that in generate_packets.py and elsewhere can be
refined and refactored over time. So I _definitively_ support any effort to
resolve this.

___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

[Andreas Røsdal]

Follow-up Comment #2, patch #5955 (project freeciv):

I would _really_ appreciate some help implementing json arrays correctly in
Freeciv, so we can get Freeciv-web master working again.

___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch

[Andreas Røsdal]

Follow-up Comment #2, bug #23430 (project freeciv):

Thanks for all the details, Sveinung. I think the first step for fixing this
should be to implement Json arrays in patch #5955. Then we can go on fixing
Freeciv-web after that.

___

Reply to this item at:

  http://gna.org/bugs/?23430

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch

[Andreas Røsdal]

Update of bug #23430 (project freeciv):

  Depends on: = patch #5955


___

Reply to this item at:

  http://gna.org/bugs/?23430

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23430

 Summary: Fixing Freeciv-web master branch
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sun 29 Mar 2015 08:39:56 PM UTC
Category: freeciv-web
Severity: 4 - Important
Priority: 7 - High
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

I would really appreciate some help from Marko and Sveinung with fixing the
Freeciv-web master branch:
https://github.com/freeciv/freeciv-web/commits/master

In Freeciv patch #5955, there seems to be consensus that Json protocol arrays
should be Json arrays as defined in the Json spec on json.org.

So I guess that patch #5937 should be reverted in Freeciv-web.
I think I need some help from you to review the commits from you after March
19, and update or revert changes so Json arrays are treated like Json arrays. 
Thanks!




___

Reply to this item at:

  http://gna.org/bugs/?23430

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

[Andreas Røsdal]

Update of patch #5955 (project freeciv):

Priority:  5 - Normal = 7 - High   

___

Follow-up Comment #1:

This is important for Freeciv-web to work, and a resolution to this would be
much appreciated.  The definition of a json array is pretty clearly defined on
http://json.org/   Thanks! 

___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23283] Use libwebsockets in Freeciv-web, remove freeciv-proxy

[Andreas Røsdal]

Follow-up Comment #2, bug #23283 (project freeciv):

I would like to suggest that the Json protocol use WebSockets as the transfer
protocol, before the Json protocol is defined as done, given the great work
that has gone into the Json protocol recently. This would be a huge
improvement for Freeciv-web, and would also benefit the Freeciv desktop
clients. Here we could have a discussion about how to achieve this.

___

Reply to this item at:

  http://gna.org/bugs/?23283

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5937] Arrays support to json-protocol

[Andreas Røsdal]

Follow-up Comment #6, patch #5937 (project freeciv):

Here is a patch reverting this change.

(file #24122)
___

Additional Item Attachment:

File name: JsonArrays_revert.patchSize:8 KB


___

Reply to this item at:

  http://gna.org/patch/?5937

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5937] Arrays support to json-protocol

[Andreas Røsdal]

Follow-up Comment #5, patch #5937 (project freeciv):

I suggest we revert this patch, as it doesn't implement json arrays correctly
according to the json spec, and because it breaks Freeciv-web. This will give
us time to implement arrays correctly when we have it ready, and it will fix
Freeciv-web.

___

Reply to this item at:

  http://gna.org/patch/?5937

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5937] Arrays support to json-protocol

[Andreas Røsdal]

Follow-up Comment #3, patch #5937 (project freeciv):

cazfi, what do you think about this? 

___

Reply to this item at:

  http://gna.org/patch/?5937

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5937] Arrays support to json-protocol

[Andreas Røsdal]

Update of patch #5937 (project freeciv):

  Status:Done = In Progress
 Open/Closed:  Closed = Open   

___

Follow-up Comment #2:

Sorry for not reviewing this patch in detail before now, but after thinking
about this I feel the need to discuss the array support in the JSON protocol.
As a start, please take a look at the array definition in JSON at
http://json.org/ - the definition of a JSON array is:  An array is an ordered
collection of values. An array begins with [ (left bracket) and ends with ]
(right bracket). Values are separated by , (comma).  

In this array implementation, arrays are implemented as separate key-value
pairs. So each array element is a separate key-value pair. For example, part
of the tech object will look like this in the new array implementation:

{name:Robotics, req_0:52, req_1:17}

I think that arrays in the json protocol should be implemented in the
json-way as described on json.org. The tech object will then look like
this:

{name:Robotics, reqs:[52,17]}

The native json array format is significantly more compact, and much easier to
iterate. 

At the moment most of the dialogs in Freeciv-web are not working, since they
rely on json arrays the native way.

So let's work some more on improving the arrays support in the json-protocol
and Freeciv-web. 



___

Reply to this item at:

  http://gna.org/patch/?5937

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5936] Play By Email for Freeciv-web

[Andreas Røsdal]

URL:
  http://gna.org/patch/?5936

 Summary: Play By Email for Freeciv-web
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sun 15 Mar 2015 05:08:23 PM UTC
Category: freeciv-web
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: andreasr
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

I would like to implement Play By Email support in Freeciv-web.
Basically each player plays alternating turns (phasemode=player),
and each player would get an email with a link to play each time it is their
turn. Feedback or suggestions?

Andreas




___

Reply to this item at:

  http://gna.org/patch/?5936

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23377] cannot change current city production

[Andreas Røsdal]

Update of bug #23377 (project freeciv):

  Status:None = Need Info  

___

Follow-up Comment #1:

To change the current production in the city dialog, click Change production
to get the production dialog up, then click on the new production project, and
finally click the Change production button. 

I'll need some more information about this from you. Does the Change
production button work for you? Or do you have a suggestion about how to
improve it? What kind of device and operating system are you using to access
Freeciv-web?

___

Reply to this item at:

  http://gna.org/bugs/?23377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5934] Memory block sending support to json protocol

[Andreas Røsdal]

Follow-up Comment #2, patch #5934 (project freeciv):

Very nice! I like the idea of future full support for memory block packets and
support for the delta protocol over Json and WebSockets in Freeciv-seb.

___

Reply to this item at:

  http://gna.org/patch/?5934

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5913] json protocol: Handle multiple packets in buffer -case

[Andreas Røsdal]

Follow-up Comment #9, patch #5913 (project freeciv):

Ok. This is a good improvement. Feel free to commit it.

___

Reply to this item at:

  http://gna.org/patch/?5913

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23376] freeciv web manual terrain section incomplete

[Andreas Røsdal]

Update of bug #23376 (project freeciv):

  Status:None = Confirmed  

___

Follow-up Comment #1:

Confirmed. 

___

Reply to this item at:

  http://gna.org/bugs/?23376

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23377] cannot change current city production

[Andreas Røsdal]

Update of bug #23377 (project freeciv):

  Status:   Need Info = Works For Me   
 Open/Closed:Open = Closed 

___

Follow-up Comment #2:

Thanks. Feel free to report any other bugs you find in Freeciv-web.

___

Reply to this item at:

  http://gna.org/bugs/?23377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev