[Freeciv-Dev] [bug #16080] The Great Wall affects all units regardless of whether they're inside cities
Follow-up Comment #5, bug #16080 (project freeciv): I have to admit that jtn's fix is better. Indeed, I forgot about the existence of the CityTile requirement type ;) Following the same principle, I have included a fix for civ1 civ2 rulesets, which, besides the default ruleset, are both affected by the problem. The fix is applicable to both the trunk and the S2_2 branch. (file #9395) ___ Additional Item Attachment: File name: greatwall-effect.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16080] The Great Wall affects all units which is staying out of City
Follow-up Comment #2, bug #16080 (project freeciv): The problem is due to the fact that the effect EFT_DEFEND_BONUS is potentially applicable to any unit - including outdoor units - in the game and that for the Great Wall, as the game is checking for this wonder player-wide, the bonus would be applied player-wide too. Resolving this problem yielded another related issue: for the same reasons, the firepower reset of units with F_BADWALLATTACKER attacking fortified cities did actually happen when attacking any unit - including outdoor units - of the nation controlling the Great Wall, making this nation even more hard to fight with custom rulesets using F_BADWALLATTACKER. Hard-coding the EFT_DEFEND_BONUS range to garrisoned units only, attached patches fix the problems for both the trunk and S2_2. (file #9382, file #9383) ___ Additional Item Attachment: File name: trunk-great-wall.diff Size:2 KB File name: S2_2-great-wall.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1718] French version : translation error for Slovenian nation
URL: http://gna.org/patch/?1718 Summary: French version : translation error for Slovenian nation Project: Freeciv Submitted by: kriss Submitted on: jeudi 24.06.2010 à 05:50 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: In French version, Slovenian is mistakenly translated to Slovakian, which is quite confusing since Slovakians is another nation, also present in Freeciv. Applying the attached patch against the current revision (17498) of the trunk fixes the problem. ___ File Attachments: --- Date: jeudi 24.06.2010 à 05:50 Name: fix-slovenian-fr.diff Size: 377 o By: kriss Unified diff http://gna.org/patch/download.php?file_id=9369 ___ Reply to this item at: http://gna.org/patch/?1718 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
