[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Marko Lindqvist]

Update of bug #19526 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Marko Lindqvist]

Update of bug #19526 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

> Either the server shouldn't send the chat message, or the
> client should be more relaxed about receiving early chat
> messages (client_packet_input()), or possibly both.

Attached (untested) fix takes option 4; add a new packet type that that client
accepts early.
The reason I didn't want open it up for all chat messages is that there might
be game related chat messages coming to all connections that we shouldn't
really receive/handle before we are all set up for that game.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Marko Lindqvist]

Additional Item Attachment, bug #19526 (project freeciv):

File name: EarlyChat.patchSize:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Marko Lindqvist]

Update of bug #19526 (project freeciv):

Category:None => general
 Planned Release: => 2.6.0, 3.0.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Jacob Nevins]

Follow-up Comment #1, bug #19526 (project freeciv):

Probably the same situation applies to Warning: the guest name '%s' has been
taken, renaming to user '%s'.

___

Reply to this item at:

  http://gna.org/bugs/?19526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work

[Jacob Nevins]

URL:
  http://gna.org/bugs/?19526

 Summary: Guest fallback on database error doesn't work
 Project: Freeciv
Submitted by: jtn
Submitted on: Tue Mar  6 00:27:52 2012
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_3, S2_4
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

When a server has authentication enabled and guest logins enabled (--Guests),
in the event of a database error for a non-guest username, it falls back to
connecting the user as a guest.

However, the server sends a chat message before the connection is established
to explain to the client what's happened. The client doesn't like this; it
says


Received packet PACKET_CHAT_MSG (25) before establishing connection!


and disconnects in disgust, rather defeating the point of the exercise.

Either the server shouldn't send the chat message, or the client should be
more relaxed about receiving early chat messages (client_packet_input()), or
possibly both.




___

Reply to this item at:

  http://gna.org/bugs/?19526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev