[Freeciv-Dev] [bug #20301] Not all lost units counted in score.units_lost
Update of bug #20301 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20301] Not all lost units counted in score.units_lost
Follow-up Comment #3, bug #20301 (project freeciv): - Updated S2_4/TRUNK against current svn, old patch applies to S2_3 (file #16787, file #16788) ___ Additional Item Attachment: File name: UnitsLostScore-2.patch Size:20 KB File name: UnitsLostScore-S2_4-2.patchSize:20 KB ___ Reply to this item at: http://gna.org/bugs/?20301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20301] Not all lost units counted in score.units_lost
URL: http://gna.org/bugs/?20301 Summary: Not all lost units counted in score.units_lost Project: Freeciv Submitted by: cazfi Submitted on: Sat 17 Nov 2012 04:30:21 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.3, 2.4.0, 2.5.0 ___ Details: bug #19821 point 4 is about units lost with their transport not being counted in score.units_lost or score.units_killed. That's not the only place where those counters are not properly increased. This ticket is about fixing all cases. Patch for S2_3 attached. As S2_3 has no unit_loss_reason, patch for it is quite different from what S2_4/TRUNK one will likely be. This fixes following cases where units_lost was not increased though it should: - Units lost with their transport - Units killed by hut barbarians - Units killed by terrain changes - Diplomats killed in fight against other diplomats - Diplomats failing their mission (diplomats dying after succesfull mission are not counted any more than are settlers founding cities or caravans establishing traderoutes counted; they just perform their function) - Units wiped from opponent terrain when entering peace I consider inspection period of this S2_3 patch to begin now even though S2_4/TRUNK patches are still missing (I may commit to S2_3 before other branches) ___ File Attachments: --- Date: Sat 17 Nov 2012 04:30:21 AM EET Name: UnitsLostScore-S2_3.patch Size: 18kB By: cazfi http://gna.org/bugs/download.php?file_id=16770 ___ Reply to this item at: http://gna.org/bugs/?20301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20301] Not all lost units counted in score.units_lost
Follow-up Comment #1, bug #20301 (project freeciv): TRUNK S2_4 versions (file #16771, file #16772) ___ Additional Item Attachment: File name: UnitsLostScore.patch Size:20 KB File name: UnitsLostScore-S2_4.patch Size:20 KB ___ Reply to this item at: http://gna.org/bugs/?20301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20301] Not all lost units counted in score.units_lost
Update of bug #20301 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #2: This ticket is about fixing all cases. Err. All cases where wipe_unit() is called since this simply moves counting inside wipe_unit(). ___ Reply to this item at: http://gna.org/bugs/?20301 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
