[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Jacob Nevins]

Update of bug #22048 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #10:

> Opened bug #22108 about the wrong usage of gtk from metaserver 
> thread.
I haven't been able to reproduce any crashes with current trunk (r25504), so
I'm claiming this is now fixed by a combination of that thread fix and fixes
committed under this bug.

(I did see some minor remaining trouble, for which I've raised bug #22316.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Update of bug #22048 (project freeciv):

  Status:  Ready For Test => None   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Follow-up Comment #9, bug #22048 (project freeciv):

Opened bug #22108 about the wrong usage of gtk from metaserver thread.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Jacob Nevins]

Follow-up Comment #8, bug #22048 (project freeciv):

Sadly, with trunk r24941 (containing both r24918 under this bug and the fix
for bug #22066), I reproduced symptoms (1) and (2) (or at least the backtrace
looks the same, given lack of debugging symbols).
(I haven't reproduced (3) yet, but it was rare enough that I can't be sure
it's gone.)

> So we keep this one for uninitialized scan result bug (of 
> which 2 seems to be symptom of)?
Sadly this turns out to have been a bad idea, so I guess we should migrate the
symptoms to a new ticket.
As a rule, I think we should submit fixes that we're not entirely sure address
symptoms in new, specific tickets, reserving the original to be closed when
we've evidence the symptom(s) are gone.

Thanks for the fixes, anyway. Since only I seem to be able to reproduce the
issues, probably I should be finding time to dig into them myself rather than
just posting backtraces. It's possible that it's related to old libraries (I'm
still on Xubuntu 12.04).

However, are we violating rules for using Gtk+ in threads? The GDK3 docs say

"GTK+, however, is not thread safe. You should only use GTK+ and GDK from the
thread gtk_init() and gtk_main() were called on." (That's a Grk3 doc, but I
would be surprised if the same weren't also true of Gtk2.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Follow-up Comment #7, bug #22048 (project freeciv):

I opened bug #22066 (with fix) of one symptom I'm seeing. While symptom is
different, it's quite possible that it's the same bug as one of the symptoms
you're seeing but different behavior with different glib/gtk+ versions.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Follow-up Comment #4, bug #22048 (project freeciv):

> Which suggests those are unrelated and probably need new
> ticket(s).

So we keep this one for uninitialized scan result bug (of which 2 seems to be
symptom of)?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Jacob Nevins]

Update of bug #22048 (project freeciv):

 Planned Release:   2.6.0 => 2.5.0, 2.6.0   

___

Follow-up Comment #3:

Seen symptoms (1) and (3) with unpatched S2_5 as well. Not seen (2) in my
testing.
Not reproduced any trouble with S2_4.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Jacob Nevins]

Follow-up Comment #2, bug #22048 (project freeciv):

With this patch, in sessions which survived bug #22047, I was still able to
reproduce symptoms (1) and (3) but didn't see (2).

Which suggests those are unrelated and probably need new ticket(s).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Update of bug #22048 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Marko Lindqvist]

Follow-up Comment #1, bug #22048 (project freeciv):

I could reproduce the crash a couple of times without the attached patch, but
not once with it.

It initializes meta server scan result before new scan. Presumably it used to
get SCAN_STATUS_DONE from the previous scan, causing attempt to handle the
scan results even before they are created. Do not overwrite SCAN_STATUS_ABORT
with SCAN_STATUS_DONE.
 
Also get rid of scan->meta.state that was never used, only set at one place.

(file #20766)
___

Additional Item Attachment:

File name: InitMetaScanStatus.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

[Jacob Nevins]

URL:
  

 Summary: Crashes and other trouble with repeated "Connect to
network game" / "Cancel"
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 18 May 2014 13:18:00 BST
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r24892
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.6.0

___

Details:

(Found while trying to verify fix for bug #21896.)

Xubuntu 12.04 amd64; start freeciv-gtk2; repeatedly "Connect to network game"
then "Cancel" (using keyboard shortcuts for speed: hold down Alt then
c[O]nnect, [C]ancel, [O], [C], ...).

Observe a variety of symptoms:



1. This verbose warning message from Gtk:


(freeciv-gtk2:10919): Gtk-WARNING **: Invalid text buffer iterator: either the
iterator is uninitialized, or the characters/pixbufs/widgets in the buffer
have been modified since the iterator was created.
You must use marks, character numbers, or line numbers to preserve a position
across buffer modifications.
You can apply tags and insert marks without invalidating your iterators,
but any mutation that affects 'indexable' buffer contents (contents that can
be referred to by character offset)
will invalidate all outstanding iterators




2. A crash like this in the metaserver thread (seen twice):


Program terminated with signal 11, Segmentation fault.
#0  0x7fab9b6f95f8 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#1  0x7fab9b6dd55c in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#2  0x7fab9b6e035f in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#3  0x7fab9abbaca2 in g_closure_invoke ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#4  0x7fab9abcc339 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#5  0x7fab9abd4069 in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#6  0x7fab9abd4212 in g_signal_emit ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#7  0x7fab9b6e1de8 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#8  0x004d51c7 in apply_text_tag (ptag=, buf=0x1a0b100,

text_start_offset=405, text=) at chatline.c:841
tag = 0x3f12840
foreground = {pixel = 2139528224, red = 61423, green = 32639, blue =
0}
background = {pixel = 27308288, red = 0, green = 0, blue = 10316}
initalized = true
start = {dummy1 = 0x1aaf200, dummy2 = 0x7fab78012bc0, dummy3 = -1, 
  dummy4 = 0, dummy5 = 405, dummy6 = -1, dummy7 = 595129065, 
  dummy8 = -1729242823, dummy9 = 0x7fab780144b0, 
  dummy10 = 0x7fab78012710, dummy11 = -1, dummy12 = 0, dummy13 = 0, 
  dummy14 = 0x7fab7f869c20}
stop = {dummy1 = 0x1aaf200, dummy2 = 0x7fab78012bc0, dummy3 = -1, 
  dummy4 = 54, dummy5 = 459, dummy6 = -1, dummy7 = 595129065, 
  dummy8 = -1729242823, dummy9 = 0x1aaf1a0, dummy10 = 0x1aaf4e0, 
  dummy11 = -1, dummy12 = 0, dummy13 = 68009248, dummy14 = 0x1a0b100}
#9  0x004d5597 in real_output_window_append (
astring=0x7fab7f869d40 "There is no newer stable release of Freeciv
available.", tags=, conn_id=) at chatline.c:916
ptag_iter = 0x0
ptag = 0x7fab78014240
buf = 0x1a0b100
iter = {dummy1 = 0x1aaf200, dummy2 = 0x7fab78012bc0, dummy3 = 54, 
  dummy4 = 54, dummy5 = -1, dummy6 = -1, dummy7 = 595129065, 
  dummy8 = -1729242823, dummy9 = 0x1aaf1a0, dummy10 = 0x1aaf4e0, 
  dummy11 = 0, dummy12 = 0, dummy13 = 68009248, 
  dummy14 = 0x7fab9b6f7679}
mark = 0x40dbd20
text_start_offset = 405
__FUNCTION__ = "real_output_window_append"
#10 0x00478480 in output_window_append (color=..., 
featured_text=) at chatline_common.c:130
plain_text = "There is no newer stable release of Freeciv available.",
'\000' , "\001", '\000' "\377,
\377\377\377\060\000\000\000
\241\206\177\253\177\000\000`\240\206\177\253\177\000\000\240/\272\232\253\177\000\000\000\000\000\000\000\000\000\000\n\000\000\000\253\177\000\000\003",
'\000' , "P", '\000' ,
"t\212A\235\253\177", '\000' ,
"\004\000\000\000\000\000\000\220\236\206\177\253\177\000\000\000\347`o\377\177\000\000\300Ɇ\177\253\177\000\000\000\263\247B\237++\260\003",
'\000' "\300,
S\001x\253\177\000\000\000\347`o\377\177\000\000\300Ɇ\177\253\177\000\000\204\027c\000\000\000\000\000"...