[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #23, bug #22625 (project freeciv): I confirm it is fixed. Freeciv-2.5.0-RC2-win32-gtk2 on windows - does NOT crash on change tileset while viewing science or viewing the map with science report open. ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 = 2.4.5, 2.5.0-RC2, 2.6.0, 3.0.0 ___ Follow-up Comment #18: After the previous patch, the only problem in gtk2-client seemed to be that science dialog redraw is too early while new tileset is set to use. Though I'm not exactly sure what things are needed for it to work, it seems to work with attached patch at least (keeping the call still inside tileset_changed() instead of more hacky solutions of calling it from some totally unrelated place). (file #23962) ___ Additional Item Attachment: File name: Gtk2LateScienceRedraw.patchSize:0 KB ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #17, bug #22625 (project freeciv): Freeciv-2.5.0-RC1-win32-gtk2 on windows - crashes on change tileset while viewing science or viewing the map with science report open. The version of libgobject-2.0-0.dll is 2.36.1 Exact same bug as reported in comment 1 below - freeciv-gtk2.exe caused an Access Violation at location 63a4f57d ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Planned Release: 2.4.5, 2.5.0, 2.6.0 = 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #16, bug #22625 (project freeciv): Committed the current fix before 2.5.0-RC1 gets released. Leaving ticket open for later analysis whether here is something reported here that should be considered separate issue. ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Status: Confirmed = Ready For Test ___ Follow-up Comment #11: The main problem (at least in case of gtk3-client) was that the dialog was redrawn while the tileset was not fully loaded - it ended up trying to draw NULL sprites for units enabled by techs etc. With the attached patch the gtk3-client survived tileset change every time I tested it. Neither did gtk2-client backtrace show it to crash in science dialog redraw any more, but it was crashing in mapview redraw instead. It might be pure luck that gtk3-client never happened to redraw the mapview with unfortunate timing. (file #23861, file #23862) ___ Additional Item Attachment: File name: HalfloadedTilesetReqtree.patch Size:2 KB File name: HalfloadedTilesetReqtree-S2_4.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #10, bug #22625 (project freeciv): This is nasty, but not an regression since S2_4 in S2_5. This is not an absolute blocker for 2.5.0, though I really would want to see this resolved before. ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Planned Release: 2.4.4, 2.5.0, 2.6.0 = 2.4.5, 2.5.0, 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #9, bug #22625 (project freeciv): I had a look on it this morning: crash happens when trying to recenter the science diagram. The calculation of the value of the adjustment of the scrolled window doesn't look right. It should take in account the widget allocation and adjust-lower should be subtracted, not added. But even with fixing this issue, disabling the adjustment of the diagram view, or delaying these operations, crashes are still present. I dunno if shrinking the GtlLayout is really safe. Couldn't make deeper investigation for the moment. ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Update of bug #22625 (project freeciv): Status:None = Confirmed Operating System: Microsoft Windows = Any Planned Release: = 2.4.4, 2.5.0, 2.6.0 Summary: Client crash updating science dialog after changing tileset = Client crash when changing tileset with science dialog open ___ Follow-up Comment #1: I can readily reproduce a similar-looking crash on Linux if I change tileset while the science dialog is open. e.g. from Cimpletoon to Amplio2, S2_4 r26412: #0 0x7fd4d915eb69 in g_object_ref () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #1 0x7fd4d9828d92 in gdk_gc_set_values () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #2 0x7fd4d9828f55 in gdk_gc_set_clip_mask () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #3 0x0051f499 in gtk_pixcomm_expose (widget=0x53388e0, ev=0xa376180) at gtkpixcomm.c:315 rop = 0x5337850 misc = 0x53388e0 y = 0 i = 0 p = 0x53388e0 x = 0 xalign = 0.5 __FUNCTION__ = gtk_pixcomm_expose #4 0x7fd4d9beae78 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #5 0x7fd4d9159c1b in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #6 0x7fd4d916b339 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #7 0x7fd4d9172d4e in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #8 0x7fd4d9173212 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #9 0x7fd4d9d05231 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #10 0x7fd4d9b6e276 in gtk_container_propagate_expose () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #11 0x7fd4d9b6ce44 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #12 0x7fd4d9b8401f in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #13 0x7fd4d9beae78 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #14 0x7fd4d9159ca2 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #15 0x7fd4d916b339 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #16 0x7fd4d9172d4e in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #17 0x7fd4d9173212 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #18 0x7fd4d9d05231 in ?? () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #19 0x7fd4d9be9660 in gtk_main_do_event () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #20 0x7fd4d9845604 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #21 0x7fd4d98455b3 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #22 0x7fd4d98455b3 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #23 0x7fd4d98455b3 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #24 0x7fd4d98455b3 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #25 0x7fd4d98405a3 in ?? () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #26 0x7fd4d984291d in gdk_window_process_updates () from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 No symbol table info available. #27 0x7fd4d9159ca2 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #28 0x7fd4d916ad71 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #29 0x7fd4d9173069 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #30 0x7fd4d9173212 in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 No symbol table info available. #31 0x7fd4d9b2e42a in gtk_adjustment_value_changed () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 No symbol table info available. #32 0x004691bd in science_diagram_center (diagram=0x8af10b0, tech=2) at repodlgs.c:307 adjust = 0x8b18400 value = 0 sw = 0x8b0f3c0 reqtree = 0xab066d0 x = 0 y = 0 width
[Freeciv-Dev] [bug #22625] Client crash when changing tileset with science dialog open
Follow-up Comment #2, bug #22625 (project freeciv): I am the original poster for both of the two original bug reports. I am fairly certain I was not looking at the science report at the time of changing tilesets. Have just recreated this exact same bug on windows freeciv beta1 by changing the tileset while looking at the map with the science report tabbed. (no other tabs seems to cause the error, and no crash before the science tab was opened). But if I look at the science report and change tilesets the crash does not occur. (What you actually see when changing between trident and amplio2 is the size of the boxes within the science report change.) I then went to the map and saw that the tileset had correctly changed. I then changed tilesets a few times with the science report still tabbed and no crash occurred. I checked this non-crash scenario a couple of times from the start to check it was persistent. ___ Reply to this item at: http://gna.org/bugs/?22625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
