[Freeciv-Dev] [patch #1845] libcurl

2010-09-20 Thread pepeto

Follow-up Comment #3, patch #1845 (project freeciv):

Note that since glib 2.22, there are lot of tools to perform what we probably
want to do. Notably GNetworkService, GSocketConnectable and GResolver. If we
decide to use GThread (like patch #1846), we probably could also use those
tools. Note also, there are very interresting tools for handling UTF-8
characters and strings.


___

Reply to this item at:

  http://gna.org/patch/?1845

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1845] libcurl

2010-08-11 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?1845

 Summary: libcurl
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wednesday 08/11/2010 at 15:20
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

Our http module and code in server/meta.c and modinst/download.c is
simplistic way of obtaining documents from web. It has many shortcomings we
have somehow been able to live with so far, especially as the functionality
has been needed only for metaserver handling.
Now that also freeciv-modpack needs this functionality, those shortcomings
are (even) harder to live with.

Would it be overkill to replace our own implementation with libcurl usage?
That would fix a lot of problems and give tons of new features. The most
important features for us would be:

1. Graceful error handling
2. Handling of http redirects. Had freeciv servers and clients out
   there had this, at least one incident of metaserver downtime
   could have been avoided by the metaserver side arrangements
3. Support many other protocols in addition to http. This would
   not make much sense with metaserver, but freeciv-modpack would
   turn into much more powerful tool with this

Schedule: This would add libcurl dependency for Freeciv. It could potentially
cause some portability issues that take time to resolve. It would also take
some time to fully implement the feature. For these reasons I'd consider
libcurl usage 2.4.0 feature rather than 2.3.0 one. For 2.3.0 we should still
fix worst problems in our own implementation.

Comments, please.




___

Reply to this item at:

  http://gna.org/patch/?1845

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1845] libcurl

2010-08-11 Thread pepeto

Follow-up Comment #1, patch #1845 (project freeciv):

Do this allow to do asynchronous DNS lookup for the server?

Didn't you forgot to mention client/server.c for getting the metaserver
list?


___

Reply to this item at:

  http://gna.org/patch/?1845

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1845] libcurl

2010-08-11 Thread Marko Lindqvist

Follow-up Comment #2, patch #1845 (project freeciv):

 Do this allow to do asynchronous DNS lookup for the server?

No, I don't think so. But I already opened ticket patch #1846 about threads
and one thing I was thinking about was metaserver handling.

 Didn't you forgot to mention client/server.c for getting the
 metaserver list?

I have to admit that I didn't check the sources but only listed files where I
assumed stuff to be :-)


One more libcurl feature that may benefit us:
- Correct proxy handling


___

Reply to this item at:

  http://gna.org/patch/?1845

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev