[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Update of patch #1936 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Update of patch #1936 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #22:

- Negative effect value no longer means infinite slots count.
No-slot-restrictions ruleset can be created by making all units to take zero
slots.
- Default number of slots unit takes changed from 1 to 0
- Added AI evaluation of the effect
- Rulesave saves unit slot information
- Fixed name of "Unit_Slots" effect

(file #28843)
___

Additional Item Attachment:

File name: CityUnitSlots-2.patch  Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Follow-up Comment #21, patch #1936 (project freeciv):

Patch (not yet commit-candidate) being developed from scratch attached. It's
more generic feature than one provided by the old patch.

- Add effect "Unit_Slots" that tell how many unit slots city can maintain.
Negative value means infinite.
- Add unit type property "city_slots" that tells how many slots it takes
- Units can't be built nor can they make a city their homecity if they would
take slots and city does not have that many free


(file #28835)
___

Additional Item Attachment:

File name: CityUnitSlots.patchSize:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Update of patch #1936 (project freeciv):

Priority:   1 - Later => 5 - Normal 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Update of patch #1936 (project freeciv):

 Assigned to: syntron => None   
 Planned Release:   2.6.0 => 3.0.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Marko Lindqvist]

Update of patch #1936 (project freeciv):

Category:rulesets = general
 Planned Release:   2.5.0 = 2.6.0  


___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Jacob Nevins]

Update of patch #1936 (project freeciv):

 Planned Release:   2.4.0 = 2.5.0  

___

Follow-up Comment #20:

 I'm really looking forward to this patch. Imo, it will surely 
 balance the behavior of gold upkeep.
 How could I test it? Is it going to be included in v2.4.0?
Sadly, the patch as currently written is (now) too late for 2.4, as it changes
the network protocol. Sorry.

Since it's clearly a desired feature, I'll retarget at 2.5.0, and hopefully
we'll get to it in time.

Glancing at it, I wonder why this is a global server setting, rather than an
effect?
(Not that changing this will get it into 2.4, since it would be a backward
incompatible ruleset format change.)

___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[David Fernandez]

Follow-up Comment #19, patch #1936 (project freeciv):

I'm really looking forward to this patch. Imo, it will surely balance the
behavior of gold upkeep.
How could I test it? Is it going to be included in v2.4.0?

___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[David Fernandez]

Follow-up Comment #18, patch #1936 (project freeciv):

I tried to apply the patch over rev19760 and there was 1 single fail:
+vervatim+
patching file common/game.h
Hunk #1 FAILED at 88.
-vervatim-

Thanks doctorjlowe.
About AI, I do not mean changes to general motivation of the AI, but basic
changes to keep the AI from trying to recruit units at cities that reached the
pop limit, or maybe an automatic rehome of unsupported units to other cities,
so this rule do not affect much the efficiency of AI.
(if not already in this patch, I do not know).


___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[David Lowe]

Follow-up Comment #17, patch #1936 (project freeciv):

I'm not aware of anything that would prevent (file #11224) from being cleanly
applied, though it's possible i've missed something.  If it doesn't apply,
then we'd need that feedback to make corrections.

These patches do *not* change the motivation of the AI, which is going to
keep acting the same.  However, i don't think the AI is going to be overhauled
anytime soon - that'll be a big task.

___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[David Fernandez]

Follow-up Comment #16, patch #1936 (project freeciv):

I'd like to test this patch.
May I install it over current trunk repository (together with update hit
point calculation for killunhomed)? Would AI handle it? or I should wait to
v2.4.0

___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[Matthias Pfafferodt]

Update of patch #1936 (project freeciv):

 Assigned to:None = syntron
 Summary: limit the number of units a city can support =
limit the number of units with gold upkeep a city can support

___

Follow-up Comment #15:

updated patch

changes:

* new function city.c:city_unit_gold_upkeep_status() which returns the amount
of units with gold upkeep which can be added to the city
* add a check in can_city_build_unit_direct()


(file #11224)
___

Additional Item Attachment:

File name:
20101115-trunk-limit-units-with-gold-upkeep-support-by-a-city-if-up.patch
Size:11 KB


___

Reply to this item at:

  http://gna.org/patch/?1936

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev