[Freeciv-Dev] (PR#39811) BUG: oddball iterators

2007-10-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39811 Some months ago, I began a project to review iterators, and covered most of the major ones. Here are those remaining, infrequently used, mostly only in one or two files. Where they have the lack of name qualification nesting problems,

Re: [Freeciv-Dev] (PR#39811) BUG: oddball iterators

2007-10-29 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39811 Since TRUNK and S2_2 AI is very much broken, I tested this with S2_1 (patch applied cleanly except one line change in unitlist.h) There seems to be some regression. Autogames differ. - ML

Re: [Freeciv-Dev] (PR#39811) BUG: oddball iterators

2007-10-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39811 Marko Lindqvist wrote: There seems to be some regression. Autogames differ. A regression is the return of a previously reported and fixed bug. What bug are you reporting has returned?

Re: [Freeciv-Dev] (PR#39811) BUG: oddball iterators

2007-10-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39811 Come to think of it, I hadn't been applying these iterator patches against 2.1. They were trunk-only (nee 2.2). It's kinda nice to hear that they apply cleanly, but wasn't my expectation. They were written for 2.2. When I was testing