[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[pepeto]

Update of bug #15469 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #6:

Fix included by mistake on revision #16962 for the trunk branch.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[pepeto]

Update of bug #15469 (project freeciv):

Category:None => client-gtk-2.0 
  Status:None => Ready For Test 
 Assigned to:None => pepeto 
 Planned Release: => 2.2.1  

___

Follow-up Comment #4:

Change the test before send_packet_player_ready() to can_client_control(), I
don't think we can do more...


(file #8282)
___

Additional Item Attachment:

File name: trunk_S2_2_send_player_ready.diff Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[pepeto]

Follow-up Comment #3, bug #15469 (project freeciv):

> Can it be observer trying to send the packet?

I guess you mean player observer. Then, before bug #15451, you would have get
the message "Got a packet of type %d from a dead or observer player". However,
as I told before, the test before sending would be can_client_control(), even
if the sensitivity of this button is already dependent of that.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[Marko Lindqvist]

Follow-up Comment #2, bug #15469 (project freeciv):

Can it be observer trying to send the packet?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[pepeto]

Follow-up Comment #1, bug #15469 (project freeciv):

According to the only place this packet is sent
(client/gui-gtk-2.0/pages.c::start_start_callback()), the test unsure the
client is attached to a player before sending that packet (the most correct
check would be can_client_control(), but it wouldn't have changed this case
now). So:
* the client is out of synchronization, and we cannot do anything I guess.
* this client was hacked, and we really cannot do anything.

What do you suggest?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15469] Received packet PLAYER_READY from non-player connection

[Marko Lindqvist]

URL:
  

 Summary: Received packet PLAYER_READY from non-player
connection
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wednesday 02/24/2010 at 17:58
Category: None
Severity: 2 - Minor
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

>From 2.2.0 server log:
1:Received packet PLAYER_READY from non-player connection ...

According to client info packet, user uses gtk client.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev