[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #9: I'm happy with the consistency back, all API types (except helper types) have an .id field. But what is more important in the long run: with properties (as added in the trunk patch), the lua API we present can be totally independent from struct fields, fields can always be replaced by accessors. ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Assigned to: pepeto = englabenny ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Priority: 1 - Later = 5 - Normal Status: In Progress = Ready For Test ___ Follow-up Comment #6: Updated patches: 2.2: Minimal changes to accomplish this. No other changes riding in on that. trunk: Use a general solution in declarative style, it should be obvious how more properties can be added by just adding more methods inside a type's 'properties' subtable. (file #8978, file #8979) ___ Additional Item Attachment: File name: 2010041501-API-Restore-Player.id-field-using-properties.patch Size:4 KB File name: 2010041501-S2_2-API-Restore-Player.id-field-using-properties.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #5: A month wiser, I would like to solve this like this instead (patch for trunk and 2.2 attached). Basically we use a field .id that calls the number method when accessed. Using properties we can keep the old API even if fields are totally removed from the exported struct (which was what happened with struct player to cause this bug). I would like to backport this to 2.2.1, player:number() is not in any released version yet so we have chance to get rid of it still. Since I'm taking the whole special methods block of code from trunk, the change to make equalities work for all api types kind of rides in on this change. That could be avoided of course, but I don't see any point in that.. (file #8961, file #8962) ___ Additional Item Attachment: File name: 2010041401-API-Restore-Player.id-field-using-properties.patch Size:5 KB File name: 2010041401-S2_2-API-Restore-Player.id-field-using-properties.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Assigned to:None = pepeto Planned Release: = 2.2.1, 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Follow-up Comment #2, bug #15586 (project freeciv): Here is the patch in alternate version, instead using :number() method. (file #8464) ___ Additional Item Attachment: File name: 0001-Add-Player-number-method-to-allow-saving-players-in-.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
