[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #8, bug #19841 (project freeciv): Would it be better to have a section in nationlist.ruleset explicitly listing all allowed govs in leader titles (and e.g. terrains) [...] I've implemented this in the patch series starting at patch #3859. ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #6, bug #19841 (project freeciv): Late comment (again, I should really review patches before they're committed, sorry): Would it be better to have a section in nationlist.ruleset explicitly listing all allowed govs in leader titles (and e.g. terrains), rather than having to specify the delta between the ruleset and the default nationset in each ruleset's nations.ruleset? That has the advantage that it's more obvious to the maintainers of the default nationset what the allowed govs/terrains are -- they need only look at the single nationlist.ruleset, not reconcile multiple rulesets and wondering what else is out there; and it's clear to ruleset authors who intend to re-use the default nationset what sort of ruleset features it expects. Something like [ruleset_compatibility] leader_govs = Anarchy, Despotism, Monarchy, Communism, Fundamentalism, Republic, Democracy city_terrains = river, lake, ocean, glacier, desert, forest, grassland, hills, jungle, mountains, plains, swamp, tundra ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #7, bug #19841 (project freeciv): Would it be better to have a section in nationlist.ruleset explicitly listing all allowed govs in leader titles (and e.g. terrains), rather than having to specify the delta between the ruleset and the default nationset in each ruleset's nations.ruleset? Well, yes. Only that it would mean splitting [compatibility] section between ruleset specific part (warn_city_style) and nationlist.ruleset. But maybe warn_city_style should be replaced with similar list of city styles anyway. ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Update of bug #19841 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Update of bug #19841 (project freeciv): Category:rulesets = general Status:None = In Progress Assigned to:None = cazfi Planned Release: = 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Update of bug #19841 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #4: Patch with the compatibility.ignore_govs idea - Do not warn about Fundamentalism in classic or experimental ruleset - Turned log message to log_error in other cases (file #17195) ___ Additional Item Attachment: File name: IgnoreGovs.patch Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #3, bug #19841 (project freeciv): Add to nations.ruleset [compatibility] section list of government types for which warning is omitted, and put Fundamentalism to that list for classic ruleset. That's an idea. Could also reinstate terrain checks for natural city names that were suppressed under bug #15333, using this mechanism. ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
URL: http://gna.org/bugs/?19841 Summary: Fundamentalism fails in classic ruleset Project: Freeciv Submitted by: i1abnrk Submitted on: Sat 23 Jun 2012 03:22:34 PM GMT Category: rulesets Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.99 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Several dozen nations throw debug level 3 info on starting freeciv with classic ruleset, all with Fundamentalism government. 3: Nation Abkhaz: government Fundamentalism not found. 3: Nation Australian Aboriginal: government Fundamentalism not found. ... These nations are still selectable and playable from client. So, seems failsafe is working. ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #1, bug #19841 (project freeciv): That's a normal consequence of the supplied nations having provision for being used in rulesets with Fundamentalism (ruler titles) but being loaded with the default/classic ruleset. There should be no ill effects. A bit messy, but I'm not sure what to do to quell the warnings cleanly. (In general, such warnings are helpful for spotting typos in nations.) ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19841] Fundamentalism fails in classic ruleset
Follow-up Comment #2, bug #19841 (project freeciv): A bit messy, but I'm not sure what to do to quell the warnings cleanly. (In general, such warnings are helpful for spotting typos in nations.) Add to nations.ruleset [compatibility] section list of government types for which warning is omitted, and put Fundamentalism to that list for classic ruleset. ___ Reply to this item at: http://gna.org/bugs/?19841 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
