[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Jacob Nevins]

Update of bug #19971 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Matthias Pfafferodt]

Follow-up Comment #3, bug #19971 (project freeciv):

> Is the patch OK?
I looks fine as far as I can see without compiling it. I gives a defined state
for such (unknown) tiles.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Jacob Nevins]

Follow-up Comment #2, bug #19971 (project freeciv):

> This should be similar to the borders plotted on the main map 
The attached patch makes the main map and mapimg behave the same in this
regard. File #16169 is the result of the attached patch.

> (as far as I remember this terrain is unknown and there could 
> be a city of another player?!

Indeed, there could in theory be another, non-cyan player's city in that
single square (and who-knows-what in the big dark area inside the purple
borders at the top of the attached images). But the server shouldn't leak this
information when drawing maps with incomplete knowledge, and the client (from
which these images were taken) doesn't even know.

Is the patch OK?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19971 (project freeciv):

This should be similar to the borders plotted on the main map (as far as I
remember this terrain is unknown and there could be a city of another player?!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Jacob Nevins]

Update of bug #19971 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-mapimg-unknown-borders.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Jacob Nevins]

URL:
  

 Summary: mapimg: Spurious border lines around unknown tiles
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Jul 22 18:12:09 2012
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r21601
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.4.0,2.5.0

___

Details:

When mapimg plots borders and map knowledge is not complete, it can draw
spurious lines around "holes" of unknown territory.

The main mapview (fill_grid_sprite_array()) does not plot borders between
tiles if either tile is unknown.

In the attached examples, this can be seen for instance in the Austrian (cyan)
territory.



___

File Attachments:


---
Date: Sun Jul 22 18:12:09 2012  Name: old.png  Size: 40kB   By: jtn
Example screenshots (S2_4 r21601, client-side mapimg)

---
Date: Sun Jul 22 18:12:09 2012  Name: new.png  Size: 39kB   By: jtn
Example screenshots (S2_4 r21601, client-side mapimg)


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev