[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #12, bug #19977 (project freeciv): Trivial patch for S2_3 typo. No attempt to handle binaries built off S2_3 in the last month or so specially. (file #16745) ___ Additional Item Attachment: File name: S2_3-trademindist-capability-typo.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #11, bug #19977 (project freeciv): Looks like a typo in the S2_3 patch: in fc_version there's a single capability 'rules_finishedtrademindist_size' (broken over 80 columns). ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Update of bug #19977 (project freeciv): Status: Ready For Test = Fixed Assigned to: jtn = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Update of bug #19977 (project freeciv): Category:None = general ___ Follow-up Comment #7: Patches TRUNK: Increase size of trademindist field to 16 bits S2_3 S2_4: Send based on optional network capability either 8 bit or 16 bit value. (file #16638, file #16639, file #16640) ___ Additional Item Attachment: File name: TrademindistSize.patch Size:0 KB File name: TrademindistSize-S2_3.patchSize:5 KB File name: TrademindistSize-S2_4.patchSize:5 KB ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #6, bug #19977 (project freeciv): OK, I'm putting off doing anything about this until after 2.4.0-beta1. ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Update of bug #19977 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Release:trunk r21615 = 2.3.2, trunk r21615 Planned Release: = 2.3.3,2.4.0,2.5.0 ___ Follow-up Comment #4: Better ways to achieve this effect for 2.5 are handled in other tickets. For this one, I think we should just change the advertised maximum to match reality. Patch attached. For trunk, I've updated civ2civ3 to match, but for 2.4/2.3, the civ2civ3/civ2-3 rulesets hosted externally *will* need updating to match, or for new games, the attempt to set an out-of-range trademindist will be ignored, and the default will be used instead, enabling same-nation trade routes. (This might be an argument for leaving this patch off S2_3 -- thought?) ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Additional Item Attachment, bug #19977 (project freeciv): File name: trunk-trademindist-max.patch Size:1 KB File name: S2_4-S2_3-trademindist-max.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #5, bug #19977 (project freeciv): Maybe the right thing to do (in stable branches at least) would be to increase the network field size with optional capability (removing old field, adding new one). In S2_3 existing versions of civ2-3 ruleset are widely used, and we can't expect everyone updating their freeciv engine to update the ruleset too. ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #1, bug #19977 (project freeciv): why civ2civ3 is using that value, and if it's intentional, It's there to practically disable national trade - trademindist does not apply when establishing traderoutes between nations. Actually, I don't remember if trademindist applies even national traderoutes from continent to another. ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)
Follow-up Comment #2, bug #19977 (project freeciv): I assume stable branches are affected. There (at least) we can't do much more than to change legal range of trademindist to 1-255. I'm not sure if type used in network should be made bigger in trunk. 255 is quite big distance for normal usage already, and we should provide cleaner interface for disabling national trade. Implementing set of new trade related features was one thing I was about to do when my another computer went down - with some not-yet-submitted patches. I'll keep need to have separate ruleset controls for different kinds of traderoutes in mind when starting that work again. ___ Reply to this item at: http://gna.org/bugs/?19977 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
