[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-11 Thread Jacob Nevins 
Update of bug #20005 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-11 Thread Jacob Nevins 
Update of bug #20005 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #7:

I think we should commit this patch for 2.4.0-beta1 (i.e. now).

Christian's tested it and it makes things better on Windows. Windows builds
are only really built under controlled conditions anyway (i.e. basically only
by Christian and Marko).

Looking at the patch, it has little scope to break other builds, as once the
top-level Makefile is generated there should be no change.

I've tested it on Unix (going as far as making a mock release tarball and
building/installing from that), successfully.

Patch doesn't apply cleanly to S2_4 but the conflicts are trivial. Attached
the git auto-merged version for S2_4.

If no-one else commits it first, I will commit this before building beta1.

(file #16370)
___

Additional Item Attachment:

File name: S2_4-WinConfPath.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-08 Thread Christian Prochaska 
Follow-up Comment #6, bug #20005 (project freeciv):

> Then could we use something like attached (at the moment untested) patch? 

It seems to work with the patch.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-07 Thread Marko Lindqvist 
Follow-up Comment #5, bug #20005 (project freeciv):

Then could we use something like attached (at the moment untested) patch?

Not sure about trying to rush this to beta1...


(file #16340)
___

Additional Item Attachment:

File name: WinConfPath.patch  Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-07 Thread Christian Prochaska 
Follow-up Comment #4, bug #20005 (project freeciv):

> What's the working dir when running official Installer builds?

Working dir is the install root. database.lua is in "etc/freeciv" relative to
install root.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-05 Thread Marko Lindqvist 
Follow-up Comment #3, bug #20005 (project freeciv):

What's the working dir when running official Installer builds? If it's
relative to installation root, we could have relative path from there to
database.lua.

I'm going to test relative path with crosser builds where "../share/freeciv"
is already part of compiled in default data path (working dir bin/ where
freeciv-xxx are)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-05 Thread Jacob Nevins 
Follow-up Comment #2, bug #20005 (project freeciv):

> This isn't the first time we've baked in a path at compile-time 
> -- see patch #2948 for a prior example
Oh rubbish, that patch was for *non*-Windows platforms. On Windows the icon is
baked into the executable. So this *is* the first time we've done this on
Windows.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-08-05 Thread Jacob Nevins 
Update of bug #20005 (project freeciv):

 Planned Release: 2.4.0,2.5.0 => 2.4.0-beta1,2.5.0  

___

Follow-up Comment #1:

We'd better do something about this for 2.4.0-beta1, hadn't we?

How are Windows builds finding their other datafiles currently?

How should we fix this -- add an environment variable to override the
database.lua path, as contemplated in bug #19729, and set that environment
variable in the installer somehow (perhaps in .cmd files)?

(This isn't the first time we've baked in a path at compile-time -- see patch
#2948 for a prior example, although it's absolutely not an important one if it
fails.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-07-31 Thread Jacob Nevins 
Update of bug #20005 (project freeciv):

 Planned Release: => 2.4.0,2.5.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20005] Compile time decided database.lua location & Windows installations

2012-07-30 Thread Marko Lindqvist 
URL:
  

 Summary: Compile time decided database.lua location & Windows
installations
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 30 Jul 2012 05:46:57 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There's conflict in how database.lua is expected strict compile time set
location, and how SW to Windows is installed to user-selected location.

Crosser builds do worse than that - they expect database.lua in directory used
in build system while building. That's simple misuse of --prefix instead of
DESTDIR in my build environment, should be easy to fix.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev