[Freeciv-Dev] [bug #20848] Allow the user to have CMA to have no minimum surplus for a category.

2013-06-01 Thread Micke
Follow-up Comment #1, bug #20848 (project freeciv):

These bounds appear to be determined client-side, in the code for creating the
sliders in client/gui-gtk-[23].0/cma_fe.c; in the gtk-2 version on lines 327 -
328:
pdialog-minimal_surplus[i] =
GTK_ADJUSTMENT(gtk_adjustment_new(-20, -20, 20, 1, 1, 0));

and in the gtk-3 version probably lines 343 - 345:
   pdialog-minimal_surplus[i] = hscale =
gtk_scale_new(GTK_ORIENTATION_HORIZONTAL, NULL);
gtk_range_set_range(GTK_RANGE(hscale), -20, 20);

These seem to override a value of -60 for a preset defined in the cma section
of ~/.freeciv-client-rc-version.
Easy enough to change by themselves, but at least the Gtk-2 version won't
adjust its size accordingly making precise control (such as setting a slider
back to 0 after going to -50) all but impossible.
 I don't intend to learn gtk-2 long after it's been deprecated and I won't
touch the gtk-3 one until I've upgraded my distro so I can compile it, but I
hope I've pointed someone else in the right direction.


___

Reply to this item at:

  http://gna.org/bugs/?20848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20848] Allow the user to have CMA to have no minimum surplus for a category.

2013-05-27 Thread anonymous
URL:
  http://gna.org/bugs/?20848

 Summary: Allow the user to have CMA to have no minimum
surplus for a category.
 Project: Freeciv
Submitted by: None
Submitted on: Mon 27 May 2013 07:13:44 PM UTC
Category: client-gtk-3.0
Severity: 1 - Wish
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: pavel-free...@krivitsky.name
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

At this time, the GTK client, and perhaps the other clients as well, force the
user to set minimum surplus for each category of production to at least -20.

In late-game, this makes it impossible to, e.g., have some cities subsidize
others, and to have a low tax rate for Gold while using production of Coinage
to make up for the deficit: the CMA will turn citizens into Taxmen (and, if
this creates a food shortage, turn itself off) in order to bring the deficit
up to -20.

It would, therefore, be helpful if it were possible to set it to -Infinity, or
to otherwise instruct the CMA to ignore it. This could be accomplished by
either having the leftmost setting on the Minimum Surplus slider be -Infinity
or have a checkbox next to it to control whether a Minimum Surplus should be
enforced.




___

Reply to this item at:

  http://gna.org/bugs/?20848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev