[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-14 Thread pepeto 
Update of bug #22455 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-12 Thread pepeto 
Update of bug #22455 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #5:

Attaching a patch (not tested yet) which looks more correct:
* assign the cost only after all researches and embassies have been set (in
case of tech leakage) ;
* also do it in "savegame.c".

> I would like to investigate to see what changed exactly in
> savegame loading

Previously, this value was not cached. That's the reason.


(file #21690)
___

Additional Item Attachment:

File name: load_savegame_init_researching_cost.patch Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-12 Thread pepeto 
Follow-up Comment #4, bug #22455 (project freeciv):

I would like to investigate to see what changed exactly in savegame loading to
see if the path is fully correct. I think I can do it today.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-11 Thread Marko Lindqvist 
Follow-up Comment #3, bug #22455 (project freeciv):

Pepeto: Should this be "Ready For Test" or do you see some problem with
Andreas' patch?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-11 Thread pepeto 
Update of bug #22455 (project freeciv):

Priority:7 - High => 5 - Normal 
 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-10 Thread Jacob Nevins 
Update of bug #22455 (project freeciv):

 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-10 Thread Andreas Røsdal 
Follow-up Comment #2, bug #22455 (project freeciv):

Attaching a patch which solves the problem by initializing researching_cost
when loading a savegame.

(file #21686)
___

Additional Item Attachment:

File name: initialize_researching_cost.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-10 Thread Andreas Røsdal 
Follow-up Comment #1, bug #22455 (project freeciv):

It seems that the number of bulbs required for the current research target is
set to 0 when loading a savegame, therefore giving the tech immediately when
loading.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22455] Loading from savegame gives current research target immediately

2014-08-09 Thread Andreas Røsdal 
URL:
  

 Summary: Loading from savegame gives current research target
immediately
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 09 Aug 2014 08:47:41 PM UTC
Category: general
Severity: 5 - Blocker
Priority: 7 - High
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Loading from a savegame corrupts the current research process and gives the
current researched technology immediately on the next turn after loading.

To reproduce:
- Start new game, select research to 'Alphabet'. 
- End first turn.
- Save the game.
- Restart, then load the previous savegame.
- Now the research of 'Alphabet' is complete, and will be available in the
next turn, incorrectly.

This was reported here by IZY5O:
http://forum.freeciv.org/f/viewtopic.php?f=16&t=276&start=20#p2123

I can reproduce this problem with the current SVN trunk GTK-2.0 client and on
latest Freeciv-web.  Cazfi to the rescue?  :)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev