Update of patch #1754 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #1, patch #1754 (project freeciv):
I support this change!
Some time ago I started to look into the AI code and also tried to merge
aisettler.(c|h) and settler.(c|h). There should be rules defining which code
should be in server/advisors or ai (in doc/CodingStyle?). Most of the
Follow-up Comment #2, patch #1754 (project freeciv):
The move of server/settler.(c|h) to
server/advisor/autosettler.(c|h) is missing in the patch file.
The define lines are change for the file but it is not moved.
Did not read your comment till the end ... ;-) I think the patch should
Follow-up Comment #3, patch #1754 (project freeciv):
git will detect it but I'm not sure about svn
SVN will detect the deletion of a file and the creation of a new file [for
each moved file], IIRC. It will thus track a spuriously high number of
changed lines. I believe that this is what cazfi
Follow-up Comment #4, patch #1754 (project freeciv):
SVN will detect the deletion of a file and the creation of a new file
This is true once the change is committed. However, if I only make a patch
that removes one file and adds another applying it makes svn really to think
that it's new file
Follow-up Comment #5, patch #1754 (project freeciv):
it requires separate 'svn mv' command
Oops, i forgot about that one. Can it be automated?
___
Reply to this item at:
http://gna.org/patch/?1754
URL:
http://gna.org/patch/?1754
Summary: Move autosettlers code to new advisors directory
Project: Freeciv
Submitted by: cazfi
Submitted on: Wednesday 07/21/2010 at 21:17
Category: general
Priority: 5 -
