[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Status: Need Info = Ready For Test ___ Follow-up Comment #13: Patches for S2_2 and S2_3 attached. My only concern is this change to client/gui-xaw/citydlg.c: - N_(?city:Workers), + N_(Workers), Shouldn't the Q_ macro be used instead or removing the (arguably necessary qualifier)? TBH I'm not sure I understand what the N_ macro does here. :) (file #11666, file #11667) ___ Additional Item Attachment: File name: s2_3-reinstate_xaw_string_changes.diff Size:2 KB File name: s2_2-reinstate_xaw_string_changes.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Assigned to:None = dmarks ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Planned Release: = 2.2.5, 2.3.0-beta2 ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #12, patch #2240 (project freeciv): since 2.2.4 has been published, please revert the string changes ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #4, patch #2240 (project freeciv): Unfortunately, r18683 has stopped the xaw client compiling for me: cc1: warnings being treated as errors citydlg.c: In function ‘get_contents_of_storage’: citydlg.c:256: error: too many arguments for format The problem appears to be that r18634 (bug #17179) added an extra format specifier and parameter to the previous Granary: %3d/%-3d; the string was further modified in r18674; and r18683 reverted the string changes but not the code changes such as the extra parameter. This probably isn't fatal for 2.2.4; I think -Werror is only enabled with --enable-debug=yes, and whether you get a warning for this at all is probably toolchain-dependent. Needs fixing, though. ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #5, patch #2240 (project freeciv): Patch attached. Applying immediately as it fixes a compilation failure. (file #11490) ___ Additional Item Attachment: File name: S2_2-xaw-granary-printf-warning.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #7, patch #2240 (project freeciv): Would you mind applying it to R2_2_4 (the 2.2.4 release tag) as well? ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #9, patch #2240 (project freeciv): Done. ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Follow-up Comment #10, patch #2240 (project freeciv): Version for S2_3 (includes Jacob's fix) - will commit immediately due to the string freeze. (file #11493) ___ Additional Item Attachment: File name: s2_3-revert_client_string_changes.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
URL: http://gna.org/patch/?2240 Summary: Client string changes Project: Freeciv Submitted by: dmarks Submitted on: Mon 06 Dec 2010 02:18:51 AM KST Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Some recent changes to a number of client strings, in particular gui-xaw. ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Status:None = In Progress ___ Follow-up Comment #1: First, to revert the changes to S2_2 to maintain the string freeze. (file #11478) ___ Additional Item Attachment: File name: s2_2-revert_string_changes.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2240] Client string changes
Update of patch #2240 (project freeciv): Status: In Progress = Need Info ___ Follow-up Comment #3: Committed to S2_2. Now, to discuss whether to re-instate some of the changes post-2.2.4. ___ Reply to this item at: http://gna.org/patch/?2240 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
