[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Update of patch #2484 (project freeciv): Planned Release: 2.4.0 = 2.5.0 ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Update of patch #2484 (project freeciv): Planned Release: = 2.4.0 ___ Follow-up Comment #5: - I still think that there should be default irrigation sprites to be used when there is no terrain specific sprites defined. If I understood code correctly, you are now using sprites from first terrain found by terrain_type_iterate that has such sprites. But what if tileset author wants to use specific sprite for first terrain and not the one (s)he wants to be used by default. Order of terrains found by terrain_type_iterate is also subject to change outside tileset control. - Code you have only commented out should be completely removed - I assume common/unit.c change is included to patch accidentally and not really part of this patch Do you have tileset available with which to test this? ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Update of patch #2484 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Follow-up Comment #3, patch #2484 (project freeciv): New patch version. Removed usage of terrain plains. Seems to be doing nothing. Allows use of phrase 'irrigation_sprite = tx.s_some_sprite' or 'irrigation_sprite = tx.some_sprite' in tilespec files. Default sprites are family of 'tx.s_irrigation_%s' If the above is not present, 'tx.irrigation' is used instead. (file #12452) ___ Additional Item Attachment: File name: IrrigationSpriteChoose2.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Follow-up Comment #4, patch #2484 (project freeciv): BTW: Mountain sprites don't have any default name. They use the 'mountains' terrain sprite (if specified) as base tile. ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Follow-up Comment #2, patch #2484 (project freeciv): You cannot assume that all rulesets have terrain named plains. I think tileset should still have default irrigation sprite not tied to any terrain type. All the terrains that don't have their own irrigation sprite defined, would use that. How mine sprites are handled in this respect? ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
Follow-up Comment #1, patch #2484 (project freeciv): + tm = find_terrain_by_rule_name(plains); You cannot assume that all rulesets have terrain named plains. In fact, my aliens ruleset does not. ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2
URL: http://gna.org/patch/?2484 Summary: Choose irrigation sprite ver 2 Project: Freeciv Submitted by: ando3131 Submitted on: Sun 06 Feb 2011 03:48:57 PM GMT Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: It's a second version of the irrigation choosing. Allows to specify irrigation name for terrain in 'tilespec' file, just like it is with mine sprite. If you add line 'irrigation_sprite = tx.some_sprite' for terrain i.e. 'plains', you will see that image as irrigation for this particular terrain in a game. If you add line 'irrigation_sprite = tx.s_some_sprite', game will search for direction-oriented sprites for this terrain. If you don't add any lines, game will load default 'tx.s_irrigation_%s' or 'tx.irrigation' sprites (current mods don't need any changes). Supports direction-specific irrigation. Tested in GTK version. ___ File Attachments: --- Date: Sun 06 Feb 2011 03:48:57 PM GMT Name: IrrigationSpriteChoose.diff Size: 6kB By: ando3131 http://gna.org/patch/download.php?file_id=12290 ___ Reply to this item at: http://gna.org/patch/?2484 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
