[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Follow-up Comment #8, patch #3468 (project freeciv): Copying from bug #22915, since I keep looking for it here: This is last patch to make code clang-3.4 clean in S2_5 and TRUNK. [...] now code is both clang-3.4 and clang-3.5 clean. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Depends on: = patch #4957 ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Depends on: = patch #4785 ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Follow-up Comment #6, patch #3468 (project freeciv): We can aim for Clang-clean with all options like --enable sys-lua enabled to remove as much upstream trouble as possible? The main upstream problem I were thinking about is that MagickWand-config gives bad CPPFLAG for us. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Follow-up Comment #5, patch #3468 (project freeciv): Some things seem like derived from upstreams in a way that we really depend on upstream to fix them. We can aim for Clang-clean with all options like --enable-sys-lua enabled to remove as much upstream trouble as possible? ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Depends on: = patch #4421 ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Follow-up Comment #4, patch #3468 (project freeciv): patch #4421 is now about silencing the evil -Wtautological-compare, and after that the remaining errors seem rather relevant. Not that I'm sure we can reach clang-clean build in freeciv itself ( - we cannot decide the schedule). Some things seem like derived from upstreams in a way that we really depend on upstream to fix them. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Depends on: = patch #4373 ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Follow-up Comment #3, patch #3468 (project freeciv): Looking at the clang warnings lists I'm inclined to say that clang clean build should not be goal for us, or at least many warning types should be silenced with -Wno- -options instead of reworking the code to avoid the warning. For instance the tautological compare warnings because macro expansion often leads to value being compared to itself seem more like something that compiler should use for optimization, not to nag developers about. To work around them would make code much more complicated and likely introduce a lot of real bugs while fixing none. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Planned Release: 2.5.0 = 2.6.0 ___ Follow-up Comment #2: I don't think anybody wants to fight warnings from lua-5.1 and friends when we hopefully get lua-5.2 to use before 2.5 (another release goal?) As lua gets build first, it's rather hard to work on this before lua is updated. There seems to be no progress on that front. I think it's unrealistic to expect us to take project of clang warnings fixing between lua update and 2.5.0 release. So, let's update lua for 2.5 and target clang warning fixing to 2.6. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
URL: http://gna.org/patch/?3468 Summary: Metaticket: Clang clean build Project: Freeciv Submitted by: cazfi Submitted on: Wed 01 Aug 2012 12:59:27 AM EEST Category: bootstrap Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Clang warnings came too late to be considered for systematic fixing in S2_3. However, getting all of them resolved should be release goal at some point. At least for 2.5, 2.4 would be nice, but I don't want to add new goals this late if they end postponing the release - I think that we should commit any fixes to S2_4 too (those that turn out to be real bugs naturally even to S2_3) but accept the fact if they are not all fixed by the time 2.4.0 is otherwise ready. ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Planned Release: = 2.5.0 ___ Follow-up Comment #1: I don't think anybody wants to fight warnings from lua-5.1 and friends when we hopefully get lua-5.2 to use before 2.5 (another release goal?) ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
