[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies

[Marko Lindqvist]

Update of patch #3933 (project freeciv):

  Status:None => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

Handled at hostedredmine: https://www.hostedredmine.com/issues/657144

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies

[Marko Lindqvist]

Update of patch #3933 (project freeciv):

 Planned Release:   2.6.0 => 3.0.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies

[Micke]

Follow-up Comment #2, patch #3933 (project freeciv):

Attachment 1 affects the following files:
common/fc_types.h
common/game.h
common/packets.def
server/citytools.c:unit_enter_city()
server/ruleset.c
I.e. the same ones as the original submission plus fc_types.h - I hope that
was the correct place to define the new enum (on a sidenote, using SPECENUM
was surprisingly easy considering how scary the code looked). Apart from that
I also added another couple of possible settings (see below). I had to add to
the possible cpu workload and player notification spam in unit_enter_city(),
but on the plus side the new code makes use of existing notifications and thus
doesn't add any work for translators.

Attachment 2 affects the game.ruleset files for alien, civ1, civ2, civ2civ3,
classic, experimental and multiplayer. Full addition:
; Method of transferring unit upkeep from cities lost to conquering enemies
; (all styles but None require gold_upkeep_style  0). Where applicable
; units will have their upkeep transferred to the city closest to their
; current location in which they can exist.
; None - (Default) No units are transferred.
; BaseGold - Units with gold only or free of upkeep prior to applying any
;effects have their upkeep transferred.
; EffGold - Units with gold only or free of upkeep after applying player-
;and city effects (including Shield2Gold) have their upkeep transferred.
; BaseNoFood - Units without food upkeep prior to applying any effects have
;their upkeep transferred.
; EffNoFood - Units without food upkeep after applying current effects have
;their upkeep transferred.
; All - All units have their upkeep transferred.
upkeep_transfer_style = None


(file #18056, file #18057)
___

Additional Item Attachment:

File name: upkeep_transfer_style.patchSize:7 KB
File name: uts_rulesets.patch Size:8 KB


___

Reply to this item at:

  http://gna.org/patch/?3933

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies

[Micke]

URL:
  http://gna.org/patch/?3933

 Summary: Method of transferring unit upkeep from cities lost
to conquering enemies
 Project: Freeciv
Submitted by: mss_8734
Submitted on: Mon Jun  3 22:24:19 2013
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This patch introduces game.info.upkeep_transfer_style with values in [0,4] for
transferring unit upkeep from cities lost to conquering enemies (all styles
but 0 require gold_upkeep_style  0).
0 - (Default) No units are transferred.
1 - Units without food- or shield upkeep (including ones affected by
shield2gold) have their upkeep transferred to the city closest to the lost
one.
2 - Units without food upkeep have their upkeep transferred.
3 - All units have their upkeep transferred.

It affects the following files:
common/game.h
common/packets.def
server/citytools.c:unit_enter_city()
server/ruleset.c
data/classic/game.ruleset




___

File Attachments:


---
Date: Mon Jun  3 22:24:19 2013  Name: unit_upkeep_transfer.diff  Size: 6kB  
By: mss_8734

http://gna.org/patch/download.php?file_id=18047

___

Reply to this item at:

  http://gna.org/patch/?3933

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3933] Method of transferring unit upkeep from cities lost to conquering enemies

[Marko Lindqvist]

Update of patch #3933 (project freeciv):

Category:rulesets = general
 Planned Release: = 2.6.0  

___

Follow-up Comment #1:

- You should make sure you don't transfer units to cities where they cannot
exist
- I don't like magic numbers in ruleset format. I'd prefer ruleset to have
textual values that are converted to numerical values at ruleset loading time
- Also, internally the numerical values should be descriptive enum and not 0
... 4.
- Comment documenting the ruleset field should be added to all included
rulesets


Also note to committer if this goes so far: network protocol is changed, so
capstr must be refreshed.

___

Reply to this item at:

  http://gna.org/patch/?3933

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev