[Freeciv-Dev] [patch #4149] Simplify pollution/fallout effect definitions

2013-09-08 Thread Sveinung Kvilhaugsvik
Update of patch #4149 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4149

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4149] Simplify pollution/fallout effect definitions

2013-09-06 Thread Sveinung Kvilhaugsvik
Update of patch #4149 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = sveinung   

___

Follow-up Comment #2:

Unless anyone objects I'll apply the patch simplifying the definitions.

___

Reply to this item at:

  http://gna.org/patch/?4149

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4149] Simplify pollution/fallout effect definitions

2013-09-05 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?4149

 Summary: Simplify pollution/fallout effect definitions
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Sep 2013 11:15:45 PM EEST
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

All our rulesets have long list of pollution and fallout effects, one effect
for each output type. As the effect is same for each output type, I think it
would be possible to have just one effect to apply all the output types (to
not have output type requirement at all).
Note that while there's output types that do not apply to tile
(Tax/Lux/Science), Output_Tile_Punish_Pct effect is never checked for them
(for the very reason that it checks for tile output).




___

Reply to this item at:

  http://gna.org/patch/?4149

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4149] Simplify pollution/fallout effect definitions

2013-09-05 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4149 (project freeciv):

  As the effect is same for each output type, I think it would be possible to
have just one effect to apply all the output types
It is. When I wrote them I assumed separate effect definitions was wanted to
make it easy for modders to set each value separately like they did before.

(file #18884)
___

Additional Item Attachment:

File name: reduceOutputPunish.patch   Size:19 KB


___

Reply to this item at:

  http://gna.org/patch/?4149

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev