[Freeciv-Dev] [patch #4351] SDL client support for nation sets
Update of patch #4351 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4351] SDL client support for nation sets
Update of patch #4351 (project freeciv): Status:None = In Progress ___ Follow-up Comment #1: WIP patch for TRUNK, sdl2-client only. Network protocol changed so that nation availability packet tells if it's being sent because of nationset change or because someone picked/unpicked a nation. That's used to avoid double dialog update when first nation availability changes and then changes the value of the nationset option (required to show correct nationset in the selection widget). TODO: - sdl-client (TRUNK / S2_5) - make network protocol change optional in S2_5 (probably meaning slow and ugly double update for the dialog when server is beta1 one) Note that we have to wait for server to send new option value back to us - we can't just update the dialog with the value we're requesting, as the request may fail for some reason, or nationset change might be requested by someone else than us. (file #21663) ___ Additional Item Attachment: File name: SdlNationset.patch Size:20 KB ___ Reply to this item at: http://gna.org/patch/?4351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4351] SDL client support for nation sets
Update of patch #4351 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: First commit candidates. Sdl-client (unlike sdl2-client) does not work on my computer at all, so could someone test it for me? (I'm just blindly ported stuff from sdl2-client optional capability handling, and tested that it compiles) (file #21664, file #21665) ___ Additional Item Attachment: File name: SdlNationset-2.patch.bz2 Size:5 KB File name: SdlNationset-S2_5.patchSize:20 KB ___ Reply to this item at: http://gna.org/patch/?4351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4351] SDL client support for nation sets
Follow-up Comment #3, patch #4351 (project freeciv): could someone test it for me? Had a quick look; it compiles and seems to work for me, thanks. ___ Reply to this item at: http://gna.org/patch/?4351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4351] SDL client support for nation sets
URL: http://gna.org/patch/?4351 Summary: SDL client support for nation sets Project: Freeciv Submitted by: jtn Submitted on: Fri Dec 20 23:58:30 2013 Category: client-sdl Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0,2.6.0 ___ Details: The pick nation UI in the SDL/SDL2 clients should properly support the nation set concept of patch #3448. Minimal support would be adding a dropdown to choose the nation set, but popping down the dialog whenever it changes. Full support would be to keep the dialog up and adapt to the changes in available nations (as in the Gtk clients post patch #4349). ___ Reply to this item at: http://gna.org/patch/?4351 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
