[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 [EMAIL PROTECTED] - Mar. Oct. 09 23:27:21 2007]: Oh joy, I guess that will break network compatibility then, so that means a serverside fix for 2.0 .. My propositions of changing packets is only for next released versions (like

Re: [Freeciv-Dev] (PR#39765) optimized resources change with terrain changes

2007-10-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39765 S2_1 r13741 S2_2 r13742 trunk r13743 Here's the patch variant applied to S2_2 and trunk: Index: server/settlers.c === --- server/settlers.c (revision 13741) +++

Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 Pepeto _ wrote: Sounds a good idea. This packets could be considered as diplomat actions. Looks quickly doable for 2.1. Writing patch now. Waste of time for 2.0, as nobody found this cheat in a decade, it's not important enough, and

[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 [wsimpson - Mer. Oct. 10 11:55:32 2007]: Pepeto _ wrote: Sounds a good idea. This packets could be considered as diplomat actions. Looks quickly doable for 2.1. Writing patch now. Good news! Waste of time for 2.0, as nobody

[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 [wsimpson - Mer. Oct. 10 18:37:12 2007]: Here's a simple 2.1b6 replacement, untested. It simply checks whether the diplomat can actually execute the desired command. Please check against your favorite clients. Sorry, I

[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 I note too that the first reported problem is still not fixed in your patch: unit bribe cost should be recalculated when the server receive the packet for bribe unit. Because some hacked client could send directly DIPLOMAT_BRIBE without

Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 You're correct, I was concentrating on the network and dialog compatibility issues, and forgot to look at the cost itself. I don't think it should be saved at all! It really exists for the client side, and I'm not sure it's needed