[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-11 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 [wsimpson - Mer. Oct. 10 21:22:15 2007]: You're correct, I was concentrating on the network and dialog compatibility issues, and forgot to look at the cost itself. I don't think it should be saved at all! It really exists for

Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-11 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 Eliminated both city incite cost and unit bribe cost variables. The incite cost was never properly initialized in either the client or server. The bribe cost was -1 in the server and 0 in the client. Pass them as a parameter instead.

[Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-11 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 maybe_cause_incident() removed in void spy_send_sabotage_list(): is it normal? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39767) pf code doesn't allow to bribe sea units

2007-10-11 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39767 The path finding code doesn't allow diplomat to bribe sea units. For example, a diplomat cannot have a path to a unit on sea. There are 2 possibilities: 1- Bribing units on sea is a bug, then pf code is right. 2- Bribing units on sea is

[Freeciv-Dev] (PR#39768) Old savegames don't reload goto orders properly

2007-10-11 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39768 When you reload save game where units are doing ACTIVITY_GOTO (which is not supported on current server), it doesn't convert it to the new code (path finding tool). Then your units are marked 'G', but they never move.

Re: [Freeciv-Dev] (PR#39763) [editor] terrain panel and specials

2007-10-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39763 On 07/10/2007, Daniel Markstedt wrote: We should simplify the editor panel to have two buttons 'special 1' and 'special 2' that produce the appropriate special for the terrain it's used on. The current system is impractical for

Re: [Freeciv-Dev] (PR#39756) [Bug] Compatibility problem with ReportFreezeFix

2007-10-11 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39756 On 08/10/2007, Pepeto _ wrote: On 07/10/2007, Pepeto _ wrote: What is the actual cause of this bug? The cause is that the science report is not updated when the bulbs stock changes. When is it updated?

[Freeciv-Dev] (PR#39756) [Bug] Compatibility problem with ReportFreezeFix

2007-10-11 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39756 I got a other idea (ugly hack): /** Send PACKET_FREEZE_CLIENT to all clients capable of handling it.

Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-11 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 Pepeto _ wrote: maybe_cause_incident() removed in void spy_send_sabotage_list(): is it normal? Yes, it was special cased in maybe_cause_incident(), and now the symbol will no longer exist. It's a dialog/support query, not a unit

Re: [Freeciv-Dev] (PR#39730) [Bug] Server allows bribe cheating

2007-10-11 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39730 Pepeto _ wrote: All looks work well now. Thank you for your fast work. Thank you for your initial report and rapid testing! Admittedly, my first patch was fast trying to be done before the release. It just followed the