[Freeciv-Dev] [bug #18764] No Governments available for switching

2012-01-22 Thread Jacob Nevins
Follow-up Comment #8, bug #18764 (project freeciv): Spotted in passing: this bail-out check in real_menus_update() looks wrong to me: if (NULL == ui_manager && !can_client_change_view()) { return; } I'd have thought it should be ||, not &&. Any other opinions? This came in in patch #1

[Freeciv-Dev] [bug #18764] No Governments available for switching

2012-01-22 Thread Jacob Nevins
Follow-up Comment #9, bug #18764 (project freeciv): Okay, this is weird. I've been festooning the code with debugging, and the attached debugging patch to S2_3 r20596 -- which I don't think should make any difference to behaviour -- reliably makes the bug go away for me. (This is a cut-down versi

[Freeciv-Dev] [bug #18764] No Governments available for switching

2012-01-22 Thread Jacob Nevins
Follow-up Comment #10, bug #18764 (project freeciv): Couple more bits of information: Bug goes away for me with -O0 but is present with -O1. There was some talk in an old thread of gtk_action_get_proxies() unexpecte