Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > This has been waiting since 2004 Oct -- really shouldn't let better be the enemy of good. There are many more LOG_FATAL and LOG_ERROR than LOG_NORMAL. Will do others later, as they are likely reductions in translation rather than more translation Committed S2_2 revision 14370, with update-po to add TRANS comments. Committed trunk revision 14371. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > Christian Knoke wrote: > log messages shouldn't be translated at all. They go into a log file, the > user won't see them, usually. They go there for 2 purposes: development and > bug hunting, and scripting. For both, they are best in english. > Actually, LOG_FATAL, LOG_ERROR, and LOG_NORMAL are also displayed to users. It's a fairly sophisticated system, somebody did some nice work here! For the server, as a response to loading files, finding/failing installation, or various user commands, the output is displayed translated. For the client, some similar information is displayed in the "Chat" window. There's a minimal amount of direction in doc/HACKING, and more at: http://freeciv.wikia.com/wiki/Internationalization#Logging The hard part for the developer is deciding what is useful to translate. I've added the new LOG_* equivalents to indicate the results of that decision. There was some debate about this in PR#39725 and elsewhere. > Currently (at least in 2.1) there are not translated AFAICS. It would give > unnecessary work for translators. > Actually, in 2.1 far too many are translated, particularly in gui-sdl, where even LOG_DEBUG was routinely translated. I've been removing unnecessary stuff whenever I've found them. And causing debate. I'll do some more checking LOG_ERROR and LOG_FATAL, and post a revised patch. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
Hello, William Allen Simpson wrote on Jan 25, 14:04 (-0800): > Went through *all* the 2.2 sources. Found quite a few that are debugging > messages, not "normal" user messages. New symbols LOG_TEST (same level as > LOG_NORMAL) and LOG_PACKET (same level as LOG_VERBOSE). log messages shouldn't be translated at all. They go into a log file, the user won't see them, usually. They go there for 2 purposes: development and bug hunting, and scripting. For both, they are best in english. Currently (at least in 2.1) there are not translated AFAICS. It would give unnecessary work for translators. Christian -- Christian Knoke* * *http://cknoke.de * * * * * * * * * Ceterum censeo Microsoft esse dividendum. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 >
Went through *all* the 2.2 sources. Found quite a few that are debugging
messages, not "normal" user messages. New symbols LOG_TEST (same level as
LOG_NORMAL) and LOG_PACKET (same level as LOG_VERBOSE).
Actually results in very few new messages to translate:
Index: utility/inputfile.c
===
--- utility/inputfile.c (revision 14283)
+++ utility/inputfile.c (working copy)
@@ -592,7 +592,7 @@
func = tok_tab[type].func;
if (!func) {
-freelog(LOG_NORMAL, "token type %d (%s) not supported yet", type, name);
+freelog(LOG_ERROR, "token type %d (%s) not supported yet", type, name);
c = NULL;
} else {
if (!have_line(inf))
Index: utility/ioz.c
===
--- utility/ioz.c (revision 14283)
+++ utility/ioz.c (working copy)
@@ -107,13 +107,13 @@
#ifndef HAVE_LIBZ
if (method == FZ_ZLIB) {
- freelog(LOG_NORMAL, "Not compiled with zlib support, reverting to
plain.");
+ freelog(LOG_ERROR, "Not compiled with zlib support, reverting to
plain.");
method = FZ_PLAIN;
}
#endif
#ifndef HAVE_LIBBZ2
if (method == FZ_BZIP2) {
- freelog(LOG_NORMAL, "Not compiled with bzib2 support, reverting to
plain.");
+ freelog(LOG_ERROR, "Not compiled with bzib2 support, reverting to
plain.");
method = FZ_PLAIN;
}
#endif
Index: utility/ftwl/widget_window.c
===
--- utility/ftwl/widget_window.c(revision 14283)
+++ utility/ftwl/widget_window.c(working copy)
@@ -389,14 +389,12 @@
be_copy_osda_to_screen(whole_osda, NULL);
if (dump_screen) {
-static int counter = -1;
+static int counter = 0;
char b[100];
-counter++;
+my_snprintf(b, sizeof(b), "fc_%05d.ppm", counter++);
+freelog(LOG_NORMAL, _("Making screenshot %s"), b);
-freelog(LOG_NORMAL, "flush to screen %d",counter);
-
-sprintf(b, "screen-%04d.ppm", counter);
be_write_osda_to_file(whole_osda, b);
}
}
Index: utility/ftwl/text_renderer.c
===
--- utility/ftwl/text_renderer.c(revision 14283)
+++ utility/ftwl/text_renderer.c(working copy)
@@ -190,7 +190,7 @@
ft_kerning_default, &delta);
pen.x += delta.x >> 6;
if (0 && delta.x)
- freelog(LOG_NORMAL, "kerning between %c and %c is %ld in '%s'\n",
+ freelog(LOG_VERBOSE, "kerning between %c and %c is %ld in '%s'\n",
text[i - 1], c, delta.x >> 6, text);
}
Index: utility/ftwl/be_sdl_pixels_32.c
===
--- utility/ftwl/be_sdl_pixels_32.c (revision 14283)
+++ utility/ftwl/be_sdl_pixels_32.c (working copy)
@@ -67,12 +67,12 @@
}
atexit(SDL_Quit);
- freelog(LOG_NORMAL, "Using Video Output: %s",
+ freelog(LOG_NORMAL, _("Using Video Output: %s"),
SDL_VideoDriverName(device, sizeof(device)));
{
const SDL_VideoInfo *info = SDL_GetVideoInfo();
-freelog(LOG_NORMAL, "Video memory of driver: %dkb", info->video_mem);
-freelog(LOG_NORMAL, "Preferred depth: %d bits per pixel",
+freelog(LOG_VERBOSE, "Video memory of driver: %dkb", info->video_mem);
+freelog(LOG_VERBOSE, "Preferred depth: %d bits per pixel",
info->vfmt->BitsPerPixel);
}
@@ -104,12 +104,12 @@
exit(1);
}
- freelog(LOG_NORMAL, "Got a screen with size (%dx%d) and %d bits per pixel",
+ freelog(LOG_VERBOSE, "Got a screen with size (%dx%d) and %d bits per pixel",
screen->w, screen->h, screen->format->BitsPerPixel);
- freelog(LOG_NORMAL, " format: red=0x%x green=0x%x blue=0x%x mask=0x%x",
+ freelog(LOG_VERBOSE, " format: red=0x%x green=0x%x blue=0x%x mask=0x%x",
screen->format->Rmask, screen->format->Gmask,
screen->format->Bmask, screen->format->Amask);
- freelog(LOG_NORMAL, " format: bits-per-pixel=%d bytes-per-pixel=%d",
+ freelog(LOG_VERBOSE, " format: bits-per-pixel=%d bytes-per-pixel=%d",
screen->format->BitsPerPixel, screen->format->BytesPerPixel);
SDL_EnableUNICODE(1);
SDL_EnableKeyRepeat(SDL_DEFAULT_REPEAT_DELAY, SDL_DEFAULT_REPEAT_INTERVAL);
Index: utility/ftwl/be_sdl.c
===
--- utility/ftwl/be_sdl.c (revision 14283)
+++ utility/ftwl/be_sdl.c (working copy)
@@ -119,7 +119,7 @@
Uint16 unicode = sdl_event->key.keysym.unicode;
if (unicode == 0) {
- freelog(LOG_NORMAL, "unicode == 0");
+ freelog(LOG_TEST, "unicode == 0");
return FALSE;
}
if ((unicode & 0xFF80) != 0) {
@@ -140,7 +140,7 @@
exit(EXIT_SUCCESS);
default:
-// freelog(LOG_NORMAL, "ignored event %d\n", sdl_event->type);
+// free
Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > On 10/7/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=10400 > > > Lately, your patches have been formatted with base64 as > application/octet-stream, usually reserved to binary data. > That actually makes them much longer than the original text, > and difficult to review (and impossible to search for later). > That's odd. I've not changed my method (svn diff) over the last few years. Gmail bug? > Are we OK with making changes to the translated messages > for 2.1 before release? Per's rule was no changes. > > I guess this is not significant enough to warrant string changes to S2_1. Only critical fixes should go in at this stage. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > Lately, your patches have been formatted with base64 as application/octet-stream, usually reserved to binary data. That actually makes them much longer than the original text, and difficult to review (and impossible to search for later). Are we OK with making changes to the translated messages for 2.1 before release? Per's rule was no changes. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > > [dmarks - Sun Oct 07 09:52:41 2007]: > > > [vasc - Fri Oct 01 11:09:06 2004]: > > > > On Fri, 1 Oct 2004, Jason Short wrote: > > > > > > > > http://rt.freeciv.org/Ticket/Display.html?id=10400 > > > > > > > In sernet.c there are a lot of untranslated LOG_NORMAL messages. There > > > may be more elsewhere. > > > > > > Is there a reason for this? > > > > I forgot to mark the pingtimeout freelog strings for translation. > > > > --- > > Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa > > > > > > > > > > > > Patch for sernet.c attached. > > ~Daniel > Went through all c source files in server/ and its subdirectories and marked LOG_NORMAL for i18n. Some of them seems quite obscure - particularly in unittools.c - so maybe they shouldn't be LOG_NORMAL? Patch untested. ~Daniel localize_log_normal.diff Description: Binary data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > > [vasc - Fri Oct 01 11:09:06 2004]: > > On Fri, 1 Oct 2004, Jason Short wrote: > > > > > http://rt.freeciv.org/Ticket/Display.html?id=10400 > > > > > In sernet.c there are a lot of untranslated LOG_NORMAL messages. There > > may be more elsewhere. > > > > Is there a reason for this? > > I forgot to mark the pingtimeout freelog strings for translation. > > --- > Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa > > > > > Patch for sernet.c attached. ~Daniel localize_sernet_c.diff Description: Binary data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
